David Glasser
a9a7179ebf
Follow-up to 26c725 to work on more browsers.
...
Windows Safari (eg) seems to apply the "uncheck existing radios when new radios
are created" even earlier than other browsers, so save values earlier.
2013-01-03 15:33:42 -08:00
David Glasser
fd13a9b899
http: Fix incorrect use of self in param encoding.
2013-01-03 14:56:45 -08:00
David Glasser
25af4e5cdb
http: Fix test failure on FF caused by 3bada2a.
2013-01-03 14:56:02 -08:00
David Glasser
46e772c0ef
Merge branch 'devel' into release-0.5.3
...
Pull in fix to #392 .
2013-01-03 10:34:00 -08:00
David Glasser
95974f82fb
Fix server-side observe with no added callback. Fixes #589 .
...
The cursor de-dup code introduced in Meteor 0.5.1 had a bug where a server-side
`observe` with no `added` callback would throw an error if the `observe` was
de-duped.
2013-01-03 10:16:21 -08:00
David Greenspan
5eae5eae4c
Further protect from stack traces on re-render
2013-01-02 18:10:48 -08:00
David Greenspan
577e1b6b12
Fix #392 - Spark.isolate prints stack trace
...
Isolates would print a stack trace upon re-render
if their DOM nodes had been manually removed from
the DOM without called Spark.finalize.
2013-01-02 18:07:58 -08:00
David Glasser
4c5ea61beb
Merge branch 'devel' into release-0.5.3
...
Bring in Meteor.http.call JSON header improvement.
2012-12-28 15:59:30 -08:00
David Glasser
3bada2a9f9
If Meteor.http.call JSON-ifies the request body, default the Content-Type to
...
application/json.
This matches our heuristic for deciding whether to parse responses as JSON.
2012-12-28 15:58:41 -08:00
David Glasser
8a2328b27f
Fix lookup by fields beginning with numbers (broken by 2d2aaa808).
2012-12-27 16:32:55 -08:00
David Glasser
2987b210d2
Merge branch 'devel' into release-0.5.3
...
This consists of three Accounts-related pull requests, which I will add to
History.md in the next commit.
2012-12-27 13:28:02 -08:00
Avital Oliver
7cd4082457
Remove arguably unhelpful check
2012-12-27 01:00:17 -08:00
Tim Haines
d62942627e
Add statusCode and data to OAuth1Binding call response error
2012-12-27 01:00:17 -08:00
Tim Haines
b5ae25ac3f
Encode ! and other special characters in params for Meteor.http.call and oauth1 methods
2012-12-27 01:00:17 -08:00
David Glasser
26c7258027
Follow-up to 442b86: fix re-rendering of unfocused radio buttons.
...
Before 442b86, this worked because we always unconditionally made tgt checked if
src was checked. With the new 3-way-diff algorithm for value and checkedness, we
need to save the checkedness of tgt before any DOM manipulation that could
uncheck it.
2012-12-27 00:06:42 -08:00
Avital Oliver
de90c75551
Rename css files in oauth login provider packages
2012-12-26 23:04:15 -08:00
Avital Oliver
a0b497e926
Simplify and fix accounts-ui listing of login services
2012-12-26 23:04:15 -08:00
Alex Notov
d248f15a41
Remove whitespace
2012-12-26 23:04:15 -08:00
Alex Notov
8c8fdc93cb
Oops, we should memoize the last service in case we need to swap
2012-12-26 23:04:15 -08:00
Alex Notov
09d5c94522
Make sure password is last
2012-12-26 23:04:15 -08:00
Alex Notov
6356b73ef8
Remove uniqueness check. Devs shouldn't be idiots :)
2012-12-26 23:04:14 -08:00
Alex Notov
15513fd96c
Variable declarations on one line; self instead of that.
2012-12-26 23:04:14 -08:00
Alex Notov
a16dd5c158
Vastly simplify by removing the JSON parsing.
...
Instead, just run _.uniq on the Accounts._loginButtons.loginServices.
DUH. PRESTO!
2012-12-26 23:04:14 -08:00
Alex Notov
2c195c0b04
Add password to the available service buttons if it's included
2012-12-26 23:04:14 -08:00
Alex Notov
bc242ccc86
Accounts._loginButtons.getLoginServices returns unique services
...
This may be improved by passing an iterator to _.uniq instead of doing
this malarkey I did for the first run with JSON stringify and parse. ^_^
2012-12-26 23:04:14 -08:00
Alex Notov
423fc1d71e
Tests for the functionality we want
2012-12-26 23:04:14 -08:00
Alex Notov
28b42e924e
Removed linkedin package from this PR
...
Login services should be defined from within their packages
Corresponding login service assets (images and css should be in their respective packages not inside of accounts-ui-unstyled)
Conflicts:
packages/accounts-linkedin/linkedin_client.js
packages/accounts-linkedin/package.js
packages/accounts-ui-unstyled/login_buttons.js
packages/accounts-ui-unstyled/login_buttons_images.css
2012-12-26 23:04:14 -08:00
Avital Oliver
1e09d4ee8d
Some minor modifications to 79405a495d
2012-12-26 18:06:39 -08:00
Martin Naumann
79405a495d
Adding expiresAt property to Google login data for accounts-google. fixes #525
2012-12-26 17:50:15 -08:00
David Glasser
32870ea933
Spark: Test that patching "<input type=checkbox/radio checked>" onto unchecked
...
input works.
This test was extracted from a fix for this specific issue #478 which
accidentally never got merged; 442b86eebd ended up fixing this issue with a
slightly different change than the unmerged fix.
2012-12-24 11:12:26 -08:00
Matt DeBergalis
821a237082
madewith banner tweaks.
...
Don't show ??? and don't propagate click event if app isn't found.
2012-12-19 17:23:56 -08:00
Nick Martin
326b316d36
Mark messages as unsent when we reconnect. Sent means 'sent on this connection' not 'ever sent'. Fixes #538 .
2012-12-18 16:10:36 -08:00
David Glasser
8ad174eead
Feedback from review of skip/limit fix:
...
- Keep upsert as an error.
- Keep if (before||after) check.
- Add some comments.
2012-12-18 10:19:53 -08:00
David Glasser
e9913d2055
Fix to skip/limit observe: update would never produce 'changed' calls.
...
Also remove dead upsert code.
2012-12-17 23:39:13 -08:00
David Glasser
2d2aaa8082
minimongo: Implement ordinal indexing: {'foo.1.bar': 42}
2012-12-17 21:35:12 -08:00
Nick Martin
48423c21d0
Feedback from review.
2012-12-17 14:53:40 -08:00
Nick Martin
4c78d3dc51
Make sub-key sort check for undefined before dereferencing.
...
This way it doesn't throw when given an object that doesn't contain all the keys being searched on.
2012-12-17 14:53:40 -08:00
Nick Martin
7b8682b3fb
Test for sub-key sort. Doesn't pass yet.
2012-12-17 14:53:40 -08:00
lvbreda
bd94569d86
Added sorting functionality for 'a.b'
2012-12-17 14:53:40 -08:00
David Glasser
e32502c20c
Add a fast path to limited unsorted unskipped queries.
2012-12-17 14:44:02 -08:00
David Glasser
ac81438f74
Refinements to limit/skip observe support:
...
- Decide that queries need to be recomputed in _modifyAndNotify directly
instead of in _removeFromResults and friends; this is because the choice of
which _fooFromResults function to invoke might not actually be correct in the
presence of skip and limit. (The previous code still worked because all three
of those functions had the same code for the skip/limit case.)
- If update or remove affects more than one doc for a query, only recompute it
once at the end instead of once per doc.
2012-12-17 14:44:02 -08:00
Nick Martin
33fa24e912
Make find(1) and find({_id: 1}) return the same thing.
2012-12-17 14:44:02 -08:00
Nick Martin
2d9e8a8fd6
Move some tests around. No functional changes.
2012-12-17 14:44:02 -08:00
Nick Martin
0faaa07c77
Feedback from review.
2012-12-17 14:44:02 -08:00
Nick Martin
aee54f3ac0
Add skip and limit support to observe.
2012-12-17 14:44:02 -08:00
David Glasser
f68a8a3431
Add a XXX caveat to #346 fix.
2012-12-17 10:06:48 -08:00
David Glasser
3d870954ca
Fix queries and updates with JS RegExp objects with //i and //m flags.
...
Follow-up to 28a136d7 continuing to address issue #346 .
2012-12-14 15:14:04 -08:00
Tim Haines
d85497a275
Fix capturing the twitter identity information
2012-12-12 16:16:02 -08:00
David Glasser
cd250f0945
tinytest: drop results for a run when requested by client, not onComplete.
...
Should be useful for a non-browser-based test runner.
2012-12-12 12:55:44 -08:00
Tim Haines
0b1ced1aa2
Have an oauth call return the result including headers and statusCode, not just the data
2012-12-11 17:00:11 -08:00