github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
44cdfeb68630dc2fc8bb99650fead73c40748ee4
meteor/tools/tests/command-line.js
Hugh Willson 540dc00230 Add a self-test skip option (#9579) 
* Add a self-test skip option

Meteor's CI infrastructure is configured to exclude certain
`self-test`'s on each run. These excludes are specified in
each CI environment's config file, and included when running
`meteor self-test`. Developers running `meteor self-test`
locally however are not using these excludes by default,
so developer's have to manually look up the current exclude
list from one of the CI configs, then add these excludes to
their own `meteor self-test` call manually.

This commit adds a new `skip` option to Meteor's `self-test`
system, that can be used to skip adding/running a defined
`self-test` (similar in concept to Mocha's `skip` feature).
This provides a way to skip the running of older
`self-test`'s that are no longer needed, but allows them to
be preserved in the `self-test` suite, for future reference.
With this functionality in place, and the older test suites
updated to use it, Meteor's base CI excludes no longer need
to be maintained in their respective config files. The
excludes are all managed at the source (the test definition),
and can be leveraged by anyone/anything calling
`meteor self-test`.

* Log message describing skipped test

* Add manually-ignored count to self-test summary

* Small comment correction

* History.md entry with PR link
2018-01-29 14:25:09 +02:00

671 lines
19 KiB
JavaScript
Raw Blame History

var selftest = require('../tool-testing/selftest.js');
var Sandbox = selftest.Sandbox;
var archinfo = require('../utils/archinfo.js');
var release = require('../packaging/release.js');
var _ = require('underscore');
var files = require('../fs/files.js');
var utils = require('../utils/utils.js');
var runMongo = require('../runners/run-mongo.js');
selftest.define("argument parsing", function () {
var s = new Sandbox;
var run;
// bad command
run = s.run("aoeuasdf");
run.matchErr("not a Meteor command");
run.waitSecs(5);
run.expectExit(1);
// bad subcommand
run = s.run("admin", "aoeuasdf");
run.matchErr("not a Meteor command");
run.waitSecs(5);
run.expectExit(1);
// missing subcommand
run = s.run("admin");
run.matchErr("for available commands");
run.waitSecs(5);
run.expectExit(1);
// conflicting command-like options
run = s.run("aoeuasdf", "--version");
run.matchErr("pass anything else along with --version");
run.waitSecs(5);
run.expectExit(1);
run = s.run("--arch", "--version");
run.matchErr("pass anything else");
run.waitSecs(5);
run.expectExit(1);
run = s.run("run", "--version");
run.matchErr("pass anything else");
run.waitSecs(5);
run.expectExit(1);
run = s.run("--arch", "--arch");
run.matchErr("more than once");
run.waitSecs(5);
run.expectExit(1);
// --release takes exactly one value
run = s.run("--release");
run.matchErr("needs a value");
run.waitSecs(5);
run.expectExit(1);
run = s.run("--release", "abc", "--release", "def");
run.matchErr("should only be passed once");
run.waitSecs(5);
run.expectExit(1);
// required option missing
run = s.run("dummy");
run.matchErr("option is required");
run.matchErr("Usage: meteor dummy");
run.waitSecs(5);
run.expectExit(1);
// successful command invocation, correct parsing of arguments
run = s.run("dummy", "--ething", "x");
run.read('"x" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
// The tests below fail on Windows. There is a bug in Node about empty
// arguments that was fixed recently:
// https://github.com/joyent/node/issues/7138
if (process.platform !== "win32") {
run = s.run("dummy", "--ething", "");
run.read('"" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "", "");
run.read('"x" "3000" none ["",""]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
}
run = s.run("dummy", "--ething=");
run.read('"" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "-e=");
run.read('"" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-");
run.read('"x" "3000" none ["-"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "-e", "x");
run.read('"x" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
// See comment above about empty arguments
if (process.platform !== "win32") {
run = s.run("dummy", "-e", "");
run.read('"" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
}
run = s.run("dummy", "-exxx");
run.read('"xxx" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "-");
run.read('"-" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "--port", "1234", "--changed");
run.read('"x" 1234 true []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "--port", "0", "true");
run.read('"x" 0 none ["true"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "--port", "01234", "12", "0013");
run.read('"x" 1234 none ["12","0013"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "--port", "1234", "--changed");
run.read('"--port" "3000" true ["1234"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething=x=y=z", "-Up=3000");
run.read('"x=y=z" 3000 none []\nurl\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
// bad option
run = s.run("dummy", "--ething", "x", "--foo");
run.matchErr("--foo: unknown option");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-z");
run.matchErr("-z: unknown option");
run.expectExit(1);
// passing short and long options
run = s.run("dummy", "--ething", "x", "-p", "2000", "--port", "2000");
run.matchErr("can't pass both -p and --port");
run.expectExit(1);
// multiple values for an option
run = s.run("dummy", "--ething", "x", "--port", "2000", "--port", "3000");
run.matchErr("can only take one --port option");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-p", "2000", "-p", "2000");
run.matchErr("can only take one --port (-p) option");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "--changed", "--changed");
run.matchErr("can only take one --changed option");
run.expectExit(1);
// missing option value
run = s.run("dummy", "--ething", "x", "--port");
run.matchErr("the --port option needs a value");
run.expectExit(1);
run = s.run("dummy", "--ething");
run.matchErr("--ething option needs a value");
run.expectExit(1);
run = s.run("dummy", "-e");
run.matchErr("--ething (-e) option needs a value");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "--changed", "-p");
run.matchErr("the --port (-p) option needs a value");
run.expectExit(1);
// non-numeric value for numeric option
run = s.run("dummy", "--ething", "x", "--port", "kitten");
run.matchErr("--port must be a number");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-p", "1234k");
run.matchErr("--port (-p) must be a number");
run.expectExit(1);
// bad use of =
run = s.run("dummy", "--=");
run.readErr("Option names cannot begin with '='.\n");
run.expectExit(1);
run = s.run("dummy", "--=asdf");
run.readErr("Option names cannot begin with '='.\n");
run.expectExit(1);
run = s.run("dummy", "-=");
run.readErr("Option names cannot begin with '='.\n");
run.expectExit(1);
run = s.run("dummy", "-ex", "--changed=foo");
run.matchErr("the --changed option does not need a value.\n");
run.expectExit(1);
run = s.run("dummy", "-ex", "-D=foo");
run.matchErr("the --delete (-D) option does not need a value.\n");
run.expectExit(1);
run = s.run("dummy", "-ex", "-UD=foo");
run.matchErr("the --delete (-D) option does not need a value.\n");
run.expectExit(1);
// incorrect number of arguments
run = s.run("dummy", "--ething", "x", "1", "2", "3");
run.matchErr("too many arguments");
run.matchErr("Usage: meteor dummy");
run.expectExit(1);
run = s.run("bundle");
run.matchErr("not enough arguments");
run.matchErr("This command has been deprecated");
run.expectExit(1);
run = s.run("bundle", "a", "b");
run.matchErr("too many arguments");
run.matchErr("This command has been deprecated");
run.expectExit(1);
run = s.run("build");
run.matchErr("not enough arguments");
run.matchErr("Usage: meteor build");
run.expectExit(1);
run = s.run("build", "a", "b");
run.matchErr("too many arguments");
run.matchErr("Usage: meteor build");
run.expectExit(1);
// '--' to end parsing
run = s.run("dummy", "--ething", "x", "--", "-p", "4000");
run.read('"x" "3000" none ["-p","4000"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "--", "--changed", "--changed");
run.read('"x" "3000" none ["--changed","--changed"]\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "--");
run.read('"x" "3000" none []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
// compact short options
run = s.run("dummy", "--ething", "x", "-p4000", "--changed");
run.read('"x" 4000 true []\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-UD", "--changed");
run.read('"x" "3000" true []\nurl\n\delete\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-UDp4000", "--changed");
run.read('"x" 4000 true []\nurl\ndelete\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-UDp4000", "--changed");
run.read('"x" 4000 true []\nurl\ndelete\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-UDp4000");
run.read('"x" 4000 none []\nurl\ndelete\n');
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
run = s.run("dummy", "--ething", "x", "-UDkp4000", "--changed");
run.matchErr("-k: unknown option");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-UDp4000k", "--changed");
run.matchErr("--port (-p) must be a number");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-UD4000k", "--changed");
run.matchErr("-4: unknown option");
run.expectExit(1);
run = s.run("dummy", "--ething", "x", "-UDDp4000", "--changed");
run.matchErr("one --delete (-D) option");
run.expectExit(1);
// requiring an app dir
run = s.run("list");
run.matchErr("not in a Meteor project");
run.matchErr("meteor create"); // new user help
run.expectExit(1);
s.createApp('myapp', 'standard-app');
s.cd('myapp', function () {
run = s.run("list");
run.waitSecs(60);
run.expectExit(0);
});
s.createApp("app-with-extra-packages", "extra-packages-option", {
dontPrepareApp: true
});
s.cd("app-with-extra-packages", function () {
run = s.run("--extra-packages", "extra-package-1, extra-package-2@=0.0.2");
run.waitSecs(60);
run.match("extra-package-1: foobar");
run.match("extra-package-2: barfoo");
run.stop();
});
s.createApp("app-with-extra-packages", "extra-packages-option", {
dontPrepareApp: true
});
s.cd("app-with-extra-packages", function () {
run = s.run("test",
"--extra-packages", "tmeasday:acceptance-test-driver, extra-package-1, extra-package-2@=0.0.2",
"--driver-package", "tmeasday:acceptance-test-driver");
run.waitSecs(60);
run.match("extra-package-1: foobar");
run.match("extra-package-2: barfoo");
run.stop();
});
s.createApp("app-with-extra-packages", "extra-packages-option", {
dontPrepareApp: true
});
s.cd("app-with-extra-packages", function () {
run = s.run("test-packages", "--once",
"--driver-package", "test-server-tests-in-console-once",
"--extra-packages", "extra-package-1, extra-package-2@=0.0.2",
"extra-package-1", "extra-package-2");
run.waitSecs(60);
run.match("extra-package-1 - example test");
run.match("extra-package-2 - example test");
run.expectExit(0);
});
});
selftest.define("command-like options", function () {
var s = new Sandbox;
var run;
run = s.run("--version");
if (release.current.isCheckout()) {
run.matchErr("Unreleased");
run.expectExit(1);
} else {
run.read(release.current.getDisplayName() + "\n");
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
}
run = s.run("--arch");
run.read(archinfo.host() + "\n");
run.waitSecs(5);
run.expectEnd();
run.expectExit(0);
});
selftest.define("rails reminders", function () {
var s = new Sandbox;
var run;
run = s.run("server");
run.matchErr("Did you mean 'meteor run'?");
run.expectExit(1);
run = s.run("console");
run.matchErr("Did you mean 'meteor shell'?");
run.expectExit(1);
run = s.run("new");
run.matchErr("Did you mean 'meteor create'?");
run.expectExit(1);
run = s.run("dbconsole");
run.matchErr("Did you mean 'meteor mongo'?");
run.expectExit(1);
// It should ignore args
run = s.run("server", "ignoredArg");
run.matchErr("Did you mean 'meteor run'?");
run.expectExit(1);
run = s.run("console", "ignoredArg");
run.matchErr("Did you mean 'meteor shell'?");
run.expectExit(1);
run = s.run("new", "ignoredArg");
run.matchErr("Did you mean 'meteor create'?");
run.expectExit(1);
run = s.run("dbconsole", "ignoredArg");
run.matchErr("Did you mean 'meteor mongo'?");
run.expectExit(1);
});
selftest.skip.define("old cli tests (converted)", function () {
var s = new Sandbox;
var run;
run = s.run("--help");
run.match("List the packages explicitly used");
run = s.run("run", "--help");
run.match("Port to listen");
run = s.run("test-packages", "--help");
run.match("Port to listen");
run = s.run("create", "--help");
run.match("Make a subdirectory");
run = s.run("update", "--help");
run.match("Updates the meteor release");
run = s.run("add", "--help");
run.match("Adds packages");
run = s.run("remove", "--help");
run.match("Removes a package");
run = s.run("list", "--help");
run.match("Transitive dependencies are not listed unless");
run = s.run("bundle", "--help");
run.match("command has been deprecated");
run = s.run("build", "--help");
run.match("Package this project");
run = s.run("mongo", "--help");
run.match("Opens a Mongo");
run = s.run("deploy", "--help");
run.match("Deploys the project");
run = s.run("logs", "--help");
run.match("Retrieves the");
run = s.run("reset", "--help");
run.match("Reset the current");
run = s.run("test-packages", "--help");
run.match("Runs unit tests");
run = s.run();
run.matchErr("run: You're not in");
run.expectExit(1);
run = s.run("run");
run.matchErr("run: You're not in");
run.expectExit(1);
run = s.run("add", "foo");
run.matchErr("add: You're not in");
run.expectExit(1);
run = s.run("remove", "foo");
run.matchErr("remove: You're not in");
run.expectExit(1);
run = s.run("list");
run.matchErr("list: You're not in");
run.expectExit(1);
run = s.run("bundle", "foo.tar.gz");
run.matchErr("bundle: You're not in");
run.expectExit(1);
run = s.run("build", "foo.tar.gz");
run.matchErr("build: You're not in");
run.expectExit(1);
run = s.run("mongo");
run.matchErr("mongo: You're not in");
run.expectExit(1);
run = s.run("deploy", "automated-test");
run.matchErr("deploy: You're not in");
run.expectExit(1);
run = s.run("reset");
run.matchErr("reset: You're not in");
run.expectExit(1);
var dir = "skel with spaces";
run = s.run("create", dir);
run.expectExit(0);
selftest.expectTrue(files.stat(files.pathJoin(s.home, dir)).isDirectory());
s.cd(dir);
// add/remove/list
run = s.run('search', 'backbone');
run.match('backbone');
run = s.run('list');
run.expectExit(0);
run.forbid('backbone');
run = s.run('add', 'backbone');
run.match('backbone:');
run.expectExit(0);
run.forbidErr('no such package');
run = s.run('list');
run.match('backbone');
selftest.expectTrue(files.readFile(files.pathJoin(s.cwd, '.meteor', 'packages'), 'utf8').match(/backbone/));
// bundle
run = s.run('bundle', 'foo.tar.gz');
run.matchErr(/This command has been deprecated/);
run = s.run('build', '.');
run.expectExit(0);
if (process.platform !== 'win32') {
tar_tvzf = utils.execFileSync('tar', ['tvzf', files.pathJoin(s.cwd, dir + '.tar.gz')]);
selftest.expectTrue(tar_tvzf.success);
}
files.unlink(files.pathJoin(s.cwd, dir + '.tar.gz'));
// test-packages
var dieNow = files.pathJoin(s.home, 'local-packages', 'die-now');
files.mkdir_p(dieNow);
files.writeFile(files.pathJoin(dieNow, 'package.js'), [
'Package.describe({',
' summary: "die-now",',
' version: "1.0.0"',
'});',
'Package.onTest(function (api) {',
' api.use("deps"); // try to use a core package',
' api.addFiles(["die-now.js"], "server");',
'});'
].join('\n'));
files.writeFile(files.pathJoin(dieNow, 'die-now.js'), [
'if (Meteor.isServer) {',
' console.log("Dying");',
' process.exit(0);',
'}'
].join('\n'));
var port = 9100;
run = s.run('test-packages', '--once', '-p', port, dieNow);
run.match('Dying');
// since the server process was killed via 'process.exit', mongo is still running.
// the second argument is a dummy since it is hard to know the dbpath of mongo
// running for a test-runner
runMongo.findMongoAndKillItDead(port + 1, s.cwd);
utils.sleepMs(2000);
// settings
files.writeFile(files.pathJoin(s.cwd, 'settings.json'), JSON.stringify({ foo: "bar", baz: "quux" }));
files.writeFile(files.pathJoin(s.cwd, 'settings.js'), [
'if (Meteor.isServer) {',
' Meteor.startup(function () {',
' if (!Meteor.settings) process.exit(1);',
' if (Meteor.settings.foo !== "bar") process.exit(1);',
' process.exit(0);',
' });',
'}'
].join('\n'));
run = s.run('-p', port, '--settings', 'settings.json', '--once');
run.expectExit(0);
files.unlink(files.pathJoin(s.cwd, 'settings.js'));
});
// Added to address https://github.com/meteor/meteor/issues/8897.
selftest.define(
'meteor test-packages --test-app-path directory',
function () {
var s = new Sandbox();
var run;
// If test-app-path doesn't exist, it should be created.
var testAppPath = '/tmp/meteor_test_app_path';
files.rm_recursive(testAppPath);
selftest.expectFalse(files.exists(testAppPath));
s.createApp('test-app-path-app', 'package-tests', {
dontPrepareApp: true
});
s.cd('test-app-path-app/packages/say-something', function () {
run = s.run(
'test-packages',
'--once',
{ 'test-app-path': testAppPath },
'./'
);
run.match('Started');
selftest.expectTrue(files.exists(testAppPath));
run.stop();
files.rm_recursive(testAppPath);
});
// If test-app-path already exists, make sure that directory is used.
var testAppPath = '/tmp/meteor_test_app_path';
files.rm_recursive(testAppPath);
files.mkdir_p(testAppPath);
selftest.expectTrue(files.exists(testAppPath));
selftest.expectFalse(files.exists(testAppPath + '/.meteor'));
s.createApp('test-app-path-app', 'package-tests', {
dontPrepareApp: true
});
s.cd('test-app-path-app/packages/say-something', function () {
run = s.run(
'test-packages',
'--once',
{ 'test-app-path': testAppPath },
'./'
);
run.match('Started');
selftest.expectTrue(files.exists(testAppPath + '/.meteor'));
run.stop();
files.rm_recursive(testAppPath);
});
// If test-app-path already exists but is a file instead of a directory,
// show a console error message explaining this, and exit.
var testAppPath = '/tmp/meteor_test_app_path';
files.rm_recursive(testAppPath);
files.writeFile(testAppPath, '<3 meteor');
selftest.expectTrue(files.exists(testAppPath));
s.createApp('test-app-path-app', 'package-tests', {
dontPrepareApp: true
});
s.cd('test-app-path-app/packages/say-something', function () {
run = s.run(
'test-packages',
'--once',
{ 'test-app-path': testAppPath },
'./'
);
run.matchErr('is not a directory');
run.expectExit(1);
files.rm_recursive(testAppPath);
});
}
);
Reference in New Issue View Git Blame Copy Permalink