meteor

mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00

Files

Felix Rabe 3431c66c16 Fix occurrences of "cd dirname $0"

They are not safe for spaces in paths. There might be other places to look for trouble.

I've run the following command to produce this commit: (on OS X, copy-and-pasting the below exactly)

    find . -type f -name '*.sh' -print0  |  # Find all .sh files
        xargs -0 fgrep -H -- '`'         |  # See all places with backticks in them
        fgrep 'cd `dirname $0'           |  # I deemed these problematic (variable assignments are safe)
        cut -d ':' -f 1                  |  # Take the <file> from <file>:<line> produced by "grep -H"
        tr '\n' '\0'                     |  # Also here, spaces can be problematic - always do "xargs -0"!
        xargs -0 -- sed -i '' 's/cd `dirname $0`/cd "`dirname "$0"`"/g'

The significance of adding the two levels of "'s can be verified by running the following in your Terminal:

    $ node -e 'console.log(process.argv.splice(1))' -- `echo 1   2`
    [ '1', '2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo 1   2`"
    [ '1 2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo "1   2"`"
    [ '1   2' ]

2014-05-07 17:51:09 -07:00

publish-release

'whoami' gracefully handles revocation of a credential

2014-02-18 17:25:19 -08:00

upgrade-to-engine

Fix occurrences of "cd dirname $0"

2014-05-07 17:51:09 -07:00

banner.txt

Update banner and notices

2014-05-01 12:17:24 -07:00

bless-release.js

Check package notices line length