mirror of
https://github.com/nodejs/node-v0.x-archive.git
synced 2026-04-28 03:01:10 -04:00
test: Fix tls tests which fail sporadically
The count of ECONNRESETs is dependent on timing, and thus unreliable, especially on Linux machines.
This commit is contained in:
@@ -34,7 +34,6 @@ var https = require('https');
|
|||||||
|
|
||||||
var proxyPort = common.PORT + 1;
|
var proxyPort = common.PORT + 1;
|
||||||
var gotRequest = false;
|
var gotRequest = false;
|
||||||
var errorCount = 0;
|
|
||||||
|
|
||||||
var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
|
var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
|
||||||
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
|
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
|
||||||
@@ -164,12 +163,15 @@ proxy.listen(proxyPort, function() {
|
|||||||
server.close();
|
server.close();
|
||||||
});
|
});
|
||||||
}).on('error', function() {
|
}).on('error', function() {
|
||||||
errorCount++;
|
// We're ok with getting ECONNRESET in this test, but it's
|
||||||
|
// timing-dependent, and thus unreliable. Any other errors
|
||||||
|
// are just failures, though.
|
||||||
|
if (er.code !== 'ECONNRESET')
|
||||||
|
throw er;
|
||||||
}).end();
|
}).end();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
process.on('exit', function() {
|
process.on('exit', function() {
|
||||||
assert.ok(gotRequest);
|
assert.ok(gotRequest);
|
||||||
assert.equal(errorCount, 1);
|
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -50,12 +50,15 @@ function doTest() {
|
|||||||
requestCert: true
|
requestCert: true
|
||||||
};
|
};
|
||||||
var requestCount = 0;
|
var requestCount = 0;
|
||||||
var errorCount = 0;
|
|
||||||
var session;
|
var session;
|
||||||
|
|
||||||
var server = tls.createServer(options, function(cleartext) {
|
var server = tls.createServer(options, function(cleartext) {
|
||||||
cleartext.on('error', function() {
|
cleartext.on('error', function(er) {
|
||||||
errorCount++;
|
// We're ok with getting ECONNRESET in this test, but it's
|
||||||
|
// timing-dependent, and thus unreliable. Any other errors
|
||||||
|
// are just failures, though.
|
||||||
|
if (er.code !== 'ECONNRESET')
|
||||||
|
throw er;
|
||||||
});
|
});
|
||||||
++requestCount;
|
++requestCount;
|
||||||
cleartext.end();
|
cleartext.end();
|
||||||
@@ -98,6 +101,5 @@ function doTest() {
|
|||||||
|
|
||||||
// initial request + reconnect requests (5 times)
|
// initial request + reconnect requests (5 times)
|
||||||
assert.equal(requestCount, 6);
|
assert.equal(requestCount, 6);
|
||||||
assert.equal(errorCount, 4);
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user