From f99e2eaebbaf91921eb45f5a0effa797d24c8f7c Mon Sep 17 00:00:00 2001 From: Muhammed Mukhthar CM Date: Wed, 14 Jan 2026 07:10:59 +0000 Subject: [PATCH] Lint: formatting and unused vars in test --- ...ed-runner.sanitize-session-history.test.ts | 89 ++++++++++--------- 1 file changed, 47 insertions(+), 42 deletions(-) diff --git a/src/agents/pi-embedded-runner.sanitize-session-history.test.ts b/src/agents/pi-embedded-runner.sanitize-session-history.test.ts index 16a0aa3f47..f8fe98eee8 100644 --- a/src/agents/pi-embedded-runner.sanitize-session-history.test.ts +++ b/src/agents/pi-embedded-runner.sanitize-session-history.test.ts @@ -1,104 +1,109 @@ -import { describe, it, expect, vi, beforeEach } from 'vitest'; -import { sanitizeSessionHistory } from './pi-embedded-runner/google.js'; -import * as helpers from './pi-embedded-helpers.js'; -import type { AgentMessage } from '@mariozechner/pi-agent-core'; -import type { SessionManager } from '@mariozechner/pi-coding-agent'; +import type { AgentMessage } from "@mariozechner/pi-agent-core"; +import type { SessionManager } from "@mariozechner/pi-coding-agent"; +import { beforeEach, describe, expect, it, vi } from "vitest"; +import * as helpers from "./pi-embedded-helpers.js"; +import { sanitizeSessionHistory } from "./pi-embedded-runner/google.js"; // Mock dependencies -vi.mock('./pi-embedded-helpers.js', async () => { - const actual = await vi.importActual('./pi-embedded-helpers.js'); +vi.mock("./pi-embedded-helpers.js", async () => { + const actual = await vi.importActual("./pi-embedded-helpers.js"); return { ...actual, isGoogleModelApi: vi.fn(), downgradeGeminiHistory: vi.fn(), - sanitizeSessionMessagesImages: vi.fn().mockImplementation(async (msgs) => msgs), + sanitizeSessionMessagesImages: vi + .fn() + .mockImplementation(async (msgs) => msgs), }; }); // We don't mock session-transcript-repair.js as it is a pure function and complicates mocking. // We rely on the real implementation which should pass through our simple messages. -describe('sanitizeSessionHistory', () => { +describe("sanitizeSessionHistory", () => { const mockSessionManager = { getEntries: vi.fn().mockReturnValue([]), appendCustomEntry: vi.fn(), } as unknown as SessionManager; - const mockMessages: AgentMessage[] = [ - { role: 'user', content: 'hello' } - ]; + const mockMessages: AgentMessage[] = [{ role: "user", content: "hello" }]; beforeEach(() => { vi.resetAllMocks(); - vi.mocked(helpers.sanitizeSessionMessagesImages).mockImplementation(async (msgs) => msgs); + vi.mocked(helpers.sanitizeSessionMessagesImages).mockImplementation( + async (msgs) => msgs, + ); // Default mock implementation vi.mocked(helpers.downgradeGeminiHistory).mockImplementation((msgs) => { - if (!msgs) return []; - return [...msgs, { role: 'system', content: 'downgraded' }]; + if (!msgs) return []; + return [...msgs, { role: "system", content: "downgraded" }]; }); }); - it('should downgrade history for Google models if provider is not google-antigravity', async () => { + it("should downgrade history for Google models if provider is not google-antigravity", async () => { vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); - + const result = await sanitizeSessionHistory({ messages: mockMessages, - modelApi: 'google-gemini', - provider: 'google-vertex', + modelApi: "google-gemini", + provider: "google-vertex", sessionManager: mockSessionManager, - sessionId: 'test-session', + sessionId: "test-session", }); - expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); + expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini"); expect(helpers.downgradeGeminiHistory).toHaveBeenCalled(); // Check if the result contains the downgraded message - expect(result).toContainEqual({ role: 'system', content: 'downgraded' }); + expect(result).toContainEqual({ role: "system", content: "downgraded" }); }); - it('should NOT downgrade history for google-antigravity provider', async () => { + it("should NOT downgrade history for google-antigravity provider", async () => { vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); - + const result = await sanitizeSessionHistory({ messages: mockMessages, - modelApi: 'google-gemini', - provider: 'google-antigravity', + modelApi: "google-gemini", + provider: "google-antigravity", sessionManager: mockSessionManager, - sessionId: 'test-session', + sessionId: "test-session", }); - expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); + expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini"); expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled(); // Result should not contain the downgraded message - expect(result).not.toContainEqual({ role: 'system', content: 'downgraded' }); + expect(result).not.toContainEqual({ + role: "system", + content: "downgraded", + }); }); - it('should NOT downgrade history for non-Google models', async () => { + it("should NOT downgrade history for non-Google models", async () => { vi.mocked(helpers.isGoogleModelApi).mockReturnValue(false); - + const _result = await sanitizeSessionHistory({ messages: mockMessages, - modelApi: 'anthropic-messages', - provider: 'anthropic', + modelApi: "anthropic-messages", + provider: "anthropic", sessionManager: mockSessionManager, - sessionId: 'test-session', + sessionId: "test-session", }); - expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('anthropic-messages'); + expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("anthropic-messages"); expect(helpers.downgradeGeminiHistory).not.toHaveBeenCalled(); }); - - it('should downgrade history if provider is undefined but model is Google', async () => { - vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); - + + it("should downgrade history if provider is undefined but model is Google", async () => { + vi.mocked(helpers.isGoogleModelApi).mockReturnValue(true); + const _result = await sanitizeSessionHistory({ messages: mockMessages, - modelApi: 'google-gemini', + modelApi: "google-gemini", provider: undefined, sessionManager: mockSessionManager, - sessionId: 'test-session', + sessionId: "test-session", }); - expect(helpers.isGoogleModelApi).toHaveBeenCalledWith('google-gemini'); + expect(helpers.isGoogleModelApi).toHaveBeenCalledWith("google-gemini"); expect(helpers.downgradeGeminiHistory).toHaveBeenCalled(); }); });