🐛 Bug Report: Trim operation is not performed on OIDC Callback URLs entry boxes #181

New Issue

AtHeartEngineer · 2025-07-08T08:41:43-04:00

AtHeartEngineer commented

2025-07-08 08:41:43 -04:00

Originally created by @Illuminati-Cow on 5/13/2025

Reproduction steps

Create a callback URL with a space at the end
Configure the client to use Pocket ID as an authenticator
Sign in to Pocket ID and attempt to authenticate with the client
Invalid Callback URL error

Expected behavior

The entry box should perform a trim operation at the very least, or a basic check for malformed URLs.

Actual Behavior

The URL with a space was accepted, and no warning was presented. Upon hitting the invalid callback, the appropriate error was presented.

Version and Environment

I performed additional testing, and the error only occurs if the malformed callback URL needs to be resolved. When putting spaces in unused callback URLs, no issue occurred. A trim operation on the URL entry boxes should cause no new issues and prevent user error.

Log Output

pocket-id | [GIN] 2025/05/13 - 07:09:25 | 400 | 967.791µs | 10.0.0.227 | POST "/api/oidc/authorize"
pocket-id | Error #01: invalid callback URL, it might be necessary for an admin to fix this

*Originally created by @Illuminati-Cow on 5/13/2025* ### Reproduction steps 1. Create a callback URL with a space at the end 2. Configure the client to use Pocket ID as an authenticator 3. Sign in to Pocket ID and attempt to authenticate with the client 4. Invalid Callback URL error ### Expected behavior The entry box should perform a trim operation at the very least, or a basic check for malformed URLs. ### Actual Behavior The URL with a space was accepted, and no warning was presented. Upon hitting the invalid callback, the appropriate error was presented. ### Version and Environment I performed additional testing, and the error only occurs if the malformed callback URL needs to be resolved. When putting spaces in unused callback URLs, no issue occurred. A trim operation on the URL entry boxes should cause no new issues and prevent user error. ### Log Output `pocket-id | [GIN] 2025/05/13 - 07:09:25 | 400 | 967.791µs | 10.0.0.227 | POST "/api/oidc/authorize"` `pocket-id | Error #01: invalid callback URL, it might be necessary for an admin to fix this`

AtHeartEngineer closed this issue

2025-07-08 08:41:44 -04:00

AtHeartEngineer added the bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug labels 2025-07-08 08:41:44 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pocket-id#181