fix: improve LDAP error handling #265

New Issue

AtHeartEngineer · 2025-07-08T08:43:59-04:00

AtHeartEngineer commented

2025-07-08 08:43:59 -04:00

Originally created by @ItalyPaleAle on 4/10/2025

This PR revises how errors are handled in the LDAP syncing service. I went through line-by-line to make sure that we treat errors consistently, and in most cases we should abort the sync and roll-back the changes in the DB (with some exceptions).

Should hopefully fix errors that were happening with syncing from LDAP, as some errors were simply logged while others causes failures.

*Originally created by @ItalyPaleAle on 4/10/2025* This PR revises how errors are handled in the LDAP syncing service. I went through line-by-line to make sure that we treat errors consistently, and in most cases we should abort the sync and roll-back the changes in the DB (with some exceptions). Should hopefully fix errors that were happening with syncing from LDAP, as some errors were simply logged while others causes failures.

AtHeartEngineer closed this issue

2025-07-08 08:43:59 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pocket-id#265