fix: ensure file descriptors are closed + other bugs #277

New Issue

AtHeartEngineer · 2025-07-08T08:44:19-04:00

AtHeartEngineer commented

2025-07-08 08:44:19 -04:00

Originally created by @ItalyPaleAle on 4/3/2025

Ensures file descriptors are closed: changes in #406 meant that when reading the default picture, file descriptors would be left open
fixes ownership issue of the defaultPicture stream (previous code was potentially unsafe as the returned slice was valid only until the next buffer modification)
Fixes generation of initials when there are non-ASCII characters.

Fixup from #406

*Originally created by @ItalyPaleAle on 4/3/2025* 1. Ensures file descriptors are closed: changes in #406 meant that when reading the default picture, file descriptors would be left open 2. fixes ownership issue of the `defaultPicture` stream (previous code was potentially unsafe as the returned slice was valid only until the next buffer modification) 3. Fixes generation of initials when there are non-ASCII characters. Fixup from #406

AtHeartEngineer closed this issue

2025-07-08 08:44:19 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pocket-id#277