🐛 Bug Report: Cannot disable users #56

New Issue

AtHeartEngineer · 2025-07-08T08:38:37-04:00

AtHeartEngineer commented

2025-07-08 08:38:37 -04:00

Originally created by @luketainton on 6/22/2025

Reproduction steps

Go to 'Users'
Find an active user
Click Menu -> Disable -> Confirm
User remains enabled

Expected behavior

The user should be disabled.

Actual Behavior

The user remains enabled.

Version and Environment

Version 1.4.1, running in Docker on a Debian host. Running Postgres 17.5-alpine3.21.

Log Output

The issue seems to be in this line - the DB is being updated with disabled=False when it should be disabled=True.

[0.641ms] [rows:1] UPDATE "users" SET "created_at"='2025-04-28 14:16:15.55',"username"='(removed)',"email"='(removed)',"first_name"='(removed)',"last_name"='(removed)',"is_admin"=false,"locale"=NULL,"ldap_id"=NULL,"disabled"=false WHERE "id" = '844d9675-2a5d-401a-bfd2-5c24b7740461'

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[0.275ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce'

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[2.138ms] [rows:20] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce'

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[0.642ms] [rows:20] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','f820e71c-199d-4325-a9eb-abc3090e6619','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','50637828-c2d5-4154-a163-523d4a7d7927','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','e616722c-273f-4343-b0ad-f80c57485bfc','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347')

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[4.664ms] [rows:1] SELECT * FROM "users" WHERE id = '3a95bbeb-14b7-45bf-993f-ec571f968dce' ORDER BY "users"."id" LIMIT 1

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:289
[0.485ms] [rows:1] SELECT * FROM "users" WHERE id = '844d9675-2a5d-401a-bfd2-5c24b7740461' ORDER BY "users"."id" LIMIT 1

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:316
[0.641ms] [rows:1] UPDATE "users" SET "created_at"='2025-04-28 14:16:15.55',"username"='(removed)',"email"='(removed)',"first_name"='(removed)',"last_name"='(removed)',"is_admin"=false,"locale"=NULL,"ldap_id"=NULL,"disabled"=false WHERE "id" = '844d9675-2a5d-401a-bfd2-5c24b7740461'
[GIN] 2025/06/22 - 20:20:42 | 200 |    9.182943ms |   146.112.97.74 | PUT      "/api/users/844d9675-2a5d-401a-bfd2-5c24b7740461"
[GIN] 2025/06/22 - 20:20:42 | 200 |    9.225118ms |   146.112.97.74 | PUT      "/api/users/844d9675-2a5d-401a-bfd2-5c24b7740461"

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[0.863ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce'

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[4.836ms] [rows:20] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce'

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[1.226ms] [rows:20] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','f820e71c-199d-4325-a9eb-abc3090e6619','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','50637828-c2d5-4154-a163-523d4a7d7927','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','e616722c-273f-4343-b0ad-f80c57485bfc','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347')

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68
[8.740ms] [rows:1] SELECT * FROM "users" WHERE id = '3a95bbeb-14b7-45bf-993f-ec571f968dce' ORDER BY "users"."id" LIMIT 1

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:68
[0.408ms] [rows:1] SELECT count(*) FROM "users"

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72
[0.545ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" IN ('a5710d7a-6510-4639-b9ac-16c9c6ba96ae','844d9675-2a5d-401a-bfd2-5c24b7740461','207ff1a6-ee07-4725-9faa-7664d0d96a89','33b4c381-5bc4-44d5-a161-046e8991f114','cf35df0e-443c-4e2a-975d-518646912258','db0777b8-1945-4d63-977c-30ec6cb572ad','0b8a15bf-1e86-42d3-8903-b89fea659bbf','3a95bbeb-14b7-45bf-993f-ec571f968dce','7d0adb69-b91d-449a-b416-9556a5c3f41b','01fccae3-eacf-4859-847e-cf207be9a743','30207e35-875d-48ba-b522-00964fa3944b','bbcaa6e9-277f-4d59-9aa7-019d3206ae0d','f371dd28-14e2-4bc3-b6bb-ed39c7047835','a5f3eed7-bc18-411f-a5b1-0fc1b670a7df')

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72
[0.908ms] [rows:80] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" IN ('a5710d7a-6510-4639-b9ac-16c9c6ba96ae','844d9675-2a5d-401a-bfd2-5c24b7740461','207ff1a6-ee07-4725-9faa-7664d0d96a89','33b4c381-5bc4-44d5-a161-046e8991f114','cf35df0e-443c-4e2a-975d-518646912258','db0777b8-1945-4d63-977c-30ec6cb572ad','0b8a15bf-1e86-42d3-8903-b89fea659bbf','3a95bbeb-14b7-45bf-993f-ec571f968dce','7d0adb69-b91d-449a-b416-9556a5c3f41b','01fccae3-eacf-4859-847e-cf207be9a743','30207e35-875d-48ba-b522-00964fa3944b','bbcaa6e9-277f-4d59-9aa7-019d3206ae0d','f371dd28-14e2-4bc3-b6bb-ed39c7047835','a5f3eed7-bc18-411f-a5b1-0fc1b670a7df')

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72
[0.934ms] [rows:23] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('e616722c-273f-4343-b0ad-f80c57485bfc','9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','2dfcdf88-ad3a-4dc4-9dd4-624d1a38b13f','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','1245fcd1-c260-4c19-aa9b-b940a1f61f13','f820e71c-199d-4325-a9eb-abc3090e6619','c99b6338-3ba8-4653-b5ed-dad1413a28fe','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','50637828-c2d5-4154-a163-523d4a7d7927','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347')

2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72
[4.150ms] [rows:14] SELECT * FROM "users" ORDER BY "first_name" LIMIT 20
[GIN] 2025/06/22 - 20:20:42 | 200 |   17.042377ms |   146.112.97.74 | GET      "/api/users?sort[column]=firstName&sort[direction]=asc"
[GIN] 2025/06/22 - 20:20:42 | 200 |   17.090336ms |   146.112.97.74 | GET      "/api/users?sort[column]=firstName&sort[direction]=asc"
[GIN] 2025/06/22 - 20:20:44 | 204 |       2.297µs |             ::1 | GET      "/healthz"
[GIN] 2025/06/22 - 20:20:44 | 204 |        80.4µs |             ::1 | GET      "/healthz"

*Originally created by @luketainton on 6/22/2025* ### Reproduction steps 1. Go to 'Users' 2. Find an active user 3. Click Menu -> Disable -> Confirm 4. User remains enabled ### Expected behavior The user should be disabled. ### Actual Behavior The user remains enabled. ### Version and Environment Version 1.4.1, running in Docker on a Debian host. Running Postgres `17.5-alpine3.21`. ### Log Output The issue seems to be in this line - the DB is being updated with `disabled=False` when it should be `disabled=True`. `[0.641ms] [rows:1] UPDATE "users" SET "created_at"='2025-04-28 14:16:15.55',"username"='(removed)',"email"='(removed)',"first_name"='(removed)',"last_name"='(removed)',"is_admin"=false,"locale"=NULL,"ldap_id"=NULL,"disabled"=false WHERE "id" = '844d9675-2a5d-401a-bfd2-5c24b7740461'` ``` 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [0.275ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce' 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [2.138ms] [rows:20] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce' 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [0.642ms] [rows:20] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','f820e71c-199d-4325-a9eb-abc3090e6619','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','50637828-c2d5-4154-a163-523d4a7d7927','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','e616722c-273f-4343-b0ad-f80c57485bfc','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347') 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [4.664ms] [rows:1] SELECT * FROM "users" WHERE id = '3a95bbeb-14b7-45bf-993f-ec571f968dce' ORDER BY "users"."id" LIMIT 1 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:289 [0.485ms] [rows:1] SELECT * FROM "users" WHERE id = '844d9675-2a5d-401a-bfd2-5c24b7740461' ORDER BY "users"."id" LIMIT 1 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:316 [0.641ms] [rows:1] UPDATE "users" SET "created_at"='2025-04-28 14:16:15.55',"username"='(removed)',"email"='(removed)',"first_name"='(removed)',"last_name"='(removed)',"is_admin"=false,"locale"=NULL,"ldap_id"=NULL,"disabled"=false WHERE "id" = '844d9675-2a5d-401a-bfd2-5c24b7740461' [GIN] 2025/06/22 - 20:20:42 | 200 | 9.182943ms | 146.112.97.74 | PUT "/api/users/844d9675-2a5d-401a-bfd2-5c24b7740461" [GIN] 2025/06/22 - 20:20:42 | 200 | 9.225118ms | 146.112.97.74 | PUT "/api/users/844d9675-2a5d-401a-bfd2-5c24b7740461" 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [0.863ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce' 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [4.836ms] [rows:20] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" = '3a95bbeb-14b7-45bf-993f-ec571f968dce' 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [1.226ms] [rows:20] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','f820e71c-199d-4325-a9eb-abc3090e6619','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','50637828-c2d5-4154-a163-523d4a7d7927','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','e616722c-273f-4343-b0ad-f80c57485bfc','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347') 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/service/user_service.go:68 [8.740ms] [rows:1] SELECT * FROM "users" WHERE id = '3a95bbeb-14b7-45bf-993f-ec571f968dce' ORDER BY "users"."id" LIMIT 1 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:68 [0.408ms] [rows:1] SELECT count(*) FROM "users" 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72 [0.545ms] [rows:0] SELECT * FROM "custom_claims" WHERE "custom_claims"."user_id" IN ('a5710d7a-6510-4639-b9ac-16c9c6ba96ae','844d9675-2a5d-401a-bfd2-5c24b7740461','207ff1a6-ee07-4725-9faa-7664d0d96a89','33b4c381-5bc4-44d5-a161-046e8991f114','cf35df0e-443c-4e2a-975d-518646912258','db0777b8-1945-4d63-977c-30ec6cb572ad','0b8a15bf-1e86-42d3-8903-b89fea659bbf','3a95bbeb-14b7-45bf-993f-ec571f968dce','7d0adb69-b91d-449a-b416-9556a5c3f41b','01fccae3-eacf-4859-847e-cf207be9a743','30207e35-875d-48ba-b522-00964fa3944b','bbcaa6e9-277f-4d59-9aa7-019d3206ae0d','f371dd28-14e2-4bc3-b6bb-ed39c7047835','a5f3eed7-bc18-411f-a5b1-0fc1b670a7df') 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72 [0.908ms] [rows:80] SELECT * FROM "user_groups_users" WHERE "user_groups_users"."user_id" IN ('a5710d7a-6510-4639-b9ac-16c9c6ba96ae','844d9675-2a5d-401a-bfd2-5c24b7740461','207ff1a6-ee07-4725-9faa-7664d0d96a89','33b4c381-5bc4-44d5-a161-046e8991f114','cf35df0e-443c-4e2a-975d-518646912258','db0777b8-1945-4d63-977c-30ec6cb572ad','0b8a15bf-1e86-42d3-8903-b89fea659bbf','3a95bbeb-14b7-45bf-993f-ec571f968dce','7d0adb69-b91d-449a-b416-9556a5c3f41b','01fccae3-eacf-4859-847e-cf207be9a743','30207e35-875d-48ba-b522-00964fa3944b','bbcaa6e9-277f-4d59-9aa7-019d3206ae0d','f371dd28-14e2-4bc3-b6bb-ed39c7047835','a5f3eed7-bc18-411f-a5b1-0fc1b670a7df') 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72 [0.934ms] [rows:23] SELECT * FROM "user_groups" WHERE "user_groups"."id" IN ('e616722c-273f-4343-b0ad-f80c57485bfc','9b366464-54d8-406c-9dc3-012b566d5dd4','7da68cbf-836a-4117-b124-be22780f75b8','051700bb-1dcb-4279-8710-d20f8b0841b3','2dfcdf88-ad3a-4dc4-9dd4-624d1a38b13f','ff939568-fa7b-4d6b-94fc-27aa524114cb','b22f1871-6780-4893-b70c-838f87b43ca8','f916ce4b-c9ad-45bf-9a97-a81a7e80fc80','1245fcd1-c260-4c19-aa9b-b940a1f61f13','f820e71c-199d-4325-a9eb-abc3090e6619','c99b6338-3ba8-4653-b5ed-dad1413a28fe','b1e7f3e2-d484-4d89-8c97-df76c4987b9a','99d2f54c-973e-4c9d-b9ac-ee233216bb7d','54725d90-9dd9-471b-9acb-a85d77edd539','d4adb8f2-087a-4331-97b6-c51201cd272a','b1a64540-4797-49ff-8a5f-873b48950065','ce224bfb-3b31-4f0a-8f8b-b09e669ec55c','50637828-c2d5-4154-a163-523d4a7d7927','ad9a0a6c-6588-40ad-b129-2dbf369f9007','c47588e9-6092-4eec-b7ef-07fab723378d','b1872e8b-6ccb-4f0a-b2a4-2b163e8d9c34','2b99ab7d-b225-4484-8ca7-7b4a26ce08f5','996c5885-6f21-4a03-b78b-daab9effb347') 2025/06/22 20:20:42 github.com/pocket-id/pocket-id/backend/internal/utils/paging_util.go:72 [4.150ms] [rows:14] SELECT * FROM "users" ORDER BY "first_name" LIMIT 20 [GIN] 2025/06/22 - 20:20:42 | 200 | 17.042377ms | 146.112.97.74 | GET "/api/users?sort[column]=firstName&sort[direction]=asc" [GIN] 2025/06/22 - 20:20:42 | 200 | 17.090336ms | 146.112.97.74 | GET "/api/users?sort[column]=firstName&sort[direction]=asc" [GIN] 2025/06/22 - 20:20:44 | 204 | 2.297µs | ::1 | GET "/healthz" [GIN] 2025/06/22 - 20:20:44 | 204 | 80.4µs | ::1 | GET "/healthz" ```

AtHeartEngineer closed this issue

2025-07-08 08:38:37 -04:00

AtHeartEngineer added the bug bug bug bug bug bug bug bug bug bug bug bug bug bug labels 2025-07-08 08:38:38 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pocket-id#56