Clean up various warnings (#10710)

* Clean up various warnings

* Update beacon-chain/rpc/prysm/v1alpha1/debug/state_test.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* Fix redundant casting genState

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
This commit is contained in:
terencechain
2022-05-18 21:38:04 -07:00
committed by GitHub
parent 1c51f6d1be
commit 092e9e1d19
32 changed files with 112 additions and 117 deletions

View File

@@ -44,7 +44,7 @@ func TestAggregateVerify(t *testing.T) {
func TestAggregateVerify_CompressedSignatures(t *testing.T) {
pubkeys := make([]common.PublicKey, 0, 100)
sigs := make([]common.Signature, 0, 100)
sigBytes := [][]byte{}
var sigBytes [][]byte
var msgs [][32]byte
for i := 0; i < 100; i++ {
msg := [32]byte{'h', 'e', 'l', 'l', 'o', byte(i)}

View File

@@ -49,7 +49,7 @@ func TestCopySignatureSet(t *testing.T) {
}
func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
keys := []SecretKey{}
var keys []SecretKey
for i := 0; i < 100; i++ {
key, err := RandKey()
assert.NoError(t, err)
@@ -73,9 +73,9 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
chosenKeys := keys[:20]
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -105,9 +105,9 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -149,9 +149,9 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -190,9 +190,9 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -242,9 +242,9 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -328,7 +328,7 @@ func TestSignatureBatch_RemoveDuplicates(t *testing.T) {
}
func TestSignatureBatch_AggregateBatch(t *testing.T) {
keys := []SecretKey{}
var keys []SecretKey
for i := 0; i < 100; i++ {
key, err := RandKey()
assert.NoError(t, err)
@@ -353,9 +353,9 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
chosenKeys := keys[:20]
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -383,9 +383,9 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
chosenKeys := keys[:20]
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -409,9 +409,9 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -459,9 +459,9 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
msg := [32]byte{'r', 'a', 'n', 'd', 'o', 'm'}
msg1 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '1'}
msg2 := [32]byte{'r', 'a', 'n', 'd', 'o', 'm', '2'}
signatures := [][]byte{}
messages := [][32]byte{}
pubs := []PublicKey{}
var signatures [][]byte
var messages [][32]byte
var pubs []PublicKey
for _, k := range chosenKeys[:10] {
s := k.Sign(msg[:])
signatures = append(signatures, s.Marshal())
@@ -485,7 +485,7 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
messages[15][31] ^= byte(100)
messages[25][31] ^= byte(100)
newSigs := [][]byte{}
var newSigs [][]byte
newSigs = append(newSigs, signatures[:5]...)
newSigs = append(newSigs, signatures[6:10]...)
@@ -504,7 +504,7 @@ func TestSignatureBatch_AggregateBatch(t *testing.T) {
aggSig3, err := AggregateCompressedSignatures(newSigs)
assert.NoError(t, err)
newPubs := []PublicKey{}
var newPubs []PublicKey
newPubs = append(newPubs, pubs[:5]...)
newPubs = append(newPubs, pubs[6:10]...)