diff --git a/beacon-chain/rpc/eth/validator/BUILD.bazel b/beacon-chain/rpc/eth/validator/BUILD.bazel index 5ab2597a0c..b4964a0570 100644 --- a/beacon-chain/rpc/eth/validator/BUILD.bazel +++ b/beacon-chain/rpc/eth/validator/BUILD.bazel @@ -5,6 +5,7 @@ go_library( srcs = [ "handlers.go", "handlers_block.go", + "log.go", "server.go", ], importpath = "github.com/prysmaticlabs/prysm/v5/beacon-chain/rpc/eth/validator", diff --git a/beacon-chain/rpc/eth/validator/handlers.go b/beacon-chain/rpc/eth/validator/handlers.go index 171790b1bc..639c1aa791 100644 --- a/beacon-chain/rpc/eth/validator/handlers.go +++ b/beacon-chain/rpc/eth/validator/handlers.go @@ -31,7 +31,7 @@ import ( "github.com/prysmaticlabs/prysm/v5/network/httputil" ethpbalpha "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" "github.com/prysmaticlabs/prysm/v5/time/slots" - log "github.com/sirupsen/logrus" + "github.com/sirupsen/logrus" "go.opencensus.io/trace" "google.golang.org/grpc/codes" "google.golang.org/grpc/status" @@ -592,7 +592,7 @@ func (s *Server) PrepareBeaconProposer(w http.ResponseWriter, r *http.Request) { if len(validatorIndices) == 0 { return } - log.WithFields(log.Fields{ + log.WithFields(logrus.Fields{ "validatorIndices": validatorIndices, }).Info("Updated fee recipient addresses") } diff --git a/beacon-chain/rpc/eth/validator/handlers_block.go b/beacon-chain/rpc/eth/validator/handlers_block.go index e265b0c610..bf444aafa5 100644 --- a/beacon-chain/rpc/eth/validator/handlers_block.go +++ b/beacon-chain/rpc/eth/validator/handlers_block.go @@ -220,8 +220,9 @@ func (s *Server) produceBlockV3(ctx context.Context, w http.ResponseWriter, r *h consensusBlockValue, httpError := getConsensusBlockValue(ctx, s.BlockRewardFetcher, v1alpha1resp.Block) if httpError != nil { - httputil.WriteError(w, httpError) - return + log.WithError(httpError).Debug("Failed to get consensus block value") + // Having the consensus block value is not critical to block production + consensusBlockValue = "" } w.Header().Set(api.ExecutionPayloadBlindedHeader, fmt.Sprintf("%v", v1alpha1resp.IsBlinded)) @@ -297,7 +298,7 @@ func getConsensusBlockValue(ctx context.Context, blockRewardsFetcher rewards.Blo } } if bb.Version() == version.Phase0 { - // ignore for phase 0 + // Getting the block value for Phase 0 is very hard, so we ignore it return "", nil } // Get consensus payload value which is the same as the total from the block rewards api. diff --git a/beacon-chain/rpc/eth/validator/log.go b/beacon-chain/rpc/eth/validator/log.go new file mode 100644 index 0000000000..de331ebcf6 --- /dev/null +++ b/beacon-chain/rpc/eth/validator/log.go @@ -0,0 +1,5 @@ +package validator + +import "github.com/sirupsen/logrus" + +var log = logrus.WithField("prefix", "beacon-api")