Fix multiple anti-patterns from DeepSource analysis (#6951)

* Merge variable declaration and assignment
* Use result of type assertion to simplify cases
* Replace call to bytes.Compare with bytes.Equal
* Drop unnecessary use of the blank identifier
* Replace x.Sub(time.Now()) with time.Until(x)
* Function literal can be simplified
* Use a single append to concatenate two slices
* Replace time.Now().Sub(x) with time.Since(x)
* Omit comparison with boolean constant
* Omit redundant nil check on slices
* Nested if can be replaced with else-if
* Function call can be replaced with helper function
* Omit redundant control flow
* Use plain channel send or receive
* Simplify returning boolean expression
* Merge branch 'origin-master' into fix-antipatterns
* Merge branch 'master' into fix-antipatterns

tools/forkchecker/forkchecker.go

@@ -54,14 +54,11 @@ func main() {
 
 	ticker := time.NewTicker(time.Duration(params.BeaconConfig().SecondsPerSlot) * time.Second)
 	go func() {
-		for {
-			select {
-			case <-ticker.C:
-				if *compare {
-					compareHeads(clients)
-				} else {
-					displayHeads(clients)
-				}
+		for range ticker.C {
+			if *compare {
+				compareHeads(clients)
+			} else {
+				displayHeads(clients)
 			}
 		}
 	}()