From 1f720bdbf4dde98115fe7ae09718afb0a0e05c93 Mon Sep 17 00:00:00 2001 From: Preston Van Loon Date: Fri, 3 Jan 2025 03:40:13 -0600 Subject: [PATCH] Fix all typos (#14769) --- CHANGELOG.md | 36 +++++++++---------- beacon-chain/cache/attestation.go | 2 +- beacon-chain/p2p/broadcaster.go | 2 +- beacon-chain/p2p/subnets.go | 2 +- .../rpc/eth/beacon/handlers_pool_test.go | 4 +-- beacon-chain/rpc/eth/events/events.go | 2 +- beacon-chain/slasher/doc.go | 2 +- cmd/validator/slashing-protection/import.go | 6 ++-- .../v1alpha1/attestation/attestation_utils.go | 4 +-- testing/bls/hash_to_G2_test.go | 2 +- testing/endtoend/evaluators/metrics.go | 2 +- testing/util/block.go | 2 +- validator/client/validator_test.go | 4 +-- validator/db/testing/setup_db.go | 4 +-- 14 files changed, 37 insertions(+), 37 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 91e5e1f465..05dbeb4075 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -151,7 +151,7 @@ Notable features: - Removed finalized validator index cache, no longer needed. - Removed validator queue position log on key reload and wait for activation. - Removed outdated spectest exclusions for EIP-6110. -- Removed support for starting a beacon node with a deterministic interop genesis state via interop flags. Alteratively, create a genesis state with prysmctl and use `--genesis-state`. This removes about 9Mb (~11%) of unnecessary code and dependencies from the final production binary. +- Removed support for starting a beacon node with a deterministic interop genesis state via interop flags. Alternatively, create a genesis state with prysmctl and use `--genesis-state`. This removes about 9Mb (~11%) of unnecessary code and dependencies from the final production binary. - Removed kzg proof check from blob reconstructor. ### Fixed @@ -165,7 +165,7 @@ Notable features: - Fix `--backfill-oldest-slot` handling - this flag was totally broken, the code would always backfill to the default slot [pr](https://github.com/prysmaticlabs/prysm/pull/14584) - Fix keymanager API should return corrected error format for malformed tokens - Fix keymanager API so that get keys returns an empty response instead of a 500 error when using an unsupported keystore. -- Small log imporvement, removing some redundant or duplicate logs +- Small log improvement, removing some redundant or duplicate logs - EIP7521 - Fixes withdrawal bug by accounting for pending partial withdrawals and deducting already withdrawn amounts from the sweep balance. [PR](https://github.com/prysmaticlabs/prysm/pull/14578) - unskip electra merkle spec test - Fix panic in validator REST mode when checking status after removing all keys @@ -195,7 +195,7 @@ meantime we are issuing a patch that recovers from the panic to prevent the node This only impacts the v5.1.1 release beacon api event stream endpoints. This endpoint is used by the prysm REST mode validator (a feature which requires the validator to be configured to use the beacon -api intead of prysm's stock grpc endpoints) or accessory software that connects to the events api, +api instead of prysm's stock grpc endpoints) or accessory software that connects to the events api, like https://github.com/ethpandaops/ethereum-metrics-exporter ### Fixed @@ -438,7 +438,7 @@ Updating to this release is recommended at your earliest convenience, especially - use time.NewTimer() to avoid possible memory leaks - paranoid underflow protection without error handling - Fix CommitteeAssignments to not return every validator -- Fix dependent root retrival genesis case +- Fix dependent root retrieval genesis case - Restrict Dials From Discovery - Always close cache warm chan to prevent blocking - Keep only the latest value in the health channel @@ -590,7 +590,7 @@ block profit. If you want to preserve the existing behavior, set --local-block-v - handle special case of batch size=1 - Always Set Inprogress Boolean In Cache - Builder APIs: adding headers to post endpoint -- Rename mispelled variable +- Rename misspelled variable - allow blob by root within da period - Rewrite Pruning Implementation To Handle EIP 7045 - Set default fee recipient if tracked val fails @@ -660,7 +660,7 @@ Known Issues - Support beacon_committee_selections - /eth/v1/beacon/deposit_snapshot - Docker images now have coreutils pre-installed -- da_waited_time_milliseconds tracks total time waiting for data availablity check in ReceiveBlock +- da_waited_time_milliseconds tracks total time waiting for data availability check in ReceiveBlock - blob_written, blob_disk_count, blob_disk_bytes new metrics for tracking blobs on disk - Backfill supports blob backfilling - Add mainnet deneb fork epoch config @@ -835,7 +835,7 @@ and Raspberry Pi users. - Add Goerli Deneb Fork Epoch - Use deneb key for deneb state in saveStatesEfficientInternal - Initialize Inactivity Scores Correctly -- Excluse DA wait time for chain processing time +- Excludes DA wait time for chain processing time - Initialize sig cache for verification.Initializer - Verify roblobs - KZG Commitment inclusion proof verifier @@ -868,7 +868,7 @@ and Raspberry Pi users. - Exit early if blob by root request is empty - Request missing blobs while processing pending queue - Check blob exists before requesting from peer -- Passing block as arugment for sidecar validation +- Passing block as argument for sidecar validation #### Blob Management @@ -1165,13 +1165,13 @@ _Most of the PRs here involve shifting our http endpoints to using vanilla http - Remove no-op cancel func - Update Terms of Service - fix head slot in log -- DEPRECTATION: Remove exchange transition configuration call +- DEPRECATION: Remove exchange transition configuration call - fix segmentation fork when Capella for epoch is MaxUint64 - Return Error Gracefully When Removing 4881 Flag - Add zero length check on indices during NextSyncCommitteeIndices - Replace Empty Slice Literals with Nil Slices - Refactor Error String Formatting According to Go Best Practices -- Fix redundant type converstion +- Fix redundant type conversion - docs: fix typo - Add Clarification To Sync Committee Cache - Fix typos @@ -1193,7 +1193,7 @@ small set of users. ### Security -No security issues in thsi release. +No security issues in this release. ## [v4.1.0](https://github.com/prysmaticlabs/prysm/compare/v4.0.8...v4.1.0) - 2023-08-22 @@ -1709,7 +1709,7 @@ notes [here](https://hackmd.io/TtyFurRJRKuklG3n8lMO9Q). This release is **strong Note: The released docker images are using the portable version of the blst cryptography library. The Prysm team will release docker images with the non-portable blst library as the default image. In the meantime, you can compile docker images with blst non-portable locally with the `--define=blst_modern=true` bazel flag, use the "-modern-" assets -attached to releases, or set environment varaible USE_PRYSM_MODERN=true when using prysm.sh. +attached to releases, or set environment variable USE_PRYSM_MODERN=true when using prysm.sh. ### Added @@ -2058,7 +2058,7 @@ There are some known issues with this release. - Beacon node can bootstrap from non-genesis state (i.e bellatrix state) - Refactor bytesutil, add support for go1.20 slice to array conversions - Add Span information for attestation record save request -- Matric addition +- Metric addition - Identify invalid signature within batch verification - Support for getting consensus values from beacon config - EIP-4881: Spec implementation @@ -2124,7 +2124,7 @@ See [flashbots/mev-boost#404](https://github.com/flashbots/mev-boost/issues/404) - Added more histogram metrics for block arrival latency times block_arrival_latency_milliseconds - Priority queue RetrieveByKey now uses read lock instead of write lock - Use custom types for certain ethclient requests. Fixes an issue when using prysm on gnosis chain. -- Updted forkchoice endpoint /eth/v1/debug/forkchoice (was /eth/v1/debug/beacon/forkchoice) +- Updated forkchoice endpoint /eth/v1/debug/forkchoice (was /eth/v1/debug/beacon/forkchoice) - Include empty fields in builder json client. - Computing committee assignments for slots older than the oldest historical root in the beacon state is now forbidden @@ -2356,7 +2356,7 @@ There are no security updates in this release. removed: `GetBeaconState`, `ProduceBlock`, `ListForkChoiceHeads`, `ListBlocks`, `SubmitValidatorRegistration`, `GetBlock`, `ProposeBlock` - API: Forkchoice method `GetForkChoice` has been removed. - All previously deprecated feature flags have been - removed. `--enable-active-balance-cache`, `--correctly-prune-canonical-atts`, `--correctly-insert-orphaned-atts`, `--enable-next-slot-state-cache`, `--enable-batch-gossip-verification`, `--enable-get-block-optimizations`, `--enable-balance-trie-computation`, `--disable-next-slot-state-cache`, `--attestation-aggregation-strategy`, `--attestation-aggregation-force-opt-maxcover`, `--pyrmont`, `--disable-get-block-optimizations`, `--disable-proposer-atts-selection-using-max-cover`, `--disable-optimized-balance-update`, `--disable-active-balance-cache`, `--disable-balance-trie-computation`, `--disable-batch-gossip-verification`, `--disable-correctly-prune-canonical-atts`, `--disable-correctly-insert-orphaned-atts`, `--enable-native-state`, `--enable-peer-scorer`, `--enable-gossip-batch-aggregation`, `--experimental-disable-boundry-checks` + removed. `--enable-active-balance-cache`, `--correctly-prune-canonical-atts`, `--correctly-insert-orphaned-atts`, `--enable-next-slot-state-cache`, `--enable-batch-gossip-verification`, `--enable-get-block-optimizations`, `--enable-balance-trie-computation`, `--disable-next-slot-state-cache`, `--attestation-aggregation-strategy`, `--attestation-aggregation-force-opt-maxcover`, `--pyrmont`, `--disable-get-block-optimizations`, `--disable-proposer-atts-selection-using-max-cover`, `--disable-optimized-balance-update`, `--disable-active-balance-cache`, `--disable-balance-trie-computation`, `--disable-batch-gossip-verification`, `--disable-correctly-prune-canonical-atts`, `--disable-correctly-insert-orphaned-atts`, `--enable-native-state`, `--enable-peer-scorer`, `--enable-gossip-batch-aggregation`, `--experimental-disable-boundary-checks` - Validator Web API: Removed unused ImportAccounts and DeleteAccounts rpc options ### Fixed @@ -2753,7 +2753,7 @@ notes [here](https://github.com/prysmaticlabs/prysm-web-ui/releases/tag/v1.0.0) - Added uint64 overflow protection - Sync committee pool returns empty slice instead of nil on cache miss - Improved description of datadir flag -- Simplied web password requirements +- Simplified web password requirements - Web JWT tokens no longer expire. - Updated keymanager protos - Watch and update jwt secret when auth token file updated on disk. @@ -2764,7 +2764,7 @@ notes [here](https://github.com/prysmaticlabs/prysm-web-ui/releases/tag/v1.0.0) - Refactor for weak subjectivity sync implementation - Update naming for Atlair previous epoch attester - Remove duplicate MerkleizeTrieLeaves method. -- Add explict error for validator flag checks on out of bound positions +- Add explicit error for validator flag checks on out of bound positions - Simplify method to check if the beacon chain client should update the justified epoch value. - Rename web UI performance endpoint to "summary" - Refactor powchain service to be more functional @@ -2790,7 +2790,7 @@ notes [here](https://github.com/prysmaticlabs/prysm-web-ui/releases/tag/v1.0.0) Upstream go-ethereum is now used with familiar go.mod tooling. - Removed duplicate aggergation validation p2p pipelines. - Metrics calculation removed extra condition -- Removed superflous errors from peer scoring parameters registration +- Removed superfluous errors from peer scoring parameters registration ### Fixed diff --git a/beacon-chain/cache/attestation.go b/beacon-chain/cache/attestation.go index 2108ac9d84..817ddef568 100644 --- a/beacon-chain/cache/attestation.go +++ b/beacon-chain/cache/attestation.go @@ -53,7 +53,7 @@ func NewAttestationCache() *AttestationCache { // // - For unaggregated attestations, it adds the attestation bit to attestation bits of the running aggregate, // which is the first aggregate for the slot. -// - For aggregated attestations, it appends the attestation to the existng list of attestations for the slot. +// - For aggregated attestations, it appends the attestation to the existing list of attestations for the slot. func (c *AttestationCache) Add(att ethpb.Att) error { if att.IsNil() { log.Debug("Attempted to add a nil attestation to the attestation cache") diff --git a/beacon-chain/p2p/broadcaster.go b/beacon-chain/p2p/broadcaster.go index 4c3e6ed54f..2cb8459fbf 100644 --- a/beacon-chain/p2p/broadcaster.go +++ b/beacon-chain/p2p/broadcaster.go @@ -163,7 +163,7 @@ func (s *Service) broadcastSyncCommittee(ctx context.Context, subnet uint64, sMs // Ensure we have peers with this subnet. // This adds in a special value to the subnet - // to ensure that we can re-use the same subnet locker. + // to ensure that we can reuse the same subnet locker. wrappedSubIdx := subnet + syncLockerVal s.subnetLocker(wrappedSubIdx).RLock() hasPeer := s.hasPeerWithSubnet(syncCommitteeToTopic(subnet, forkDigest)) diff --git a/beacon-chain/p2p/subnets.go b/beacon-chain/p2p/subnets.go index 74eb898bfd..e0328276a3 100644 --- a/beacon-chain/p2p/subnets.go +++ b/beacon-chain/p2p/subnets.go @@ -473,7 +473,7 @@ func syncBitvector(record *enr.Record) (bitfield.Bitvector4, error) { } // The subnet locker is a map which keeps track of all -// mutexes stored per subnet. This locker is re-used +// mutexes stored per subnet. This locker is reused // between both the attestation, sync and blob subnets. // Sync subnets are stored by (subnet+syncLockerVal). // Blob subnets are stored by (subnet+blobSubnetLockerVal). diff --git a/beacon-chain/rpc/eth/beacon/handlers_pool_test.go b/beacon-chain/rpc/eth/beacon/handlers_pool_test.go index 5ff2e5d228..be3f31a388 100644 --- a/beacon-chain/rpc/eth/beacon/handlers_pool_test.go +++ b/beacon-chain/rpc/eth/beacon/handlers_pool_test.go @@ -1991,7 +1991,7 @@ func TestSubmitAttesterSlashings(t *testing.T) { _, ok := broadcaster.BroadcastMessages[0].(*ethpbv1alpha1.AttesterSlashing) assert.Equal(t, true, ok) }) - t.Run("accross-fork", func(t *testing.T) { + t.Run("across-fork", func(t *testing.T) { attestationData1.Slot = params.BeaconConfig().SlotsPerEpoch attestationData2.Slot = params.BeaconConfig().SlotsPerEpoch slashing := ðpbv1alpha1.AttesterSlashing{ @@ -2147,7 +2147,7 @@ func TestSubmitAttesterSlashings(t *testing.T) { _, ok := broadcaster.BroadcastMessages[0].(*ethpbv1alpha1.AttesterSlashingElectra) assert.Equal(t, true, ok) }) - t.Run("accross-fork", func(t *testing.T) { + t.Run("across-fork", func(t *testing.T) { attestationData1.Slot = params.BeaconConfig().SlotsPerEpoch attestationData2.Slot = params.BeaconConfig().SlotsPerEpoch slashing := ðpbv1alpha1.AttesterSlashingElectra{ diff --git a/beacon-chain/rpc/eth/events/events.go b/beacon-chain/rpc/eth/events/events.go index 6caf6a9d6b..d8aaec6b5b 100644 --- a/beacon-chain/rpc/eth/events/events.go +++ b/beacon-chain/rpc/eth/events/events.go @@ -380,7 +380,7 @@ func (es *eventStreamer) writeOutbox(ctx context.Context, w *streamingResponseWr case <-ctx.Done(): return ctx.Err() case rf := <-es.outbox: - // We don't want to call Flush until we've exhausted all the writes - it's always preferrable to + // We don't want to call Flush until we've exhausted all the writes - it's always preferable to // just keep draining the outbox and rely on the underlying Write code to flush+block when it // needs to based on buffering. Whenever we fill the buffer with a string of writes, the underlying // code will flush on its own, so it's better to explicitly flush only once, after we've totally diff --git a/beacon-chain/slasher/doc.go b/beacon-chain/slasher/doc.go index 46efb460b2..44c09e2a0b 100644 --- a/beacon-chain/slasher/doc.go +++ b/beacon-chain/slasher/doc.go @@ -129,7 +129,7 @@ A chunk value is stored on 2 bytes (uint16). ==> A chunk takes 8192 bytes = 8KB There is 4096 epochs / 16 epochs per chunk = 256 chunks per batch of 256 validators. -Storing all values fo a batch of 256 validators takes 256 * 8KB = 2MB +Storing all values of a batch of 256 validators takes 256 * 8KB = 2MB With 1_048_576 validators, we need 4096 * 2MB = 8GB Storing both MIN and MAX spans for 1_048_576 validators takes 16GB. diff --git a/cmd/validator/slashing-protection/import.go b/cmd/validator/slashing-protection/import.go index 3aa91085c7..5f62bd9916 100644 --- a/cmd/validator/slashing-protection/import.go +++ b/cmd/validator/slashing-protection/import.go @@ -33,7 +33,7 @@ func importSlashingProtectionJSON(cliCtx *cli.Context) error { ) // Check if a minimal database is requested - isDatabaseMimimal := cliCtx.Bool(features.EnableMinimalSlashingProtection.Name) + isDatabaseMinimal := cliCtx.Bool(features.EnableMinimalSlashingProtection.Name) // Get the data directory from the CLI context. dataDir := cliCtx.String(cmd.DataDirFlag.Name) @@ -45,7 +45,7 @@ func importSlashingProtectionJSON(cliCtx *cli.Context) error { } // Ensure that the database is found under the specified directory or its subdirectories - if isDatabaseMimimal { + if isDatabaseMinimal { found, _, err = file.RecursiveDirFind(filesystem.DatabaseDirName, dataDir) } else { found, _, err = file.RecursiveFileFind(kv.ProtectionDbFileName, dataDir) @@ -63,7 +63,7 @@ func importSlashingProtectionJSON(cliCtx *cli.Context) error { log.Infof(message, dataDir) // Open the validator database. - if isDatabaseMimimal { + if isDatabaseMinimal { valDB, err = filesystem.NewStore(dataDir, nil) } else { valDB, err = kv.NewKVStore(cliCtx.Context, dataDir, nil) diff --git a/proto/prysm/v1alpha1/attestation/attestation_utils.go b/proto/prysm/v1alpha1/attestation/attestation_utils.go index 7c160a8cf4..863bd380df 100644 --- a/proto/prysm/v1alpha1/attestation/attestation_utils.go +++ b/proto/prysm/v1alpha1/attestation/attestation_utils.go @@ -65,7 +65,7 @@ func ConvertToIndexed(_ context.Context, attestation ethpb.Att, committees ...[] // AttestingIndices returns the attesting participants indices from the attestation data. // Committees are provided as an argument rather than an imported implementation from the spec definition. -// Having committees as an argument allows for re-use of beacon committees when possible. +// Having committees as an argument allows for reuse of beacon committees when possible. // // Spec pseudocode definition (Electra version): // @@ -254,7 +254,7 @@ func CheckPointIsEqual(checkPt1, checkPt2 *ethpb.Checkpoint) bool { // attestingIndicesPhase0 returns the attesting participants indices from the attestation data. // Committees are provided as an argument rather than an imported implementation from the spec definition. -// Having committees as an argument allows for re-use of beacon committees when possible. +// Having committees as an argument allows for reuse of beacon committees when possible. // // Spec pseudocode definition (Phase0 version): // diff --git a/testing/bls/hash_to_G2_test.go b/testing/bls/hash_to_G2_test.go index 48db52b6b6..ff3c4c8c16 100644 --- a/testing/bls/hash_to_G2_test.go +++ b/testing/bls/hash_to_G2_test.go @@ -17,7 +17,7 @@ func TestHashToG2(t *testing.T) { } func testHashToG2(t *testing.T) { - t.Skip("Hash To G2 needs co-ordinates exposed") + t.Skip("Hash To G2 needs coordinates exposed") fNames, fContent := utils.RetrieveFiles("hash_to_G2", t) for i, file := range fNames { diff --git a/testing/endtoend/evaluators/metrics.go b/testing/endtoend/evaluators/metrics.go index ea100eb41d..bf76b767f9 100644 --- a/testing/endtoend/evaluators/metrics.go +++ b/testing/endtoend/evaluators/metrics.go @@ -207,7 +207,7 @@ func valueOfTopic(pageContent, topic string) (int, error) { } var result float64 for i, stringIndex := range indexesFound { - // Only performing every third result found since theres 2 comments above every metric. + // Only performing every third result found since there are 2 comments above every metric. if i == 0 || i%2 != 0 { continue } diff --git a/testing/util/block.go b/testing/util/block.go index 098049c335..317fea2a2a 100644 --- a/testing/util/block.go +++ b/testing/util/block.go @@ -1141,7 +1141,7 @@ func HydrateBeaconBlockBodyElectra(b *ethpb.BeaconBlockBodyElectra) *ethpb.Beaco return b } -// HydrateExecutionRequests fills the exectution requests with the correct field +// HydrateExecutionRequests fills the execution requests with the correct field // lengths func HydrateExecutionRequests(e *enginev1.ExecutionRequests) *enginev1.ExecutionRequests { if e == nil { diff --git a/validator/client/validator_test.go b/validator/client/validator_test.go index 950f4d376c..9217347d9a 100644 --- a/validator/client/validator_test.go +++ b/validator/client/validator_test.go @@ -2874,7 +2874,7 @@ func TestUpdateValidatorStatusCache(t *testing.T) { beaconNodeHosts: []string{"http://localhost:8080", "http://localhost:8081"}, currentHostIndex: 0, pubkeyToStatus: map[[fieldparams.BLSPubkeyLength]byte]*validatorStatus{ - [fieldparams.BLSPubkeyLength]byte{0x03}: &validatorStatus{ // add non existant key and status to cache, should be fully removed on update + [fieldparams.BLSPubkeyLength]byte{0x03}: &validatorStatus{ // add non existent key and status to cache, should be fully removed on update publicKey: []byte{0x03}, status: ðpb.ValidatorStatusResponse{ Status: ethpb.ValidatorStatus_ACTIVE, @@ -2887,7 +2887,7 @@ func TestUpdateValidatorStatusCache(t *testing.T) { err := v.updateValidatorStatusCache(ctx, pubkeys) assert.NoError(t, err) - // make sure the nonexistant key is fully removed + // make sure the nonexistent key is fully removed _, ok := v.pubkeyToStatus[[fieldparams.BLSPubkeyLength]byte{0x03}] require.Equal(t, false, ok) // make sure we only have the added values diff --git a/validator/db/testing/setup_db.go b/validator/db/testing/setup_db.go index 288fbb4d6f..72aeb12226 100644 --- a/validator/db/testing/setup_db.go +++ b/validator/db/testing/setup_db.go @@ -13,14 +13,14 @@ import ( // SetupDB instantiates and returns a DB instance for the validator client. // The `minimal` flag indicates whether the DB should be instantiated with minimal, filesystem // slashing protection database. -func SetupDB(t testing.TB, pubkeys [][fieldparams.BLSPubkeyLength]byte, mimimal bool) iface.ValidatorDB { +func SetupDB(t testing.TB, pubkeys [][fieldparams.BLSPubkeyLength]byte, minimal bool) iface.ValidatorDB { var ( db iface.ValidatorDB err error ) // Create a new DB instance. - if mimimal { + if minimal { config := &filesystem.Config{PubKeys: pubkeys} db, err = filesystem.NewStore(t.TempDir(), config) } else {