From 1f8939472764c5691ca81e99a5b8b6775f82d97e Mon Sep 17 00:00:00 2001 From: terence Date: Thu, 2 Oct 2025 19:59:26 -0700 Subject: [PATCH] Return early if there's no block for data column sidecar (#15802) --- beacon-chain/sync/rpc_beacon_blocks_by_root.go | 4 ++++ changelog/ttsao_return-early-req-column.md | 3 +++ 2 files changed, 7 insertions(+) create mode 100644 changelog/ttsao_return-early-req-column.md diff --git a/beacon-chain/sync/rpc_beacon_blocks_by_root.go b/beacon-chain/sync/rpc_beacon_blocks_by_root.go index fd57aa59e8..af0fec09a8 100644 --- a/beacon-chain/sync/rpc_beacon_blocks_by_root.go +++ b/beacon-chain/sync/rpc_beacon_blocks_by_root.go @@ -93,6 +93,10 @@ func (s *Service) sendBeaconBlocksRequest(ctx context.Context, requests *types.B // requestAndSaveMissingDataColumns checks if the data columns are missing for the given block. // If so, requests them and saves them to the storage. func (s *Service) requestAndSaveMissingDataColumnSidecars(blks []blocks.ROBlock) error { + if len(blks) == 0 { + return nil + } + samplesPerSlot := params.BeaconConfig().SamplesPerSlot custodyGroupCount, err := s.cfg.p2p.CustodyGroupCount() diff --git a/changelog/ttsao_return-early-req-column.md b/changelog/ttsao_return-early-req-column.md new file mode 100644 index 0000000000..c24226dc8c --- /dev/null +++ b/changelog/ttsao_return-early-req-column.md @@ -0,0 +1,3 @@ +### Ignored + +- Return early if there's no block for `requestAndSaveMissingDataColumnSidecars` \ No newline at end of file