From 238d5c07dffe65925c4273ab6c2b5b9f9cf92d9e Mon Sep 17 00:00:00 2001 From: kasey <489222+kasey@users.noreply.github.com> Date: Mon, 15 Sep 2025 15:11:53 -0500 Subject: [PATCH] remove "experimental" from backfill flag name (#15690) * remove "experimental" from backfill flag name * backwards-compatible alias * changelog --------- Co-authored-by: Kasey Kirkham --- beacon-chain/sync/backfill/service.go | 2 +- changelog/kasey_rename-backfill-flag.md | 2 ++ cmd/beacon-chain/sync/backfill/flags/flags.go | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 changelog/kasey_rename-backfill-flag.md diff --git a/beacon-chain/sync/backfill/service.go b/beacon-chain/sync/backfill/service.go index 31844bc98e..2bf7d4f1f3 100644 --- a/beacon-chain/sync/backfill/service.go +++ b/beacon-chain/sync/backfill/service.go @@ -22,7 +22,7 @@ import ( type Service struct { ctx context.Context - enabled bool // service is disabled by default while feature is experimental + enabled bool // service is disabled by default clock *startup.Clock store *Store ms minimumSlotter diff --git a/changelog/kasey_rename-backfill-flag.md b/changelog/kasey_rename-backfill-flag.md new file mode 100644 index 0000000000..38624db056 --- /dev/null +++ b/changelog/kasey_rename-backfill-flag.md @@ -0,0 +1,2 @@ +### Changed +- Renamed the `--enable-experimental-backfill` flag to `--enable-backfill` to signal that it is more mature. diff --git a/cmd/beacon-chain/sync/backfill/flags/flags.go b/cmd/beacon-chain/sync/backfill/flags/flags.go index fb89dc2054..af318292af 100644 --- a/cmd/beacon-chain/sync/backfill/flags/flags.go +++ b/cmd/beacon-chain/sync/backfill/flags/flags.go @@ -11,9 +11,9 @@ var ( // EnableExperimentalBackfill enables backfill for checkpoint synced nodes. // This flag will be removed once backfill is enabled by default. EnableExperimentalBackfill = &cli.BoolFlag{ - Name: "enable-experimental-backfill", - Usage: "Backfill is still experimental at this time. " + - "It will only be enabled if this flag is specified and the node was started using checkpoint sync.", + Name: "enable-backfill", + Aliases: []string{"enable-experimental-backfill"}, + Usage: "Backfill will only be enabled when this flag is specified on a node using checkpoint sync.", } // BackfillBatchSize allows users to tune block backfill request sizes to maximize network utilization // at the cost of higher memory.