From 26ce94e224eb0b5cb4a6aefed5526aa36ae7ca0a Mon Sep 17 00:00:00 2001 From: james-prysm <90280386+james-prysm@users.noreply.github.com> Date: Fri, 24 Oct 2025 09:28:30 -0500 Subject: [PATCH] removes misleading keymanager info log (#15926) * simple change * fixing test" " --- changelog/james-prysm_remove-deposit-keymanager-log.md | 3 +++ validator/accounts/accounts_list_test.go | 10 +++++----- validator/keymanager/local/keymanager.go | 4 ---- 3 files changed, 8 insertions(+), 9 deletions(-) create mode 100644 changelog/james-prysm_remove-deposit-keymanager-log.md diff --git a/changelog/james-prysm_remove-deposit-keymanager-log.md b/changelog/james-prysm_remove-deposit-keymanager-log.md new file mode 100644 index 0000000000..ff2662c82e --- /dev/null +++ b/changelog/james-prysm_remove-deposit-keymanager-log.md @@ -0,0 +1,3 @@ +### Removed + +- log mentioning removed flag `--show-deposit-data` \ No newline at end of file diff --git a/validator/accounts/accounts_list_test.go b/validator/accounts/accounts_list_test.go index 1dd089a9f3..a1798a2134 100644 --- a/validator/accounts/accounts_list_test.go +++ b/validator/accounts/accounts_list_test.go @@ -221,10 +221,10 @@ func TestListAccounts_LocalKeymanager(t *testing.T) { // Expected output format definition const prologLength = 4 const accountLength = 4 - const epilogLength = 2 - const nameOffset = 1 - const keyOffset = 2 - const privkeyOffset = 3 + const epilogLength = 1 + + const keyOffset = 1 + const privkeyOffset = 2 // Require the output has correct number of lines lineCount := prologLength + accountLength*numAccounts + epilogLength @@ -242,7 +242,7 @@ func TestListAccounts_LocalKeymanager(t *testing.T) { // Assert that account names are printed on the correct lines for i, accountName := range accountNames { - lineNumber := prologLength + accountLength*i + nameOffset + lineNumber := prologLength + accountLength*i accountNameFound := strings.Contains(lines[lineNumber], accountName) assert.Equal(t, true, accountNameFound, "Account Name %s not found on line number %d", accountName, lineNumber) } diff --git a/validator/keymanager/local/keymanager.go b/validator/keymanager/local/keymanager.go index 27cb8adcbf..8c6ea90cbf 100644 --- a/validator/keymanager/local/keymanager.go +++ b/validator/keymanager/local/keymanager.go @@ -402,10 +402,6 @@ func (km *Keymanager) ListKeymanagerAccounts(ctx context.Context, cfg keymanager } else { fmt.Printf("Showing %d validator accounts\n", numAccounts) } - fmt.Println( - au.BrightRed("View the eth1 deposit transaction data for your accounts " + - "by running `validator accounts list --show-deposit-data`"), - ) pubKeys, err := km.FetchValidatingPublicKeys(ctx) if err != nil {