github/prysm
1
1
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-09 15:37:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add golang.org/x/tools modernize static analyzer and fix violations (#15946)

Browse Source 
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
This commit is contained in:
Preston Van Loon
2025-11-13 19:27:22 -06:00
committed by GitHub
parent f77b78943a
commit 2fd6bd8150
605 changed files with 217475 additions and 2228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/http-request-sink/main.go
View File

@@ -42,7 +42,7 @@ func main() {
}()
http.HandleFunc("/", func(writer http.ResponseWriter, r *http.Request) {
reqContent := map[string]interface{}{}
reqContent := map[string]any{}
if err = parseRequest(r, &reqContent); err != nil {
log.Println(err)
}
@@ -59,7 +59,7 @@ func main() {
log.Fatal(srv.ListenAndServe())
}
func captureRequest(f *os.File, m map[string]interface{}) error {
func captureRequest(f *os.File, m map[string]any) error {
enc, err := json.Marshal(m)
if err != nil {
return err
@@ -68,7 +68,7 @@ func captureRequest(f *os.File, m map[string]interface{}) error {
return err
}
func parseRequest(req *http.Request, unmarshalStruct interface{}) error {
func parseRequest(req *http.Request, unmarshalStruct any) error {
body, err := io.ReadAll(req.Body)
if err != nil {
return err

4
tools/http-request-sink/main_test.go
View File

@@ -31,7 +31,7 @@ func Test_parseAndCaptureRequest(t *testing.T) {
httpReq, err := http.NewRequest("GET", "/", bytes.NewBuffer(enc))
require.NoError(t, err)
reqContent := map[string]interface{}{}
reqContent := map[string]any{}
err = parseRequest(httpReq, &reqContent)
require.NoError(t, err)
@@ -52,7 +52,7 @@ func Test_parseAndCaptureRequest(t *testing.T) {
fileContents, err := io.ReadAll(f)
require.NoError(t, err)
receivedContent := map[string]interface{}{}
receivedContent := map[string]any{}
err = json.Unmarshal(fileContents, &receivedContent)
require.NoError(t, err)