Register Subscribers After Node Is Synced (#7468)

* wait for synced

* fix again

* add test

* fix all

* fixes deepsource reported issue

Co-authored-by: Victor Farazdagi <simple.square@gmail.com>

beacon-chain/sync/initial-sync/round_robin_test.go

@@ -2,7 +2,6 @@ package initialsync
 
 import (
 	"context"
-	"fmt"
 	"testing"
 
 	eth "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
@@ -333,6 +332,7 @@ func TestService_processBlock(t *testing.T) {
 				Epoch: 0,
 			},
 		},
+		StateNotifier: &mock.MockStateNotifier{},
 	})
 	ctx := context.Background()
 	genesis := makeGenesisTime(32)
@@ -392,6 +392,7 @@ func TestService_processBlockBatch(t *testing.T) {
 				Epoch: 0,
 			},
 		},
+		StateNotifier: &mock.MockStateNotifier{},
 	})
 	ctx := context.Background()
 	genesis := makeGenesisTime(32)
@@ -439,8 +440,7 @@ func TestService_processBlockBatch(t *testing.T) {
 			ctx context.Context, blocks []*eth.SignedBeaconBlock, blockRoots [][32]byte) error {
 			return nil
 		})
-		expectedErr := fmt.Sprintf("no good blocks in batch")
-		assert.ErrorContains(t, expectedErr, err)
+		assert.ErrorContains(t, "no good blocks in batch", err)
 
 		var badBatch2 []*eth.SignedBeaconBlock
 		for i, b := range batch2 {