github/prysm
1
1
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-09 23:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove Gossip History Flag (#11232)

Browse Source 
* Remove gossip history flag

* gaz

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
This commit is contained in:
Nishant Das
2022-08-17 12:49:51 +08:00
committed by GitHub
parent e9ee6e2c9d
commit 49ef0ad284
4 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
beacon-chain/p2p/BUILD.bazel
View File

@@ -53,7 +53,6 @@ go_library(
"//beacon-chain/p2p/peers/scorers:go_default_library", "//beacon-chain/p2p/peers/scorers:go_default_library",
"//beacon-chain/p2p/types:go_default_library", "//beacon-chain/p2p/types:go_default_library",
"//cmd/beacon-chain/flags:go_default_library", "//cmd/beacon-chain/flags:go_default_library",
"//config/features:go_default_library",
"//config/params:go_default_library", "//config/params:go_default_library",
"//consensus-types/primitives:go_default_library", "//consensus-types/primitives:go_default_library",
"//consensus-types/wrapper:go_default_library", "//consensus-types/wrapper:go_default_library",

10
beacon-chain/p2p/pubsub.go
View File

@@ -10,7 +10,6 @@ import (
pubsub "github.com/libp2p/go-libp2p-pubsub" pubsub "github.com/libp2p/go-libp2p-pubsub"
"github.com/pkg/errors" "github.com/pkg/errors"
"github.com/prysmaticlabs/prysm/v3/cmd/beacon-chain/flags" "github.com/prysmaticlabs/prysm/v3/cmd/beacon-chain/flags"
"github.com/prysmaticlabs/prysm/v3/config/features"
"github.com/prysmaticlabs/prysm/v3/encoding/bytesutil" "github.com/prysmaticlabs/prysm/v3/encoding/bytesutil"
pbrpc "github.com/prysmaticlabs/prysm/v3/proto/prysm/v1alpha1" pbrpc "github.com/prysmaticlabs/prysm/v3/proto/prysm/v1alpha1"
) )
@@ -137,15 +136,6 @@ func pubsubGossipParam() pubsub.GossipSubParams {
gParams.HeartbeatInterval = gossipSubHeartbeatInterval gParams.HeartbeatInterval = gossipSubHeartbeatInterval
gParams.HistoryLength = gossipSubMcacheLen gParams.HistoryLength = gossipSubMcacheLen
gParams.HistoryGossip = gossipSubMcacheGossip gParams.HistoryGossip = gossipSubMcacheGossip
// Set a larger gossip history to ensure that slower
// messages have a longer time to be propagated. This
// comes with the tradeoff of larger memory usage and
// size of the seen message cache.
if features.Get().EnableLargerGossipHistory {
gParams.HistoryLength = 12
gParams.HistoryGossip = 5
}
return gParams return gParams
} }

5
config/features/config.go
View File

@@ -44,7 +44,6 @@ type Flags struct {
RemoteSlasherProtection bool // RemoteSlasherProtection utilizes a beacon node with --slasher mode for validator slashing protection. RemoteSlasherProtection bool // RemoteSlasherProtection utilizes a beacon node with --slasher mode for validator slashing protection.
WriteSSZStateTransitions bool // WriteSSZStateTransitions to tmp directory. WriteSSZStateTransitions bool // WriteSSZStateTransitions to tmp directory.
EnablePeerScorer bool // EnablePeerScorer enables experimental peer scoring in p2p. EnablePeerScorer bool // EnablePeerScorer enables experimental peer scoring in p2p.
EnableLargerGossipHistory bool // EnableLargerGossipHistory increases the gossip history we store in our caches.
WriteWalletPasswordOnWebOnboarding bool // WriteWalletPasswordOnWebOnboarding writes the password to disk after Prysm web signup. WriteWalletPasswordOnWebOnboarding bool // WriteWalletPasswordOnWebOnboarding writes the password to disk after Prysm web signup.
DisableAttestingHistoryDBCache bool // DisableAttestingHistoryDBCache for the validator client increases disk reads/writes. DisableAttestingHistoryDBCache bool // DisableAttestingHistoryDBCache for the validator client increases disk reads/writes.
EnableDoppelGanger bool // EnableDoppelGanger enables doppelganger protection on startup for the validator. EnableDoppelGanger bool // EnableDoppelGanger enables doppelganger protection on startup for the validator.
@@ -188,10 +187,6 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
logDisabled(disablePeerScorer) logDisabled(disablePeerScorer)
cfg.EnablePeerScorer = false cfg.EnablePeerScorer = false
} }
if ctx.Bool(enableLargerGossipHistory.Name) {
logEnabled(enableLargerGossipHistory)
cfg.EnableLargerGossipHistory = true
}
if ctx.Bool(disableBroadcastSlashingFlag.Name) { if ctx.Bool(disableBroadcastSlashingFlag.Name) {
logDisabled(disableBroadcastSlashingFlag) logDisabled(disableBroadcastSlashingFlag)
cfg.DisableBroadcastSlashings = true cfg.DisableBroadcastSlashings = true

5
config/features/flags.go
View File

@@ -50,10 +50,6 @@ var (
Name: "disable-peer-scorer", Name: "disable-peer-scorer",
Usage: "Disables experimental P2P peer scorer", Usage: "Disables experimental P2P peer scorer",
} }
enableLargerGossipHistory = &cli.BoolFlag{
Name: "enable-larger-gossip-history",
Usage: "Enables the node to store a larger amount of gossip messages in its cache.",
}
writeWalletPasswordOnWebOnboarding = &cli.BoolFlag{ writeWalletPasswordOnWebOnboarding = &cli.BoolFlag{
Name: "write-wallet-password-on-web-onboarding", Name: "write-wallet-password-on-web-onboarding",
Usage: "(Danger): Writes the wallet password to the wallet directory on completing Prysm web onboarding. " + Usage: "(Danger): Writes the wallet password to the wallet directory on completing Prysm web onboarding. " +
@@ -157,7 +153,6 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
SepoliaTestnet, SepoliaTestnet,
Mainnet, Mainnet,
disablePeerScorer, disablePeerScorer,
enableLargerGossipHistory,
disableBroadcastSlashingFlag, disableBroadcastSlashingFlag,
enableSlasherFlag, enableSlasherFlag,
enableHistoricalSpaceRepresentation, enableHistoricalSpaceRepresentation,