Config registry (#10683)

* test coverage and updates to config twiddlers

* LoadChainConfigFile error if SetActive conflicts

* lint

* wip working around test issues

* more fixes, mass test updates

* lint

* linting

* thanks deepsource!

* fix undeclared vars

* fixing more undefined

* fix a bug, make a bug, repeat

* gaz

* use stock mainnet in case fork schedule matters

* remove unused KnownConfigs

* post-merge cleanup

* eliminating OverrideBeaconConfig outside tests

* more cleanup of OverrideBeaconConfig outside tests

* config for interop w/ genesis gen support

* improve var name

* API on package instead of exported value

* cleanup remainders of "registry" naming

* Nishant feedback

* add ropstein to configset

* lint

* lint #2

* ✂️

* revert accidental commented line

* check if active is nil (replace called on empty)

* Nishant feedback

* replace OverrideBeaconConfig call

* update interop instructions w/ new flag

* don't let interop replace config set via cli flags

Co-authored-by: kasey <kasey@users.noreply.github.com>
This commit is contained in:
kasey
2022-05-20 02:16:53 -05:00
committed by GitHub
parent 1012ec1915
commit 588dea83b7
109 changed files with 1121 additions and 487 deletions

View File

@@ -39,7 +39,9 @@ var Commands = &cli.Command{
if err := tos.VerifyTosAcceptedOrPrompt(cliCtx); err != nil {
return err
}
features.ConfigureValidator(cliCtx)
if err := features.ConfigureValidator(cliCtx); err != nil {
return err
}
return nil
},
Action: func(cliCtx *cli.Context) error {
@@ -76,7 +78,9 @@ var Commands = &cli.Command{
if err := tos.VerifyTosAcceptedOrPrompt(cliCtx); err != nil {
return err
}
features.ConfigureValidator(cliCtx)
if err := features.ConfigureValidator(cliCtx); err != nil {
return err
}
return nil
},
Action: func(cliCtx *cli.Context) error {
@@ -110,7 +114,9 @@ var Commands = &cli.Command{
return tos.VerifyTosAcceptedOrPrompt(cliCtx)
},
Action: func(cliCtx *cli.Context) error {
features.ConfigureValidator(cliCtx)
if err := features.ConfigureValidator(cliCtx); err != nil {
return err
}
if err := accounts.BackupAccountsCli(cliCtx); err != nil {
log.Fatalf("Could not backup accounts: %v", err)
}
@@ -138,7 +144,9 @@ var Commands = &cli.Command{
return tos.VerifyTosAcceptedOrPrompt(cliCtx)
},
Action: func(cliCtx *cli.Context) error {
features.ConfigureValidator(cliCtx)
if err := features.ConfigureValidator(cliCtx); err != nil {
return err
}
if err := accounts.ImportAccountsCli(cliCtx); err != nil {
log.Fatalf("Could not import accounts: %v", err)
}
@@ -172,7 +180,9 @@ var Commands = &cli.Command{
return tos.VerifyTosAcceptedOrPrompt(cliCtx)
},
Action: func(cliCtx *cli.Context) error {
features.ConfigureValidator(cliCtx)
if err := features.ConfigureValidator(cliCtx); err != nil {
return err
}
if err := accounts.ExitAccountsCli(cliCtx, os.Stdin); err != nil {
log.Fatalf("Could not perform voluntary exit: %v", err)
}