github/prysm
1
1
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-09 15:37:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove Deprecated HTTP Provider Flag (#12140)

Browse Source 
* remove deprecated http provider flag

* test

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
This commit is contained in:
Nishant Das
2023-03-16 20:15:02 +08:00
committed by GitHub
parent ab407809f0
commit 5ea6e32d6c
5 changed files with 14 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
cmd/helpers_test.go
View File

@@ -84,30 +84,30 @@ func TestEnterPassword(t *testing.T) {
func TestExpandSingleEndpointIfFile(t *testing.T) {
app := cli.App{}
set := flag.NewFlagSet("test", 0)
HTTPWeb3ProviderFlag := &cli.StringFlag{Name: "http-web3provider", Value: ""}
set.String(HTTPWeb3ProviderFlag.Name, "", "")
ExecutionEndpointFlag := &cli.StringFlag{Name: "execution-endpoint", Value: ""}
set.String(ExecutionEndpointFlag.Name, "", "")
context := cli.NewContext(&app, set, nil)
// with nothing set
require.NoError(t, ExpandSingleEndpointIfFile(context, HTTPWeb3ProviderFlag))
require.Equal(t, "", context.String(HTTPWeb3ProviderFlag.Name))
require.NoError(t, ExpandSingleEndpointIfFile(context, ExecutionEndpointFlag))
require.Equal(t, "", context.String(ExecutionEndpointFlag.Name))
// with url scheme
require.NoError(t, context.Set(HTTPWeb3ProviderFlag.Name, "http://localhost:8545"))
require.NoError(t, ExpandSingleEndpointIfFile(context, HTTPWeb3ProviderFlag))
require.Equal(t, "http://localhost:8545", context.String(HTTPWeb3ProviderFlag.Name))
require.NoError(t, context.Set(ExecutionEndpointFlag.Name, "http://localhost:8545"))
require.NoError(t, ExpandSingleEndpointIfFile(context, ExecutionEndpointFlag))
require.Equal(t, "http://localhost:8545", context.String(ExecutionEndpointFlag.Name))
// relative user home path
usr, err := user.Current()
require.NoError(t, err)
require.NoError(t, context.Set(HTTPWeb3ProviderFlag.Name, "~/relative/path.ipc"))
require.NoError(t, ExpandSingleEndpointIfFile(context, HTTPWeb3ProviderFlag))
require.Equal(t, usr.HomeDir+"/relative/path.ipc", context.String(HTTPWeb3ProviderFlag.Name))
require.NoError(t, context.Set(ExecutionEndpointFlag.Name, "~/relative/path.ipc"))
require.NoError(t, ExpandSingleEndpointIfFile(context, ExecutionEndpointFlag))
require.Equal(t, usr.HomeDir+"/relative/path.ipc", context.String(ExecutionEndpointFlag.Name))
// current dir path
curentdir, err := os.Getwd()
require.NoError(t, err)
require.NoError(t, context.Set(HTTPWeb3ProviderFlag.Name, "./path.ipc"))
require.NoError(t, ExpandSingleEndpointIfFile(context, HTTPWeb3ProviderFlag))
require.Equal(t, curentdir+"/path.ipc", context.String(HTTPWeb3ProviderFlag.Name))
require.NoError(t, context.Set(ExecutionEndpointFlag.Name, "./path.ipc"))
require.NoError(t, ExpandSingleEndpointIfFile(context, ExecutionEndpointFlag))
require.Equal(t, curentdir+"/path.ipc", context.String(ExecutionEndpointFlag.Name))
}