From 95625629f75cafd63f58409e2cdb53f1a3111682 Mon Sep 17 00:00:00 2001
From: Raul Jordan <raul@prysmaticlabs.com>
Date: Tue, 30 Oct 2018 17:00:20 +0100
Subject: [PATCH] Disable Codecov Patch As It Is Unreliable (#713)

---
 .codecov.yml                   | 26 ++++++++++++++++++++++++++
 beacon-chain/db/attestation.go |  1 +
 beacon-chain/db/block.go       |  1 +
 beacon-chain/db/db.go          |  8 +++++---
 beacon-chain/node/node_test.go |  6 ++++--
 5 files changed, 37 insertions(+), 5 deletions(-)
 create mode 100644 .codecov.yml

diff --git a/.codecov.yml b/.codecov.yml
new file mode 100644
index 0000000000..b1e3b426f4
--- /dev/null
+++ b/.codecov.yml
@@ -0,0 +1,26 @@
+codecov:
+  notify:
+    require_ci_to_pass: yes
+
+coverage:
+  precision: 2
+  round: down
+  range: "70...100"
+
+  status:
+    project: yes
+    patch: no
+    changes: no
+
+parsers:
+  gcov:
+    branch_detection:
+      conditional: yes
+      loop: yes
+      method: no
+      macro: no
+
+comment:
+  layout: "header, diff"
+  behavior: default
+  require_changes: no
diff --git a/beacon-chain/db/attestation.go b/beacon-chain/db/attestation.go
index b71a5031c0..25448d5b80 100644
--- a/beacon-chain/db/attestation.go
+++ b/beacon-chain/db/attestation.go
@@ -46,6 +46,7 @@ func (db *BeaconDB) GetAttestation(hash [32]byte) (*types.Attestation, error) {
 // HasAttestation checks if the attestation exists.
 func (db *BeaconDB) HasAttestation(hash [32]byte) bool {
 	exists := false
+	// #nosec G104
 	db.view(func(tx *bolt.Tx) error {
 		a := tx.Bucket(attestationBucket)
 
diff --git a/beacon-chain/db/block.go b/beacon-chain/db/block.go
index 171683e024..ed14ec5ed4 100644
--- a/beacon-chain/db/block.go
+++ b/beacon-chain/db/block.go
@@ -49,6 +49,7 @@ func (db *BeaconDB) GetBlock(hash [32]byte) (*types.Block, error) {
 // HasBlock accepts a block hash and returns true if the block does not exist.
 func (db *BeaconDB) HasBlock(hash [32]byte) bool {
 	hasBlock := false
+	// #nosec G104
 	_ = db.view(func(tx *bolt.Tx) error {
 		b := tx.Bucket(blockBucket)
 
diff --git a/beacon-chain/db/db.go b/beacon-chain/db/db.go
index 186e2de995..8756255c6d 100644
--- a/beacon-chain/db/db.go
+++ b/beacon-chain/db/db.go
@@ -52,9 +52,11 @@ func NewDB(dirPath string) (*BeaconDB, error) {
 
 	db := &BeaconDB{db: boltDB}
 
-	db.update(func(tx *bolt.Tx) error {
+	if err := db.update(func(tx *bolt.Tx) error {
 		return createBuckets(tx, blockBucket, attestationBucket, mainChainBucket, chainInfoBucket)
-	})
+	}); err != nil {
+		return nil, err
+	}
 
-	return db, nil
+	return db, err
 }
diff --git a/beacon-chain/node/node_test.go b/beacon-chain/node/node_test.go
index 656ead93a3..b2011cda5f 100644
--- a/beacon-chain/node/node_test.go
+++ b/beacon-chain/node/node_test.go
@@ -18,7 +18,7 @@ func TestNodeValidator_Builds(t *testing.T) {
 		app := cli.NewApp()
 		set := flag.NewFlagSet("test", 0)
 		set.String("web3provider", "ws//127.0.0.1:8546", "web3 provider ws or IPC endpoint")
-		tmp := fmt.Sprintf("%s/datadir", os.TempDir())
+		tmp := fmt.Sprintf("%s/datadirtest1", os.TempDir())
 		set.String("datadir", tmp, "node data directory")
 		set.Bool("enable-powchain", true, "enable powchain")
 
@@ -39,6 +39,8 @@ func TestNodeValidator_Builds(t *testing.T) {
 	if e, ok := err.(*exec.ExitError); !ok || e.Success() {
 		t.Fatalf("Process ran with err %v, want exit status 1", err)
 	}
+	tmp := fmt.Sprintf("%s/datadirtest1", os.TempDir())
+	os.RemoveAll(tmp)
 }
 
 // Test that beacon chain node can close.
@@ -47,7 +49,7 @@ func TestNodeClose(t *testing.T) {
 	app := cli.NewApp()
 	set := flag.NewFlagSet("test", 0)
 	set.String("web3provider", "ws//127.0.0.1:8546", "web3 provider ws or IPC endpoint")
-	tmp := fmt.Sprintf("%s/datadir", os.TempDir())
+	tmp := fmt.Sprintf("%s/datadirtest2", os.TempDir())
 	set.String("datadir", tmp, "node data directory")
 	set.Bool("enable-powchain", false, "no powchain service")
 	set.Bool("demo-config", true, "demo configuration")