Prevent Usage of Stdlib File/Dir Writing With Static Analysis (#7685)

* write file and mkdirall analyzers

* include analyzer in build bazel

* comments to the single entrypoint and fix validator references

* enforce 600 for files, 700 for dirs

* pass validator tests

* add to nogo

* remove references

* beaconfuzz

* docker img

* fix up kv issue

* mkdir if not exists

* radek comments

* final comments

* Try to fix file problem

Co-authored-by: Ivan Martinez <ivanthegreatdev@gmail.com>
This commit is contained in:
Raul Jordan
2020-11-09 14:27:03 -06:00
committed by GitHub
parent 15706a36cb
commit d4c954648c
47 changed files with 432 additions and 68 deletions

View File

@@ -10,6 +10,7 @@ go_library(
importpath = "github.com/prysmaticlabs/prysm/tools/enr-calculator",
visibility = ["//visibility:private"],
deps = [
"//shared/fileutil:go_default_library",
"//shared/maxprocs:go_default_library",
"@com_github_ethereum_go_ethereum//p2p/enode:go_default_library",
"@com_github_ethereum_go_ethereum//p2p/enr:go_default_library",
@@ -41,6 +42,7 @@ go_image(
"@com_github_ethereum_go_ethereum//p2p/enr:go_default_library",
"@com_github_libp2p_go_libp2p_core//crypto:go_default_library",
"@com_github_sirupsen_logrus//:go_default_library",
"//shared/fileutil:go_default_library",
"//shared/maxprocs:go_default_library",
],
)

View File

@@ -6,12 +6,12 @@ import (
"crypto/ecdsa"
"encoding/hex"
"flag"
"io/ioutil"
"net"
"github.com/ethereum/go-ethereum/p2p/enode"
"github.com/ethereum/go-ethereum/p2p/enr"
"github.com/libp2p/go-libp2p-core/crypto"
"github.com/prysmaticlabs/prysm/shared/fileutil"
_ "github.com/prysmaticlabs/prysm/shared/maxprocs"
log "github.com/sirupsen/logrus"
)
@@ -68,7 +68,7 @@ func main() {
log.Info(localNode.Node().String())
if *outfile != "" {
err := ioutil.WriteFile(*outfile, []byte(localNode.Node().String()), 0644)
err := fileutil.WriteFile(*outfile, []byte(localNode.Node().String()))
if err != nil {
panic(err)
}