Preston Van Loon
2fd6bd8150
Add golang.org/x/tools modernize static analyzer and fix violations ( #15946 )
...
* Ran gopls modernize to fix everything
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.
To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.
* Fix buildtag violations and ignore buildtag violations in external
* Introduce modernize analyzer package.
* Add modernize "any" analyzer.
* Fix violations of any analyzer
* Add modernize "appendclipped" analyzer.
* Fix violations of appendclipped
* Add modernize "bloop" analyzer.
* Add modernize "fmtappendf" analyzer.
* Add modernize "forvar" analyzer.
* Add modernize "mapsloop" analyzer.
* Add modernize "minmax" analyzer.
* Fix violations of minmax analyzer
* Add modernize "omitzero" analyzer.
* Add modernize "rangeint" analyzer.
* Fix violations of rangeint.
* Add modernize "reflecttypefor" analyzer.
* Fix violations of reflecttypefor analyzer.
* Add modernize "slicescontains" analyzer.
* Add modernize "slicessort" analyzer.
* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686 .
* Add modernize "stringscutprefix" analyzer.
* Add modernize "stringsbuilder" analyzer.
* Fix violations of stringsbuilder analyzer.
* Add modernize "stringsseq" analyzer.
* Add modernize "testingcontext" analyzer.
* Add modernize "waitgroup" analyzer.
* Changelog fragment
* gofmt
* gazelle
* Add modernize "newexpr" analyzer.
* Disable newexpr until go1.26
* Add more details in WORKSPACE on how to update the override
* @nalepae feedback on min()
* gofmt
* Fix violations of forvar
2025-11-14 01:27:22 +00:00
oftenoccur
393e63e8e5
refactor: using slices.Contains to simplify the code ( #14781 )
...
Signed-off-by: oftenoccur <ezc5@sina.com >
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com >
2025-01-09 00:04:45 +00:00
terence tsao
068f758f49
Code inspect - clean ups ( #8445 )
2021-02-12 17:04:45 -06:00
Radosław Kapka
e1cd9143e0
Package-level comments for static analyzers ( #7332 )
...
* package-level comments
* Merge refs/heads/master into analyzer-package-comments
2020-09-24 10:25:55 +00:00
Radosław Kapka
aaa3abf630
Shadowed Predeclared Indentifier analyzer ( #7215 )
...
* wip
* working for some ast nodes
* works for all but assignment
* works for all but mixed assignments
* change test name
* plug in the analyzer
* remove `copy` from predeclared list
* rename few shadowing names
* rename `len` to `length`
* add one more test case
* rename `panic` to `panicResult`
* replace `panic` with `panicResult` in error message
* remove test case not covered by the tool
* add `byte` to predeclared list
* additional test cases
* rename `copy` to `copyHandler`
* exclude functions with receivers
* revert to good names
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-09-14 12:49:15 +02:00
