Preston Van Loon
2fd6bd8150
Add golang.org/x/tools modernize static analyzer and fix violations ( #15946 )
...
* Ran gopls modernize to fix everything
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.
To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.
* Fix buildtag violations and ignore buildtag violations in external
* Introduce modernize analyzer package.
* Add modernize "any" analyzer.
* Fix violations of any analyzer
* Add modernize "appendclipped" analyzer.
* Fix violations of appendclipped
* Add modernize "bloop" analyzer.
* Add modernize "fmtappendf" analyzer.
* Add modernize "forvar" analyzer.
* Add modernize "mapsloop" analyzer.
* Add modernize "minmax" analyzer.
* Fix violations of minmax analyzer
* Add modernize "omitzero" analyzer.
* Add modernize "rangeint" analyzer.
* Fix violations of rangeint.
* Add modernize "reflecttypefor" analyzer.
* Fix violations of reflecttypefor analyzer.
* Add modernize "slicescontains" analyzer.
* Add modernize "slicessort" analyzer.
* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686 .
* Add modernize "stringscutprefix" analyzer.
* Add modernize "stringsbuilder" analyzer.
* Fix violations of stringsbuilder analyzer.
* Add modernize "stringsseq" analyzer.
* Add modernize "testingcontext" analyzer.
* Add modernize "waitgroup" analyzer.
* Changelog fragment
* gofmt
* gazelle
* Add modernize "newexpr" analyzer.
* Disable newexpr until go1.26
* Add more details in WORKSPACE on how to update the override
* @nalepae feedback on min()
* gofmt
* Fix violations of forvar
2025-11-14 01:27:22 +00:00
Potuz
7794a77ae6
Use Head to validate sidecars when possible ( #15977 )
...
* Use Head to validate sidecars when possible
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
* LazyHeadStateProvider that avoids service registry
* Remove extra file
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com >
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
2025-11-06 18:43:38 +00:00
Bastin
92bd211e4d
upgrade v6 to v7 ( #15989 )
...
* upgrade v6 to v7
* changelog
* update-go-ssz
2025-11-06 16:16:23 +00:00
Potuz
be144da099
fix test race conditions ( #15792 )
...
Fix race condition where svc.verifierWaiter was being set after
svc.Start() was already running, causing nil pointer dereference.
2025-10-01 19:29:20 +00:00
kasey
029b896c79
refactor subscription code to enable peer discovery asap ( #15660 )
...
* refactor subscription code to enable peer discovery asap
* fix subscription tests
* hunting down the other test initialization bugs
* refactor subscription parameter tracking type
* manu naming feedback
* manu naming feedback
* missing godoc
* protect tracker from nil subscriptions
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
2025-09-09 21:00:34 +00:00
kasey
3da40ecd9c
Refactor fork schedules ( #15490 )
...
* overhaul fork schedule management for bpos
* Unify log
* Radek's comments
* Use arg config to determine previous epoch, with regression test
* Remove unnecessary NewClock. @potuz feedback
* Continuation of previous commit: Remove unnecessary NewClock. @potuz feedback
* Remove VerifyBlockHeaderSignatureUsingCurrentFork
* cosmetic changes
* Remove unnecessary copy. entryWithForkDigest passes by value, not by pointer so it shold be fine
* Reuse ErrInvalidTopic from p2p package
* Unskip TestServer_GetBeaconConfig
* Resolve TODO about forkwatcher in local mode
* remove Copy()
---------
Co-authored-by: Kasey <kasey@users.noreply.github.com >
Co-authored-by: terence tsao <terence@prysmaticlabs.com >
Co-authored-by: rkapka <radoslaw.kapka@gmail.com >
Co-authored-by: Preston Van Loon <preston@pvl.dev >
2025-08-11 16:08:53 +00:00
Preston Van Loon
62fec4d1f3
Replace context.Background with testing.TB.Context where possible ( #15416 )
...
* Replace context.Background with testing.TB.Context where possible
* Fix failing tests
2025-06-16 22:09:18 +00:00
terence
774b9a7159
Migrate Prysm repo to Offchain Labs organization ahead of Pectra V6 ( #15140 )
...
* Migrate Prysm repo to Offchain Labs organization ahead of Pectra upgrade v6
* Replace prysmaticlabs with OffchainLabs on general markdowns
* Update mock
* Gazelle and add mock.go to excluded generated mock file
2025-04-10 15:40:39 +00:00
james-prysm
0453d18395
small cleanup on functions ( #13666 )
2024-02-26 22:23:23 +00:00
terence
5a66807989
Update to V5 ( #13622 )
...
* First take at updating everything to v5
* Patch gRPC gateway to use prysm v5
Fix patch
* Update go ssz
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
2024-02-15 05:46:47 +00:00
terence
9b1b6f9be6
Use verified blob for gossip checks ( #13294 )
...
* Use blob verifier for gossip rules
* Fixing tests
* Fix lint
* Mocks
* Trying Kasey's rec
* mock verifier init workaround
* Add more tests
* Reset deneb epoch for exit test
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
2023-12-11 00:37:45 +00:00
terencechain
cb5ce74a23
Add pending blobs queue for missing parent block ( #13005 )
...
* Add pending blobs queue for missing parent block
* Prune sidecars older than previous slot
* Prune sidecar based on time
* Tests
* Fix state notifier
* Wait for chain to start
* Remove logs
* Remove bad logs
* James feedback
* Fix conflict
* Rm outdated check
* Potuz's feedback
* Kasey's feedback
* Use 11s mark
* Use secs
* Add pending blobs queue for missing parent block
* Prune sidecars older than previous slot
* Prune sidecar based on time
* Tests
* Fix state notifier
* Wait for chain to start
* Remove logs
* Remove bad logs
* James feedback
* Fix conflict
* Rm outdated check
* Potuz's feedback
* Kasey's feedback
* Use 11s mark
* Use secs
* Add test case for duplicates
* Radek's feedback
* Fix test
2023-10-17 14:42:15 +00:00
Potuz
b84dd40ba9
Use forkchoice to validate sync messages faster ( #12430 )
...
* Use forkchoice to validate sync messages faster
* add metric
2023-05-19 14:47:39 +00:00
kasey
918129cf36
Replace statefeed Initialize ( #12285 )
...
* refactor initialization to blocking startup method
* require genesisSetter in blockchain, fix tests
* work-around gazelle weirdness
* fix dep gazelle ignores
* only call SetGenesis once
* fix typo
* validator test setup and fix to return right error
* move waitForChainStart to Start
* wire up sync Service.genesisWaiter
* fix p2p genesisWaiter plumbing
* remove extra clock type, integrate into genesis
and rename
* use time.Now when no Nower is specified
* remove unused ClockSetter
* simplify rpc context checking
* fix typo
* use clock everywhere in sync; [32]byte val root
* don't use DeepEqual to compare [32]byte and []byte
* don't use clock in init sync, not wired up yet
* use clock waiter in blockchain as well
* use cancelable contexts in tests with goroutines
* missed a reference to WithClockSetter
* Update beacon-chain/startup/genesis.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update beacon-chain/blockchain/service_test.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* more clear docs
* doc for NewClock
* move clock typedef to more logical file name
* adding documentation
* gaz
* fixes for capella
* reducing test raciness
* fix races in committee cache tests
* lint
* add tests on Duration slot math helper
* startup package test coverage
* fix bad merge
* set non-zero genesis time in tests that call Start
* happy deepsource, happy me-epsource
* replace Synced event with channel
* remove unused error
* remove accidental wip commit
* gaz!
* remove unused event constants
* remove sync statefeed subscription to fix deadlock
* remove state notifier
* fix build
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: nisdas <nishdas93@gmail.com >
2023-05-03 04:34:01 +00:00
terencechain
d17996f8b0
Update to V4 🚀 ( #12134 )
...
* Update V3 from V4
* Fix build v3 -> v4
* Update ssz
* Update beacon_chain.pb.go
* Fix formatter import
* Update update-mockgen.sh comment to v4
* Fix conflicts. Pass build and tests
* Fix test
2023-03-17 18:52:56 +00:00
Radosław Kapka
77d3ccb9ad
Clean up state types ( #11916 )
...
* Clean up state types
* rename package
2023-01-26 14:40:12 +00:00
Patrice Vignola
83f48350b2
Fix a bunch of deepsource warnings ( #11814 )
2022-12-22 09:20:10 +00:00
Preston Van Loon
6bea17cb54
Update libp2p to support go 1.19 ( #11309 )
...
* Update libp2p to support go 1.19
* gaz
* go mod tidy
* Only update the minimum deps
* go mod tidy
* revert .bazelrc
* Update go-libp2p to v0.22.0 and update import paths (#11440 )
* Fix import paths
* Fix go-libp2p-peerstore import
* Bazel updates
* fix
* revert some comments changes
* revert some comment stuff
* fix dependency issues
* vendor problematic library
* use your brain
* remove
* tests
Co-authored-by: Marco Munizaga <marco@marcopolo.io >
Co-authored-by: Nishant Das <nishdas93@gmail.com >
2022-10-07 15:24:51 +08:00
kasey
805473cb38
Give forkchoice to stategen ( #11439 )
...
* add forkchoice to stategen.New, update everywhere
* conflict_1
* Fix proposer_bellatrix test
Co-authored-by: Potuz <potuz@prysmaticlabs.com >
2022-09-28 20:10:27 +00:00
terencechain
c94095b609
Accept everything when node is optimistic ( #11320 )
2022-08-26 21:41:59 +00:00
terencechain
a2193ee014
Accept attestations when node is optimistic ( #11319 )
...
* Accept attestations when node is optimistic
* Fix tests
* Add regression tests
* Fix tests
* Fix more bad tests
2022-08-25 20:15:07 -03:00
Raul Jordan
d077483577
Add V3 Suffix to All Prysm Packages ( #11083 )
...
* v3 import renamings
* tidy
* fmt
* rev
* Update beacon-chain/core/epoch/precompute/reward_penalty_test.go
* Update beacon-chain/core/helpers/validators_test.go
* Update beacon-chain/db/alias.go
* Update beacon-chain/db/alias.go
* Update beacon-chain/db/alias.go
* Update beacon-chain/db/iface/BUILD.bazel
* Update beacon-chain/db/kv/kv.go
* Update beacon-chain/db/kv/state.go
* Update beacon-chain/rpc/prysm/v1alpha1/validator/attester_test.go
* Update beacon-chain/rpc/prysm/v1alpha1/validator/attester_test.go
* Update beacon-chain/sync/initial-sync/service.go
* fix deps
* fix bad replacements
* fix bad replacements
* change back
* gohashtree version
* fix deps
Co-authored-by: Nishant Das <nishdas93@gmail.com >
Co-authored-by: Potuz <potuz@prysmaticlabs.com >
2022-08-16 12:20:13 +00:00
Radosław Kapka
7f56ac6355
Massive code cleanup ( #10913 )
...
* Massive code cleanup
* fix test issues
* remove GetGenesis mock expectations
* unused receiver
* rename unused params
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2022-06-27 13:34:38 +00:00
Raul Jordan
84916672c6
Remove Eth2-Types Dependency in Prysm ( #10578 )
...
* replace eth2 types
* replace protos
* regen proto
* replace
* gaz
* deps
* amend
* regen proto
* mod
* gaz
* gaz
* ensure build
* ssz
* add dep
* no more eth2 types
* no more eth2
* remg
* all builds
* buidl
* tidy
* clean
* fmt
* val serv
* gaz
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com >
2022-04-29 10:32:11 -04:00
Mohamed Zahoor
a103dd91c0
cherry picked PR for #10274 ( #10300 )
...
* ignore topic messages (except block topic) during optimistic sync
* address review comments
* nit pick fix
Co-authored-by: Nishant Das <nishdas93@gmail.com >
2022-03-06 08:09:12 +00:00
Radosław Kapka
c5c039fd6b
Unify GenesisValidator(s)Root throughout the codebase ( #10230 )
...
* Unify `GenesisValidator(s)Root` throughout the codebase
* comments and literals
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com >
2022-02-14 13:34:38 +00:00
Raul Jordan
233171d17c
[Service Config Revamp] - Sync Service With Functional Options ( #9859 )
...
* sync config refactor
* rem
* rem
* testing
* gaz
* next
* fuzz
* build
* fuzz
* rev
* log
* cfg
2021-11-05 19:08:58 +00:00
terence tsao
c21e43e4c5
Refactor: move functions beacon-chain/core/time -> time/slots ( #9719 )
...
* Move necessary functions beacon-chain/core/time -> time/slots
* Fix fuzz
* Fix build
* Update slot_epoch.go
2021-10-01 15:17:57 -05:00
terence tsao
8219af46e4
Move slot epoch from core to time pkg ( #9714 )
...
* Move slot epoch from core to time pkg
* Fix fuzz
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-30 19:00:14 +00:00
Preston Van Loon
ee0a453b7b
core: refactor signing and domain methods from helper to core/signing pkg ( #9520 )
...
* Move domain function and all signing root functions from beacon-chain/core/helpers to beacon-chain/core
* @terencechain suggestion to put these methods under core/signing
2021-09-27 16:19:20 +00:00
Nishant Das
6e4c2b4b20
Wrap Gossip Validators With Error ( #9660 )
2021-09-25 18:06:48 -07:00
Raul Jordan
a9a4bb9163
Move Shared/Testutil into Testing ( #9659 )
...
* move testutil
* util pkg
* build
* gaz
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-23 18:53:46 +00:00
Raul Jordan
29513c804c
Create Encoding Bytesutil ( #9658 )
...
* bytesutil
* gaz
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-23 15:23:37 +00:00
Raul Jordan
f3d6dbcc1e
Move Shared/Params Into Config/Params ( #9642 )
...
* config params into pkg
* gaz
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-21 19:59:25 +00:00
terence tsao
161a13ac09
Correctly filter sync committee message at period boundary ( #9626 )
...
* Add head sync committee indices with slot consideration
* Apply rpc
* Apply sync
* Update tests
* Update mock.go
* Update sync_committee_test.go
* Update validator_test.go
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-20 18:06:43 +00:00
Nishant Das
97f6143a43
Add Remaining Gossip Changes ( #9553 )
...
* add changes
* add changes here in
* rem duplicate import
* fix topic not being set in test
* terence's review
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com >
2021-09-10 02:36:31 +00:00
Preston Van Loon
b586d3784b
Rename beacon-chain/core/state to beacon-chain/core/transition pkg ( #9530 )
...
* Move, refactor, fix
* @rkapka PR feedback: revert irrelevant changes
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-08 10:41:47 +00:00
Nishant Das
ee28dc3d4f
Add in Fork Digest For Subscribers ( #9538 )
...
* add in digest
* radek's review
* raul's review
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com >
2021-09-07 16:58:24 +00:00
Preston Van Loon
4beb352e6f
Move Slot and Epoch functions from helpers to core pkg ( #9519 )
...
* Move Slot and Epoch functions from helpers to core
* limited viz
* goimports
* fix fuzz build
* fix fuzz build
* fix
* fix
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-09-03 20:10:31 +00:00
Nishant Das
30b2adc5d6
Add in Sync Contribution And Proof Pubsub Validator ( #9475 )
...
* add contribution handlers
* fix it
* fmt
* fix more
* add clean up
* Apply suggestions from code review
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update beacon-chain/sync/validate_sync_contribution_proof.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* use validation pipeline
* deepsource
* fix all tests
* clean up
* comment
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com >
2021-09-03 04:06:54 +00:00
Marcin Górzyński
02966e64d8
Feature lru cache wrapper 2 ( #9511 )
...
* Add Wrapper to LRU Cache to handle Invalid Parameters #9461
* Regenerate BUILD.bazel and simplify tests using lru.Cache
* Fix: fuzz_exports.go build error
* Fix: block_fuzz.go
* Revert lru.Cache interface
* Remove redundant err check in pending_attestations_queue_test.go
* Add tests for lru wrapper
* Use lru package in prysm/shared instead of lruwrpr
* Fix: goimports
* Fix: BUILD.bazel
Co-authored-by: Nishant Das <nishdas93@gmail.com >
2021-09-02 18:36:54 +08:00
Raul Jordan
2cd2bc87d0
Sync Committee Message P2P Validations ( #9481 )
...
* add in handlers
* add topic switch
* begin refactor
* build
* revert change to sub file
* reordered
* add in handlers
* add topic switch
* fmt
* begin refactor
* build
* revert change to sub file
* reordered
* rationale for cache size
* simplify
* deep source
* kasey feedback
* ignore if not in committee
* add more unit tests
* more cov
* code review commentary
* pass tests
* commentary
* terence comments
* terence feedback on key for cache
Co-authored-by: nisdas <nishdas93@gmail.com >
2021-09-02 02:26:38 +00:00