Justin Traglia
4ed90a02ef
Rename various variables/functions to be more clear ( #15529 )
...
* Rename various variables/functions to be more clear
* Add changelog fragment
---------
Co-authored-by: Bastin <43618253+Inspector-Butters@users.noreply.github.com >
2025-08-14 11:06:22 +00:00
kasey
84c8653a52
initialize genesis data asap at node start ( #15470 )
...
* initialize genesis data asap at node start
* add genesis validation tests with embedded state verification
* Add test for hardcoded mainnet genesis validator root and time from init() function
* Add test for UnmarshalState in encoding/ssz/detect/configfork.go
* Add tests for genesis.Initialize
* Move genesis/embedded to genesis/internal/embedded
* Gazelle / BUILD fix
* James feedback
* Fix lint
* Revert lock
---------
Co-authored-by: Kasey <kasey@users.noreply.github.com >
Co-authored-by: terence tsao <terence@prysmaticlabs.com >
Co-authored-by: Preston Van Loon <preston@pvl.dev >
2025-08-10 02:09:40 +00:00
Manu NALEPA
149e220b61
Validator custody: Update to the latest specification. ( #15532 )
...
* Validator custody: Update to the latest specfication.
* Update beacon-chain/blockchain/process_block.go
Co-authored-by: terence <terence@prysmaticlabs.com >
* Fix James' comment.
* Fix James' comment.
* Fix James' comment.
---------
Co-authored-by: terence <terence@prysmaticlabs.com >
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com >
2025-08-02 06:21:08 +00:00
Bastin
ae4b982a6c
Fix finality update bugs & Move broadcast logic to LC Store ( #15540 )
...
* fix IsBetterFinalityUpdate and add tests
fix finality update bugs
* Update lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update beacon-chain/core/light-client/lightclient.go
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-08-01 12:35:21 +00:00
Bastin
deb3ba7f21
Remove unused parameter from LC functions ( #15514 )
...
* remove unused parameter
* format code
2025-07-21 13:50:21 +00:00
Bastin
8b53887891
Save LC Bootstraps only on finalized checkpoints ( #15497 )
...
* Unify LC API (updates)
* Remove unused fields in LC beacon API server
* bootstraps only on checkpoints
* Update beacon-chain/blockchain/receive_block.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* move tests
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-07-18 15:53:31 +00:00
Bastin
dce89a1627
Unify LC API 2/2 (updates) ( #15488 )
...
* Unify LC API (updates)
* Update beacon-chain/core/light-client/store.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-07-17 10:59:51 +00:00
Preston Van Loon
499d27b6ae
Use time.Time instead of uint64 for genesis time ( #15419 )
...
* Convert genesis times from seconds to time.Time
* Fixing failed forkchoice tests in a new commit so it doesn't get worse
Fixing failed spectest tests in a new commit so it doesn't get worse
Fixing forkchoice tests, then spectests
* Fixing forkchoice tests, then spectests. Now asking for help...
* Fix TestForkChoice_GetProposerHead
* Fix broken build
* Resolve TODO(preston) items
* Changelog fragment
* Resolve TODO(preston) items again
* Resolve lint issues
* Use consistant field names for sinceSlotStart (no spaces)
* Manu's feedback
* Renamed StartTime -> UnsafeStartTime, marked as deprecated because it doesn't handle overflow scenarios.
Renamed SlotTime -> StartTime
Renamed SlotAt -> At
Handled the error in cases where StartTime was used.
@james-prysm feedback
* Revert beacon-chain/blockchain/receive_block_test.go from 1b7844de
* Fixing issues after rebase
* Accepted suggestions from @potuz
* Remove CanonicalHeadSlot from merge conflicts
---------
Co-authored-by: potuz <potuz@prysmaticlabs.com >
2025-07-14 21:04:50 +00:00
Bastin
5c1d827335
Unify LC API 1/2 (bootstrap) ( #15476 )
...
* add versiotToForkEpoch map
* Unify LC API (bootstrap)
2025-07-10 13:07:46 +00:00
kasey
288b33750d
Isolate committee cache ( #15478 )
...
* always init service through NewService
* move head state cache to service struct
* changelog
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
2025-07-09 21:43:00 +00:00
Bastin
bddcc158e4
Fix LC versioning bug ( #15400 )
...
* fix versioning
* changelog
* fix blockchain tests
* fix linter issue
* fix spec tests
* fix default lc update version
* fix lc header version
* gzl
* clean up the code
* Update testing/spectest/shared/common/light_client/update_ranking.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
* add fulu set up in update ranking
* pass att block to createDefaultLCUpdate
* address comments
* linter
* Update lightclient.go
* sort imports
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
2025-07-01 21:40:18 +00:00
Manu NALEPA
559d02bf4d
peerDAS: Implement dataColumnSidecarByRootRPCHandler. ( #15405 )
...
* `CreateTestVerifiedRoDataColumnSidecars`: Use consistent block root.
* peerDAS: Implement `dataColumnSidecarByRootRPCHandler`.
* Fix James' comment.
* Fix James' comment.
2025-06-19 12:12:45 +00:00
Preston Van Loon
62fec4d1f3
Replace context.Background with testing.TB.Context where possible ( #15416 )
...
* Replace context.Background with testing.TB.Context where possible
* Fix failing tests
2025-06-16 22:09:18 +00:00
Radosław Kapka
f5a9394c77
Reorganize processing of light client updates ( #15383 )
...
* Reorganize processing of light client updates
* changelog <3
2025-06-09 17:08:23 +00:00
Manu NALEPA
a0060fa794
PeerDAS: Implement blockchain. ( #15350 )
...
* PeerDAS: Implement blockchain.
* Fix forkchoice spectest panic.
* Update beacon-chain/blockchain/error.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
* Fix Preston's comment.
* Fix Preston's comment.
* Fix Preston's comment.
* Fix Preston's comment.
* Fix Preston's comment.
* Fix Preston's comment.
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
2025-06-02 11:33:07 +00:00
Bastin
6df476835c
Turn on lc gossip ( #15220 )
...
* add and pass lcstore to sync service
* validator for optimistic updates
* validator for finality updates
* subscribers
* gossip scorings
* tmp - add validation test
* optimistic update validation tests
* finality update validation tests
* tests for subscribers
* deps
* changelog entry
* play around with config cleanup
* turn on gossip
* add logs
* fix typo
* mock p2p
* deps
* better logs
* turn on gossip
* add logs
* fix typo
* update geth v1.15.9 (#15216 )
* Update go-ethereum to v1.15.9
* Fix go-ethereum secp256k1 build after https://github.com/ethereum/go-ethereum/pull/31242
* Fix Ping API change
* Changelog fragment
* mock p2p
* deps
* fix merge problems
* changelog entry
* Update broadcaster.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update broadcaster.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-05-05 11:36:36 +00:00
Bastin
c9e8701987
Save LC Finality and Optimistic Updates in LC Store When Processing Block ( #15124 )
...
* add lcStore to Node
* changelog entry
* add atomic getters and setters for the store
* add lcstore to the blockchain package
* save lc finality update to store
* save lc optimistic update to store
* changelog entry
* change store fields visibility to private
* refactor method names and add tests
* add lcstore to the blockchain package
* save lc finality update to store
* save lc optimistic update to store
* changelog entry
* refactor method names
* setup tests
* remove get from getters
* add lcstore to the blockchain package
* save lc finality update to store
* save lc optimistic update to store
* changelog entry
* refactor method names
* setup tests
* rename methods
* temp
* temp
* add tests
* fixing tests
* stash
* refactor setUpAltair
* remove debug code
* refactor bellatrix setup
* refactor capella setup
* refactor rest - core tests remain
* refactor tests to use new functional options utils
* use the options
* add noFinalizedCheckpoint and finalizedCheckpointInPrevFork options
* add tests
* changelog entry
* refactor tests
* deps
* fix tests
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* address comments
* address comments
* address comments
* go mod tidy
* fix annoying conflicts
* go mod tidy
* fix conflicts
* cleanup tests
* add SetupTestConfigCleanup
* commit to restart CI checks
* address comments
* address comments
* address comments
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-04-15 10:38:20 +00:00
Bastin
cd87082f25
Refactor lc tests ( #15155 )
...
* refactor setUpAltair
* remove debug code
* refactor bellatrix setup
* refactor capella setup
* refactor rest - core tests remain
* refactor tests to use new functional options utils
* use the options
* add noFinalizedCheckpoint and finalizedCheckpointInPrevFork options
* add tests
* changelog entry
* refactor tests
* deps
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* Update testing/util/lightclient.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
* address comments
* address comments
* address comments
* go mod tidy
* fix annoying conflicts
* go mod tidy
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2025-04-14 10:57:31 +00:00
terence
774b9a7159
Migrate Prysm repo to Offchain Labs organization ahead of Pectra V6 ( #15140 )
...
* Migrate Prysm repo to Offchain Labs organization ahead of Pectra upgrade v6
* Replace prysmaticlabs with OffchainLabs on general markdowns
* Update mock
* Gazelle and add mock.go to excluded generated mock file
2025-04-10 15:40:39 +00:00
Bastin
fa5d2a88ce
Fix LC test utils problem ( #15133 )
...
* fix problem with MinSyncCommitteeParticipants
* fix usages
* changelog entry
2025-04-04 16:30:55 +00:00
Bastin
09309ab1f2
Refactor LC Test Utils ( #15131 )
...
* refactor test utils
* refactor test utils
* rename parameter
2025-04-04 11:35:21 +00:00
Radosław Kapka
15462844f9
Remove error from signatures of UnaggregatedAttestations and pruneAttsFromPool ( #15028 )
2025-03-10 22:28:51 +00:00
Radosław Kapka
6d89373583
Handle unaggregated attestations when decomposing ( #15027 )
2025-03-10 13:48:43 +00:00
Potuz
3cd2973c92
Return the genesis block root from last validated checkpoint if zero ( #15021 )
...
* Return the genesis block root from last validated checkpoint if zero
When starting a node we load the last validated checkpoint. On tests or a new node this checkpoint can have the zero blockroot (it returns the finalized checkpoint). This PR ensures that it returns the genesis block root instead.
It can't affect runnning code since the root is only used at startup in `setup_forkchoice`. But it may affect tests because now `OptimisticForRoot` will error out if there is no genesis block root set on db.
* Terence review
* fix test
2025-03-06 21:42:11 +00:00
Radosław Kapka
417bbf8a9e
Decompose Electra block attestations ( #14896 )
...
* Decompose Electra block attestations
* comments
* changelog <3
* remove redundant comparison
* typo in comment
* fix changelog section name
* review from James and Sammy
* continue pruning on error
* only prune when committees are cached
* fix bad assignments in test
2025-03-05 10:01:33 +00:00
Potuz
b6d1866deb
Split out forkchoice setup from service start ( #14997 )
2025-02-27 20:38:29 +00:00
Jun Song
557c5be433
Prune pending deposits from the deposit cache post-Electra ( #14829 )
...
* Add metrics for pruned proofs & pending deposits
* Add PruneAllProofs & PruneAllPendingDeposits
* Add simple unit tests
* Add DepositPruner interface
* Add pruning logic at post finalization task
* Move pruner logic into new file(deposit_pruner.go)
Rationale:
As deposit_fetcher.go contains all pruning logics, it would be better to separate its interest into fetcher/inserter/pruner.
* Gofmt
* Add reference link for deprecating eth1 polling
* Add changelog
* Apply reviews from nisdas and james
* add pre and post deposit request tests
* nishant's comment
---------
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com >
Co-authored-by: james-prysm <james@prysmaticlabs.com >
2025-02-07 04:31:01 +00:00
kasey
41daac1b04
Organize blobs on disk by epoch ( #14023 )
...
* organize blob directories by period and epoch
* changelog
* remove Indices and replace with Summary
* old PR feedback
* log to advise about the speed of blob migration
* rename level->layer (hoping term is more clear)
* assert path in tests for increased legibility
* lint
* lint
* remove test covering a newly impossible error
* improve feedback from flag validation failure
* Try to clean dangling dirs epoch->flat migration
* lint
* Preston feedback
* try all layouts and short-circuit if base not found
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
2025-02-05 20:09:38 +00:00
Radosław Kapka
9cf6b93356
Handle AttesterSlashingElectra everywhere in the codebase ( #14823 )
...
* Handle `AttesterSlashingElectra` everywhere in the codebase
* simplify `TestProcessAttesterSlashings_AppliesCorrectStatus`
2025-01-28 15:06:37 +00:00
terence
bc69ab8a44
Support for different blob target and max values ( #14678 )
...
* Add support for different blob target and max
* Fix change log to right section
2024-12-19 14:58:24 +00:00
Bastin
4bb0b44f16
Add tests for saving light client updates ( #14717 )
...
* move flag settings out of individual tests
* add tests with better or worst old update
* remove whitespace
* add zero fields for default update at deneb block in electra
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2024-12-18 08:08:25 +00:00
Rupam Dey
30a136f1fb
save light client updates (diff) ( #14683 )
...
* update diff
* deps
* add tests for `SaveLightClientUpdate`
* cleanup imports
* lint
* changelog
* fix incorrect arithmetic
* check for lightclient feature flag
* fix tests
* fix `saveLightClientBootstrap` and `saveLightClientUpdate`
* replace and with or
* move feature check to `postBlockProcess`
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl >
2024-12-04 21:22:43 +00:00
Nishant Das
dc643c9f32
Fix Deadline Again During Rollback ( #14686 )
...
* fix it again
* CHANGELOG
2024-12-02 13:29:36 +00:00
Nishant Das
928b707ef1
Rollback Block With Context Deadline ( #14608 )
...
* Rollback deadline
* Fix it
* Preston's Suggestion
2024-11-04 15:47:30 +00:00
Potuz
4d98049054
Use ROBlock earlier in the pipeline ( #14609 )
2024-11-03 11:04:12 +00:00
Nishant Das
2fe8614115
Rollback Block During Processing ( #14554 )
...
* Change it to rollback
* Spacing
* Reverse order of rollback
* Add Rollback Test
* Potuz's Test Suggestion
* Potuz's Suggestion
2024-10-28 14:06:20 +00:00
Potuz
83ed320826
Use ROBlock in block processing pipeline ( #14571 )
...
* Use ROBlock in block processing pipeline
* Pass blockchain tests
* passing forkchoice tests
* pass rpc test
* change changelog
2024-10-24 13:27:15 +00:00
james-prysm
2a44e8e6ec
test util functions for electra field generation ( #14320 )
...
* adding some util functions for electra field generation
* linting
* adding missed linting
2024-08-12 15:36:03 +00:00
Potuz
600ca08aa8
Use the beacon block root to verify the prestate ( #14290 )
2024-08-01 20:22:37 +00:00
Radosław Kapka
2d15e53dab
Eip 7549 core ( #14037 )
...
* interfaces move
* build fix
* remove annoying warning
* more build fixes
* review
* core code
* tests part 1
* tests part 2
* TranslateParticipation doesn't need Electra
* remove unused function
* pending atts don't need Electra
* tests part 3
* build fixes
* review
* remove newline
* review
* fix test
2024-05-28 13:56:36 +00:00
Radosław Kapka
0fbb27d8e3
EIP-7549: Add aggregate attestation interfaces ( #14029 )
...
* interfaces move
* build fix
* remove annoying warning
* more build fixes
* review
2024-05-22 16:14:08 +00:00
Radosław Kapka
2c5a2e8ec7
Electra attestation interfaces ( #13937 )
...
* config values
* block protos
* get_committee_indices
* proto and ssz
* attestation interface
* Revert "Auxiliary commit to revert individual files from deadb2183723511721b3288c7168808a4fa97c64"
This reverts commit 32ad5009537bc5ec0e6caf9f52143d380d00be85.
* todos
* get_attesting_indices
* Revert "Auxiliary commit to revert individual files from dd2789723f90b15eb1f874b561d88d11dcc9c0bf"
This reverts commit f39644ed3cb6f3964fc6c86fdf4bd5de2a9668c8.
* beacon spec changes
* Fix pending attestation. Build ok
* Electra: add electra version
* Electra: consensus types
* gocognit exclusion
* @potuz's suggestion
* build fix
* interfaces for indexed att and slashing
* indexed att usage
* BuildSignedBeaconBlockFromExecutionPayload
* slashing usage
* grpc stubs
* remove unused methods
* Electra attestation interfaces
* cleanup
* tests
* make linter happy
* simple casting
* test fixes
* Fix spectest failures
* Regen pb and ssz files
* Handle "not ok" type assertion cases
* Setters that check version should always return an error. SetAttesterSlashings and SetAttestations
* gofmt
* Fix TestMinSpanChunksSlice_CheckSlashable
---------
Co-authored-by: terence tsao <terence@prysmaticlabs.com >
Co-authored-by: Preston Van Loon <preston@pvl.dev >
2024-04-30 21:29:38 +00:00
kasey
4c3dbae3c0
tests for origin blob fetching ( #13667 )
...
* tests for origin blob fetching
* Update beacon-chain/sync/initial-sync/service.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
2024-03-02 15:11:22 +00:00
Nishant Das
f1615c4c88
Employ Dynamic Cache Sizes ( #13640 )
...
* dynamic cache sizes
* tests
* gosimple
* fix it
* add tests
* comments
* skip test
* Update beacon-chain/blockchain/receive_block_test.go
Co-authored-by: terence <terence@prysmaticlabs.com >
---------
Co-authored-by: terence <terence@prysmaticlabs.com >
2024-02-28 10:46:52 +00:00
terence
5a66807989
Update to V5 ( #13622 )
...
* First take at updating everything to v5
* Patch gRPC gateway to use prysm v5
Fix patch
* Update go ssz
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com >
2024-02-15 05:46:47 +00:00
Aditya Asgaonkar
6a605e6b6d
Fork choice filter changes ( #13464 )
...
* implement confirmation rule prerequisite - f.c. filter changes
* update tests
* update WORKSPACE for spec v1.4.0-beta.6
* run bazel gazelle
* Fix consensus_spec sha256
* drift also forkchoice time when drifting the service on tests
* update minimal kzg_commitment_inclusion_proof_depth.size
* fix mock engine client
* remove unnecessary helper & revert test changes
* revert change of proof size in minimal preset
* fix tests
* fix loader test
---------
Co-authored-by: terence tsao <terence@prysmaticlabs.com >
Co-authored-by: Potuz <potuz@prysmaticlabs.com >
2024-02-09 17:01:44 +00:00
Radosław Kapka
c996109b3a
Return payload value in Wei from /eth/v3/validator/blocks ( #13497 )
...
* Add value in Wei to execution payload
* simplify how payload is returned
* test fix
* fix issues
* review
* fix block handlers
2024-01-24 20:58:35 +00:00
Justin Traglia
703cfc5819
Initialize exec payload fields and enforce order ( #13372 )
...
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com >
2024-01-09 21:49:35 +00:00
kasey
0e043d55b4
VerifiedROBlobs in initial-sync ( #13351 )
...
* Use VerifiedROBlobs in initial-sync
* Update beacon-chain/das/cache.go
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com >
* Apply suggestions from code review
comment fixes
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com >
* fix lint error from gh web ui
* deepsource fixes
* more deepsource
* fix init wiring
* mark blobless blocks verified in batch mode
* move sig check after parent checks
* validate block commitment length at start of da check
* remove vestigial locking
* rm more copy-locksta
* rm old comment
* fail the entire batch if any sidecar fails
* lint
* skip redundant checks, fix len check
* assume sig and proposer checks passed for block
* inherits most checks from processed block
* Assume block processing handles most checks
* lint
* cleanup unused call and gaz
* more detailed logging for e2e
* fix bad refactor breaking non-finalized init-sync
* self-review cleanup
* gaz
* Update beacon-chain/verification/blob.go
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com >
* terence and justin feedback
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com >
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com >
2024-01-06 23:47:09 +00:00
Potuz
67dccc5e43
Break out several helpers from postBlockProcess ( #13419 )
...
* Break out several helpers from `postBlockProcess`
In addition fix a bug found by @terencechain where we should use a slot
context instead of the parent context in the second FCU call.
* Remove calls for tracked proposer
getPayloadAttribute already takes care of this
Also compute correctly the time into voting window
* call with attributes only when incoming block is canonical
* check for empty payload instead of only nil
* add unit tests
* move log for non-canonical block
* return early if the incoming block does not change head
* Pass fcuArgs as arguments
* lint
2024-01-06 02:29:07 +00:00
