mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-11 08:28:10 -05:00
2fd6bd8150
* Ran gopls modernize to fix everything go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./... * Override rules_go provided dependency for golang.org/x/tools to v0.38.0. To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches. * Fix buildtag violations and ignore buildtag violations in external * Introduce modernize analyzer package. * Add modernize "any" analyzer. * Fix violations of any analyzer * Add modernize "appendclipped" analyzer. * Fix violations of appendclipped * Add modernize "bloop" analyzer. * Add modernize "fmtappendf" analyzer. * Add modernize "forvar" analyzer. * Add modernize "mapsloop" analyzer. * Add modernize "minmax" analyzer. * Fix violations of minmax analyzer * Add modernize "omitzero" analyzer. * Add modernize "rangeint" analyzer. * Fix violations of rangeint. * Add modernize "reflecttypefor" analyzer. * Fix violations of reflecttypefor analyzer. * Add modernize "slicescontains" analyzer. * Add modernize "slicessort" analyzer. * Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686. * Add modernize "stringscutprefix" analyzer. * Add modernize "stringsbuilder" analyzer. * Fix violations of stringsbuilder analyzer. * Add modernize "stringsseq" analyzer. * Add modernize "testingcontext" analyzer. * Add modernize "waitgroup" analyzer. * Changelog fragment * gofmt * gazelle * Add modernize "newexpr" analyzer. * Disable newexpr until go1.26 * Add more details in WORKSPACE on how to update the override * @nalepae feedback on min() * gofmt * Fix violations of forvar
87 lines
2.5 KiB
Go
87 lines
2.5 KiB
Go
package flags
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/OffchainLabs/prysm/v7/cmd"
|
|
"github.com/OffchainLabs/prysm/v7/testing/require"
|
|
"github.com/urfave/cli/v2"
|
|
)
|
|
|
|
func TestLoadFlagsFromConfig_PreProcessing_Web3signer(t *testing.T) {
|
|
app := cli.App{}
|
|
set := flag.NewFlagSet("test", 0)
|
|
context := cli.NewContext(&app, set, nil)
|
|
|
|
pubkey1 := "0xbd36226746676565cd40141a7f0fe1445b9a3fbeb222288b226392c4b230ed0b"
|
|
pubkey2 := "0xbd36226746676565cd40141a7f0fe1445b9a3fbeb222288b226392c4b230ed0a"
|
|
|
|
require.NoError(t, os.WriteFile("flags_test.yaml", fmt.Appendf(nil, "%s:\n - %s\n - %s\n", Web3SignerPublicValidatorKeysFlag.Name,
|
|
pubkey1,
|
|
pubkey2), 0666))
|
|
|
|
require.NoError(t, set.Parse([]string{"test-command", "--" + cmd.ConfigFileFlag.Name, "flags_test.yaml"}))
|
|
comFlags := cmd.WrapFlags([]cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: cmd.ConfigFileFlag.Name,
|
|
},
|
|
&cli.StringSliceFlag{
|
|
Name: Web3SignerPublicValidatorKeysFlag.Name,
|
|
},
|
|
})
|
|
command := &cli.Command{
|
|
Name: "test-command",
|
|
Flags: comFlags,
|
|
Before: func(cliCtx *cli.Context) error {
|
|
return cmd.LoadFlagsFromConfig(cliCtx, comFlags)
|
|
},
|
|
Action: func(cliCtx *cli.Context) error {
|
|
require.Equal(t, true, cliCtx.IsSet(Web3SignerPublicValidatorKeysFlag.Name))
|
|
|
|
require.Equal(t, strings.Join([]string{pubkey1, pubkey2}, ","),
|
|
strings.Join(cliCtx.StringSlice(Web3SignerPublicValidatorKeysFlag.Name), ","))
|
|
return nil
|
|
},
|
|
}
|
|
require.NoError(t, command.Run(context, context.Args().Slice()...))
|
|
require.NoError(t, os.Remove("flags_test.yaml"))
|
|
}
|
|
|
|
func TestLoadFlagsFromConfig_EnableBuilderHasDefaultValue(t *testing.T) {
|
|
app := cli.App{}
|
|
set := flag.NewFlagSet("test", 0)
|
|
context := cli.NewContext(&app, set, nil)
|
|
|
|
require.NoError(t, os.WriteFile("flags_test.yaml", []byte("---\nenable-builder: true"), 0666))
|
|
|
|
require.NoError(t, set.Parse([]string{"test-command", "--" + cmd.ConfigFileFlag.Name, "flags_test.yaml"}))
|
|
comFlags := cmd.WrapFlags([]cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: cmd.ConfigFileFlag.Name,
|
|
},
|
|
&cli.BoolFlag{
|
|
Name: EnableBuilderFlag.Name,
|
|
Value: false,
|
|
},
|
|
})
|
|
command := &cli.Command{
|
|
Name: "test-command",
|
|
Flags: comFlags,
|
|
Before: func(cliCtx *cli.Context) error {
|
|
return cmd.LoadFlagsFromConfig(cliCtx, comFlags)
|
|
},
|
|
Action: func(cliCtx *cli.Context) error {
|
|
|
|
require.Equal(t, true,
|
|
cliCtx.Bool(EnableBuilderFlag.Name))
|
|
return nil
|
|
},
|
|
}
|
|
require.NoError(t, command.Run(context, context.Args().Slice()...))
|
|
require.NoError(t, os.Remove("flags_test.yaml"))
|
|
}
|