Files
prysm/tools/nogo_config/main.go
Preston Van Loon 2fd6bd8150 Add golang.org/x/tools modernize static analyzer and fix violations (#15946)
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
2025-11-14 01:27:22 +00:00

95 lines
1.8 KiB
Go

package main
import (
"encoding/json"
"flag"
"fmt"
"io"
"os"
"strings"
)
const exclusionMessage = "Excluded by @prysm//tools/nogo_config tool"
var (
defaultExclusions = []string{
"external/.*",
}
)
var (
input = flag.String("input", "", "(required) input file")
output = flag.String("output", "", "(required) output file")
checks = flag.String("checks", "", "(required) comma separated list of checks to exclude")
exclusions = flag.String("exclude_files", strings.Join(defaultExclusions, ","), "exclusions file")
silent = flag.Bool("silent", false, "disable logging")
)
func main() {
flag.Parse()
if *input == "" || *output == "" {
fmt.Println("Error: input and output must be specified. Review the help text.")
flag.Usage()
return
}
if *checks == "" {
fmt.Println("Error: checks must be specified. Review the help text.")
flag.Usage()
return
}
e := defaultExclusions
if *exclusions != "" {
e = strings.Split(*exclusions, ",")
}
f, err := os.Open(*input)
if err != nil {
fmt.Printf("Error: %v\n", err)
return
}
defer func() {
err := f.Close()
if err != nil {
panic(err)
}
}()
data, err := io.ReadAll(f)
if err != nil {
fmt.Printf("Error: %v\n", err)
return
}
var c Configs
if err := json.Unmarshal(data, &c); err != nil {
fmt.Printf("Error: %v\n", err)
return
}
for check := range strings.SplitSeq(*checks, ",") {
c.AddExclusion(strings.TrimSpace(check), e)
}
out, err := os.Create(*output)
if err != nil {
fmt.Printf("Error: %v\n", err)
return
}
defer func() {
err := out.Close()
if err != nil {
panic(err)
}
}()
if err := json.NewEncoder(out).Encode(c); err != nil {
fmt.Printf("Error: %v\n", err)
return
}
if !*silent {
fmt.Printf("Wrote %v\n", *output)
}
}