mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-08 07:03:58 -05:00
* Ran gopls modernize to fix everything go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./... * Override rules_go provided dependency for golang.org/x/tools to v0.38.0. To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches. * Fix buildtag violations and ignore buildtag violations in external * Introduce modernize analyzer package. * Add modernize "any" analyzer. * Fix violations of any analyzer * Add modernize "appendclipped" analyzer. * Fix violations of appendclipped * Add modernize "bloop" analyzer. * Add modernize "fmtappendf" analyzer. * Add modernize "forvar" analyzer. * Add modernize "mapsloop" analyzer. * Add modernize "minmax" analyzer. * Fix violations of minmax analyzer * Add modernize "omitzero" analyzer. * Add modernize "rangeint" analyzer. * Fix violations of rangeint. * Add modernize "reflecttypefor" analyzer. * Fix violations of reflecttypefor analyzer. * Add modernize "slicescontains" analyzer. * Add modernize "slicessort" analyzer. * Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686. * Add modernize "stringscutprefix" analyzer. * Add modernize "stringsbuilder" analyzer. * Fix violations of stringsbuilder analyzer. * Add modernize "stringsseq" analyzer. * Add modernize "testingcontext" analyzer. * Add modernize "waitgroup" analyzer. * Changelog fragment * gofmt * gazelle * Add modernize "newexpr" analyzer. * Disable newexpr until go1.26 * Add more details in WORKSPACE on how to update the override * @nalepae feedback on min() * gofmt * Fix violations of forvar
236 lines
7.8 KiB
Go
236 lines
7.8 KiB
Go
package rpc
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/OffchainLabs/prysm/v7/testing/require"
|
|
"github.com/OffchainLabs/prysm/v7/validator/accounts"
|
|
"github.com/OffchainLabs/prysm/v7/validator/db/common"
|
|
"github.com/OffchainLabs/prysm/v7/validator/db/filesystem"
|
|
"github.com/OffchainLabs/prysm/v7/validator/db/iface"
|
|
"github.com/OffchainLabs/prysm/v7/validator/db/kv"
|
|
"github.com/OffchainLabs/prysm/v7/validator/keymanager"
|
|
"github.com/OffchainLabs/prysm/v7/validator/slashing-protection-history/format"
|
|
mocks "github.com/OffchainLabs/prysm/v7/validator/testing"
|
|
)
|
|
|
|
func TestImportSlashingProtection_Preconditions(t *testing.T) {
|
|
for _, isSlashingProtectionMinimal := range []bool{false, true} {
|
|
t.Run(fmt.Sprintf("slashing protection minimal: %v", isSlashingProtectionMinimal), func(t *testing.T) {
|
|
ctx := t.Context()
|
|
localWalletDir := setupWalletDir(t)
|
|
defaultWalletPath = localWalletDir
|
|
|
|
// Empty JSON.
|
|
s := &Server{
|
|
walletDir: defaultWalletPath,
|
|
}
|
|
|
|
request := &ImportSlashingProtectionRequest{
|
|
SlashingProtectionJson: "",
|
|
}
|
|
var buf bytes.Buffer
|
|
err := json.NewEncoder(&buf).Encode(request)
|
|
require.NoError(t, err)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/v2/validator/slashing-protection/import", &buf)
|
|
wr := httptest.NewRecorder()
|
|
wr.Body = &bytes.Buffer{}
|
|
// No validator DB provided.
|
|
s.ImportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusInternalServerError, wr.Code)
|
|
require.StringContains(t, "could not find validator database", wr.Body.String())
|
|
|
|
// Create Wallet and add to server for more realistic testing.
|
|
opts := []accounts.Option{
|
|
accounts.WithWalletDir(defaultWalletPath),
|
|
accounts.WithKeymanagerType(keymanager.Local),
|
|
accounts.WithWalletPassword(strongPass),
|
|
accounts.WithSkipMnemonicConfirm(true),
|
|
}
|
|
acc, err := accounts.NewCLIManager(opts...)
|
|
require.NoError(t, err)
|
|
w, err := acc.WalletCreate(ctx)
|
|
require.NoError(t, err)
|
|
s.wallet = w
|
|
|
|
numValidators := 1
|
|
// Create public keys for the mock validator DB.
|
|
pubKeys, err := mocks.CreateRandomPubKeys(numValidators)
|
|
require.NoError(t, err)
|
|
|
|
// Create a validator database.
|
|
var validatorDB iface.ValidatorDB
|
|
if isSlashingProtectionMinimal {
|
|
validatorDB, err = filesystem.NewStore(defaultWalletPath, &filesystem.Config{
|
|
PubKeys: pubKeys,
|
|
})
|
|
} else {
|
|
validatorDB, err = kv.NewKVStore(ctx, defaultWalletPath, &kv.Config{
|
|
PubKeys: pubKeys,
|
|
})
|
|
}
|
|
require.NoError(t, err)
|
|
s.db = validatorDB
|
|
|
|
// Have to close it after import is done otherwise it complains db is not open.
|
|
defer func() {
|
|
require.NoError(t, validatorDB.Close())
|
|
}()
|
|
|
|
// Test empty JSON.
|
|
wr = httptest.NewRecorder()
|
|
wr.Body = &bytes.Buffer{}
|
|
s.ImportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusBadRequest, wr.Code)
|
|
require.StringContains(t, "empty slashing_protection_json specified", wr.Body.String())
|
|
|
|
// Generate mock slashing history.
|
|
attestingHistory := make([][]*common.AttestationRecord, 0)
|
|
proposalHistory := make([]common.ProposalHistoryForPubkey, len(pubKeys))
|
|
for i := range pubKeys {
|
|
proposalHistory[i].Proposals = make([]common.Proposal, 0)
|
|
}
|
|
mockJSON, err := mocks.MockSlashingProtectionJSON(pubKeys, attestingHistory, proposalHistory)
|
|
require.NoError(t, err)
|
|
|
|
// JSON encode the protection JSON and save it in rpc req.
|
|
encoded, err := json.Marshal(mockJSON)
|
|
require.NoError(t, err)
|
|
request.SlashingProtectionJson = string(encoded)
|
|
err = json.NewEncoder(&buf).Encode(request)
|
|
require.NoError(t, err)
|
|
|
|
req = httptest.NewRequest(http.MethodPost, "/v2/validator/slashing-protection/import", &buf)
|
|
wr = httptest.NewRecorder()
|
|
wr.Body = &bytes.Buffer{}
|
|
s.ImportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusOK, wr.Code)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestExportSlashingProtection_Preconditions(t *testing.T) {
|
|
for _, isSlashingProtectionMinimal := range []bool{false, true} {
|
|
t.Run(fmt.Sprintf("slashing protection minimal: %v", isSlashingProtectionMinimal), func(t *testing.T) {
|
|
ctx := t.Context()
|
|
localWalletDir := setupWalletDir(t)
|
|
defaultWalletPath = localWalletDir
|
|
|
|
s := &Server{
|
|
walletDir: defaultWalletPath,
|
|
}
|
|
req := httptest.NewRequest(http.MethodGet, "/v2/validator/slashing-protection/export", nil)
|
|
wr := httptest.NewRecorder()
|
|
wr.Body = &bytes.Buffer{}
|
|
// No validator DB provided.
|
|
s.ExportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusInternalServerError, wr.Code)
|
|
require.StringContains(t, "could not find validator database", wr.Body.String())
|
|
|
|
numValidators := 10
|
|
// Create public keys for the mock validator DB.
|
|
pubKeys, err := mocks.CreateRandomPubKeys(numValidators)
|
|
require.NoError(t, err)
|
|
|
|
// We create a validator database.
|
|
var validatorDB iface.ValidatorDB
|
|
if isSlashingProtectionMinimal {
|
|
validatorDB, err = filesystem.NewStore(t.TempDir(), &filesystem.Config{
|
|
PubKeys: pubKeys,
|
|
})
|
|
} else {
|
|
validatorDB, err = kv.NewKVStore(t.Context(), t.TempDir(), &kv.Config{
|
|
PubKeys: pubKeys,
|
|
})
|
|
}
|
|
require.NoError(t, err)
|
|
s.db = validatorDB
|
|
|
|
// Have to close it after export is done otherwise it complains db is not open.
|
|
defer func() {
|
|
require.NoError(t, validatorDB.Close())
|
|
}()
|
|
genesisValidatorsRoot := [32]byte{1}
|
|
err = validatorDB.SaveGenesisValidatorsRoot(ctx, genesisValidatorsRoot[:])
|
|
require.NoError(t, err)
|
|
wr = httptest.NewRecorder()
|
|
wr.Body = &bytes.Buffer{}
|
|
s.ExportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusOK, wr.Code)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestImportExportSlashingProtection_RoundTrip(t *testing.T) {
|
|
// Round trip is only suitable with complete slashing protection, since
|
|
// minimal slashing protections only keep latest attestation and proposal.
|
|
ctx := t.Context()
|
|
localWalletDir := setupWalletDir(t)
|
|
defaultWalletPath = localWalletDir
|
|
|
|
s := &Server{
|
|
walletDir: defaultWalletPath,
|
|
}
|
|
|
|
numValidators := 10
|
|
// Create public keys for the mock validator DB.
|
|
pubKeys, err := mocks.CreateRandomPubKeys(numValidators)
|
|
require.NoError(t, err)
|
|
|
|
// Create a validator database.
|
|
validatorDB, err := kv.NewKVStore(ctx, defaultWalletPath, &kv.Config{
|
|
PubKeys: pubKeys,
|
|
})
|
|
require.NoError(t, err)
|
|
s.db = validatorDB
|
|
|
|
// Have to close it after import is done otherwise it complains db is not open.
|
|
defer func() {
|
|
require.NoError(t, validatorDB.Close())
|
|
}()
|
|
|
|
// Generate mock slashing history.
|
|
attestingHistory := make([][]*common.AttestationRecord, 0)
|
|
proposalHistory := make([]common.ProposalHistoryForPubkey, len(pubKeys))
|
|
for i := range pubKeys {
|
|
proposalHistory[i].Proposals = make([]common.Proposal, 0)
|
|
}
|
|
mockJSON, err := mocks.MockSlashingProtectionJSON(pubKeys, attestingHistory, proposalHistory)
|
|
require.NoError(t, err)
|
|
|
|
// JSON encode the protection JSON and save it in rpc req.
|
|
encoded, err := json.Marshal(mockJSON)
|
|
require.NoError(t, err)
|
|
request := &ImportSlashingProtectionRequest{
|
|
SlashingProtectionJson: string(encoded),
|
|
}
|
|
var buf bytes.Buffer
|
|
err = json.NewEncoder(&buf).Encode(request)
|
|
require.NoError(t, err)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/v2/validator/slashing-protection/import", &buf)
|
|
wr := httptest.NewRecorder()
|
|
s.ImportSlashingProtection(wr, req)
|
|
|
|
req = httptest.NewRequest(http.MethodGet, "/v2/validator/slashing-protection/export", nil)
|
|
wr = httptest.NewRecorder()
|
|
s.ExportSlashingProtection(wr, req)
|
|
require.Equal(t, http.StatusOK, wr.Code)
|
|
resp := &ExportSlashingProtectionResponse{}
|
|
require.NoError(t, json.Unmarshal(wr.Body.Bytes(), resp))
|
|
// Attempt to read the exported data and convert from string to EIP-3076.
|
|
enc := []byte(resp.File)
|
|
|
|
receivedJSON := &format.EIPSlashingProtectionFormat{}
|
|
err = json.Unmarshal(enc, receivedJSON)
|
|
require.NoError(t, err)
|
|
|
|
require.DeepEqual(t, mockJSON.Metadata, receivedJSON.Metadata)
|
|
}
|