Files
prysm/beacon-chain/sync/slot_aware_cache.go
Preston Van Loon 2fd6bd8150 Add golang.org/x/tools modernize static analyzer and fix violations (#15946)
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
2025-11-14 01:27:22 +00:00

92 lines
2.3 KiB
Go

package sync
import (
"slices"
"sync"
"github.com/OffchainLabs/prysm/v7/consensus-types/primitives"
lru "github.com/hashicorp/golang-lru"
)
const maxSlots = 1000 // Maximum number of slots to track before pruning oldest
// slotAwareCache is a cache that tracks which keys belong to which slot
// to enable slot-based pruning when blocks are finalized.
type slotAwareCache struct {
cache *lru.Cache
slotToKeys map[primitives.Slot][]string
mu sync.RWMutex
}
// newSlotAwareCache creates a new slot-aware cache with the given size.
func newSlotAwareCache(size int) *slotAwareCache {
cache, _ := lru.New(size)
return &slotAwareCache{
cache: cache,
slotToKeys: make(map[primitives.Slot][]string),
}
}
// Get retrieves a value from the cache.
func (c *slotAwareCache) Get(key string) (any, bool) {
c.mu.RLock()
defer c.mu.RUnlock()
return c.cache.Get(key)
}
// Add adds a value to the cache associated with a specific slot.
func (c *slotAwareCache) Add(slot primitives.Slot, key string, value any) {
c.mu.Lock()
defer c.mu.Unlock()
// Add to cache
c.cache.Add(key, value)
// Track slot association
c.slotToKeys[slot] = append(c.slotToKeys[slot], key)
c.pruneOldestSlots()
}
// pruneSlotsBefore removes all entries with slots less than the given slot.
// This should be called when a new finalized checkpoint is reached.
func (c *slotAwareCache) pruneSlotsBefore(finalizedSlot primitives.Slot) int {
c.mu.Lock()
defer c.mu.Unlock()
pruned := 0
for slot, keys := range c.slotToKeys {
if slot < finalizedSlot {
for _, key := range keys {
c.cache.Remove(key)
pruned++
}
delete(c.slotToKeys, slot)
}
}
return pruned
}
// pruneOldestSlots removes the oldest slots when we exceed maxSlots.
// This ensures bounded memory usage even during long finalization delays.
// Note: This function assumes the mutex is already held.
func (c *slotAwareCache) pruneOldestSlots() {
if len(c.slotToKeys) <= maxSlots {
return
}
// Get all slots and sort them to find the oldest
slots := make([]primitives.Slot, 0, len(c.slotToKeys))
for slot := range c.slotToKeys {
slots = append(slots, slot)
}
slices.Sort(slots)
// Remove oldest slots until we're back under the limit
slotsToRemove := len(c.slotToKeys) - maxSlots
for i := range slotsToRemove {
slot := slots[i]
delete(c.slotToKeys, slot)
}
}