Files
prysm/beacon-chain/execution/block_cache.go
Preston Van Loon 2fd6bd8150 Add golang.org/x/tools modernize static analyzer and fix violations (#15946)
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
2025-11-14 01:27:22 +00:00

170 lines
4.7 KiB
Go

package execution
import (
"errors"
"math/big"
"sync"
"github.com/OffchainLabs/prysm/v7/beacon-chain/execution/types"
"github.com/OffchainLabs/prysm/v7/config/params"
"github.com/ethereum/go-ethereum/common"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"
"k8s.io/client-go/tools/cache"
)
var (
// ErrNotAHeaderInfo will be returned when a cache object is not a pointer to
// a headerInfo struct.
ErrNotAHeaderInfo = errors.New("object is not a header info")
// maxCacheSize is 2x of the follow distance for additional cache padding.
// Requests should be only accessing blocks within recent blocks within the
// Eth1FollowDistance.
maxCacheSize = 2 * params.BeaconConfig().Eth1FollowDistance
// Metrics
headerCacheMiss = promauto.NewCounter(prometheus.CounterOpts{
Name: "powchain_header_cache_miss",
Help: "The number of header requests that aren't present in the cache.",
})
headerCacheHit = promauto.NewCounter(prometheus.CounterOpts{
Name: "powchain_header_cache_hit",
Help: "The number of header requests that are present in the cache.",
})
headerCacheSize = promauto.NewGauge(prometheus.GaugeOpts{
Name: "powchain_header_cache_size",
Help: "The number of headers in the header cache",
})
)
// hashKeyFn takes the hex string representation as the key for a headerInfo.
func hashKeyFn(obj any) (string, error) {
hInfo, ok := obj.(*types.HeaderInfo)
if !ok {
return "", ErrNotAHeaderInfo
}
return hInfo.Hash.Hex(), nil
}
// heightKeyFn takes the string representation of the block header number as the key
// for a headerInfo.
func heightKeyFn(obj any) (string, error) {
hInfo, ok := obj.(*types.HeaderInfo)
if !ok {
return "", ErrNotAHeaderInfo
}
return hInfo.Number.String(), nil
}
// headerCache struct with two queues for looking up by hash or by block height.
type headerCache struct {
hashCache *cache.FIFO
heightCache *cache.FIFO
lock sync.RWMutex
}
// newHeaderCache creates a new block cache for storing/accessing headerInfo from
// memory.
func newHeaderCache() *headerCache {
return &headerCache{
hashCache: cache.NewFIFO(hashKeyFn),
heightCache: cache.NewFIFO(heightKeyFn),
}
}
// HeaderInfoByHash fetches headerInfo by its header hash. Returns true with a
// reference to the header info, if exists. Otherwise returns false, nil.
func (c *headerCache) HeaderInfoByHash(hash common.Hash) (bool, *types.HeaderInfo, error) {
c.lock.RLock()
defer c.lock.RUnlock()
obj, exists, err := c.hashCache.GetByKey(hash.Hex())
if err != nil {
return false, nil, err
}
if exists {
headerCacheHit.Inc()
} else {
headerCacheMiss.Inc()
return false, nil, nil
}
hInfo, ok := obj.(*types.HeaderInfo)
if !ok {
return false, nil, ErrNotAHeaderInfo
}
return true, hInfo.Copy(), nil
}
// HeaderInfoByHeight fetches headerInfo by its header number. Returns true with a
// reference to the header info, if exists. Otherwise returns false, nil.
func (c *headerCache) HeaderInfoByHeight(height *big.Int) (bool, *types.HeaderInfo, error) {
c.lock.RLock()
defer c.lock.RUnlock()
obj, exists, err := c.heightCache.GetByKey(height.String())
if err != nil {
return false, nil, err
}
if exists {
headerCacheHit.Inc()
} else {
headerCacheMiss.Inc()
return false, nil, nil
}
hInfo, ok := obj.(*types.HeaderInfo)
if !ok {
return false, nil, ErrNotAHeaderInfo
}
return exists, hInfo.Copy(), nil
}
// AddHeader adds a headerInfo object to the cache. This method also trims the
// least recently added header info if the cache size has reached the max cache
// size limit. This method should be called in sequential header number order if
// the desired behavior is that the blocks with the highest header number should
// be present in the cache.
func (c *headerCache) AddHeader(hdr *types.HeaderInfo) error {
c.lock.Lock()
defer c.lock.Unlock()
hInfo := hdr.Copy()
if err := c.hashCache.AddIfNotPresent(hInfo); err != nil {
return err
}
if err := c.heightCache.AddIfNotPresent(hInfo); err != nil {
return err
}
trim(c.hashCache, maxCacheSize)
trim(c.heightCache, maxCacheSize)
headerCacheSize.Set(float64(len(c.hashCache.ListKeys())))
return nil
}
// trim the FIFO queue to the maxSize.
func trim(queue *cache.FIFO, maxSize uint64) {
for s := uint64(len(queue.ListKeys())); s > maxSize; s-- {
// #nosec G104 popProcessNoopFunc never returns an error
if _, err := queue.Pop(popProcessNoopFunc); err != nil { // This never returns an error, but we'll handle anyway for sanity.
panic(err) // lint:nopanic -- popProcessNoopFunc never returns an error.
}
}
}
// popProcessNoopFunc is a no-op function that never returns an error.
func popProcessNoopFunc(_ any, _ bool) error {
return nil
}