mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-08 23:18:15 -05:00
* `EpochFromString`: Use already defined `Uint64FromString` function.
* `Test_uint64FromString` => `Test_FromString`
This test function tests more functions than `Uint64FromString`.
* Slashing protection history: Remove unreachable code.
The function `NewKVStore` creates, via `kv.UpdatePublicKeysBuckets`,
a new item in the `proposal-history-bucket-interchange`.
IMO there is no real reason to prefer `proposal` than `attestation`
as a prefix for this bucket, but this is the way it is done right now
and renaming the bucket will probably be backward incompatible.
An `attestedPublicKey` cannot exist without
the corresponding `proposedPublicKey`.
Thus, the `else` portion of code removed in this commit is not reachable.
We raise an error if we get there.
This is also probably the reason why the removed `else` portion was not
tested.
* `NewKVStore`: Switch items in `createBuckets`.
So the order corresponds to `schema.go`
* `slashableAttestationCheck`: Fix comments and logs.
* `ValidatorClient.db`: Use `iface.ValidatorDB`.
* BoltDB database: Implement `GraffitiFileHash`.
* Filesystem database: Creates `db.go`.
This file defines the following structs:
- `Store`
- `Graffiti`
- `Configuration`
- `ValidatorSlashingProtection`
This files implements the following public functions:
- `NewStore`
- `Close`
- `Backup`
- `DatabasePath`
- `ClearDB`
- `UpdatePublicKeysBuckets`
This files implements the following private functions:
- `slashingProtectionDirPath`
- `configurationFilePath`
- `configuration`
- `saveConfiguration`
- `validatorSlashingProtection`
- `saveValidatorSlashingProtection`
- `publicKeys`
* Filesystem database: Creates `genesis.go`.
This file defines the following public functions:
- `GenesisValidatorsRoot`
- `SaveGenesisValidatorsRoot`
* Filesystem database: Creates `graffiti.go`.
This file defines the following public functions:
- `SaveGraffitiOrderedIndex`
- `GraffitiOrderedIndex`
* Filesystem database: Creates `migration.go`.
This file defines the following public functions:
- `RunUpMigrations`
- `RunDownMigrations`
* Filesystem database: Creates proposer_settings.go.
This file defines the following public functions:
- `ProposerSettings`
- `ProposerSettingsExists`
- `SaveProposerSettings`
* Filesystem database: Creates `attester_protection.go`.
This file defines the following public functions:
- `EIPImportBlacklistedPublicKeys`
- `SaveEIPImportBlacklistedPublicKeys`
- `SigningRootAtTargetEpoch`
- `LowestSignedTargetEpoch`
- `LowestSignedSourceEpoch`
- `AttestedPublicKeys`
- `CheckSlashableAttestation`
- `SaveAttestationForPubKey`
- `SaveAttestationsForPubKey`
- `AttestationHistoryForPubKey`
* Filesystem database: Creates `proposer_protection.go`.
This file defines the following public functions:
- `HighestSignedProposal`
- `LowestSignedProposal`
- `ProposalHistoryForPubKey`
- `ProposalHistoryForSlot`
- `ProposedPublicKeys`
* Ensure that the filesystem store implements the `ValidatorDB` interface.
* `slashableAttestationCheck`: Check the database type.
* `slashableProposalCheck`: Check the database type.
* `slashableAttestationCheck`: Allow usage of minimal slashing protection.
* `slashableProposalCheck`: Allow usage of minimal slashing protection.
* `ImportStandardProtectionJSON`: Check the database type.
* `ImportStandardProtectionJSON`: Allow usage of min slashing protection.
* Implement `RecursiveDirFind`.
* Implement minimal<->complete DB conversion.
3 public functions are implemented:
- `IsCompleteDatabaseExisting`
- `IsMinimalDatabaseExisting`
- `ConvertDatabase`
* `setupDB`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/node/node_test.go`.
The rest of this commit consists in minimal slashing protection testing.
* `setupWithKey`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/client/propose_test.go`.
The rest of this commit consists in tests wrapping.
* `setup`: Add `isSlashingProtectionMinimal` argument.
The added feature is located in the `validator/client/propose_test.go`
file.
The rest of this commit consists in tests wrapping.
* `initializeFromCLI` and `initializeForWeb`: Factorize db init.
* Add `convert-complete-to-minimal` command.
* Creates `--enable-minimal-slashing-protection` flag.
* `importSlashingProtectionJSON`: Check database type.
* `exportSlashingProtectionJSON`: Check database type.
* `TestClearDB`: Test with minimal slashing protection.
* KeyManager: Test with minimal slashing protection.
* RPC: KeyManager: Test with minimal slashing protection.
* `convert-complete-to-minimal`: Change option names.
Options were:
- `--source` (for source data directory), and
- `--target` (for target data directory)
However, since this command deals with slashing protection, which has
source (epochs) and target (epochs), the initial option names may confuse
the user.
In this commit:
`--source` ==> `--source-data-dir`
`--target` ==> `--target-data-dir`
* Set `SlashableAttestationCheck` as an iface method.
And delete `CheckSlashableAttestation` from iface.
* Move helpers functions in a more general directory.
No functional change.
* Extract common structs out of `kv`.
==> `filesystem` does not depend anymore on `kv`.
==> `iface` does not depend anymore on `kv`.
==> `slashing-protection` does not depend anymore on `kv`.
* Move `ValidateMetadata` in `validator/helpers`.
* `ValidateMetadata`: Test with mock.
This way, we can:
- Avoid any circular import for tests.
- Implement once for all `iface.ValidatorDB` implementations
the `ValidateMetadata`function.
- Have tests (and coverage) of `ValidateMetadata`in
its own package.
The ideal solution would have been to implement `ValidateMetadata` as
a method with the `iface.ValidatorDB`receiver.
Unfortunately, golang does not allow that.
* `iface.ValidatorDB`: Implement ImportStandardProtectionJSON.
The whole purpose of this commit is to avoid the `switch validatorDB.(type)`
in `ImportStandardProtectionJSON`.
* `iface.ValidatorDB`: Implement `SlashableProposalCheck`.
* Remove now useless `slashableProposalCheck`.
* Delete useless `ImportStandardProtectionJSON`.
* `file.Exists`: Detect directories and return an error.
Before, `Exists` was only able to detect if a file exists.
Now, this function takes an extra `File` or `Directory` argument.
It detects either if a file or a directory exists.
Before, if an error was returned by `os.Stat`, the the file was
considered as non existing.
Now, it is treated as a real error.
* Replace `os.Stat` by `file.Exists`.
* Remove `Is{Complete,Minimal}DatabaseExisting`.
* `publicKeys`: Add log if unexpected file found.
* Move `{Source,Target}DataDirFlag`in `db.go`.
* `failedAttLocalProtectionErr`: `var`==> `const`
* `signingRoot`: `32`==> `fieldparams.RootLength`.
* `validatorClientData`==> `validator-client-data`.
To be consistent with `slashing-protection`.
* Add progress bars for `import` and `convert`.
* `parseBlocksForUniquePublicKeys`: Move in `db/kv`.
* helpers: Remove unused `initializeProgressBar` function.
216 lines
6.6 KiB
Go
216 lines
6.6 KiB
Go
// Package kv defines a persistent backend for the validator service.
|
|
package kv
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
prombolt "github.com/prysmaticlabs/prombbolt"
|
|
"github.com/prysmaticlabs/prysm/v5/async/abool"
|
|
"github.com/prysmaticlabs/prysm/v5/async/event"
|
|
"github.com/prysmaticlabs/prysm/v5/config/features"
|
|
fieldparams "github.com/prysmaticlabs/prysm/v5/config/fieldparams"
|
|
"github.com/prysmaticlabs/prysm/v5/config/params"
|
|
"github.com/prysmaticlabs/prysm/v5/io/file"
|
|
"github.com/prysmaticlabs/prysm/v5/validator/db/iface"
|
|
bolt "go.etcd.io/bbolt"
|
|
)
|
|
|
|
const (
|
|
// Number of attestation records we can hold in memory
|
|
// before we flush them to the database. Roughly corresponds
|
|
// to the max number of keys per validator client, but there is no
|
|
// detriment if there are more keys than this capacity, as attestations
|
|
// for those keys will simply be flushed at the next flush interval.
|
|
attestationBatchCapacity = 2048
|
|
// Time interval after which we flush attestation records to the database
|
|
// from a batch kept in memory for slashing protection.
|
|
attestationBatchWriteInterval = time.Millisecond * 100
|
|
// Specifies the initial mmap size of bolt.
|
|
mmapSize = 536870912
|
|
)
|
|
|
|
// ProtectionDbFileName Validator slashing protection db file name.
|
|
var (
|
|
ProtectionDbFileName = "validator.db"
|
|
)
|
|
|
|
// blockedBuckets represents the buckets that we want to restrict
|
|
// from our metrics fetching for performance reasons. For a detailed
|
|
// summary, it can be read in https://github.com/prysmaticlabs/prysm/issues/8274.
|
|
var blockedBuckets = [][]byte{
|
|
deprecatedAttestationHistoryBucket,
|
|
lowestSignedSourceBucket,
|
|
lowestSignedTargetBucket,
|
|
lowestSignedProposalsBucket,
|
|
highestSignedProposalsBucket,
|
|
pubKeysBucket,
|
|
attestationSigningRootsBucket,
|
|
attestationSourceEpochsBucket,
|
|
attestationTargetEpochsBucket,
|
|
}
|
|
|
|
// Config represents store's config object.
|
|
type Config struct {
|
|
PubKeys [][fieldparams.BLSPubkeyLength]byte
|
|
}
|
|
|
|
// Store defines an implementation of the Prysm Database interface
|
|
// using BoltDB as the underlying persistent kv-store for Ethereum consensus nodes.
|
|
type Store struct {
|
|
db *bolt.DB
|
|
databasePath string
|
|
batchedAttestations *QueuedAttestationRecords
|
|
batchedAttestationsChan chan *AttestationRecordSaveRequest
|
|
batchAttestationsFlushedFeed *event.Feed
|
|
batchedAttestationsFlushInProgress abool.AtomicBool
|
|
}
|
|
|
|
// Close closes the underlying boltdb database.
|
|
func (s *Store) Close() error {
|
|
prometheus.Unregister(createBoltCollector(s.db))
|
|
return s.db.Close()
|
|
}
|
|
|
|
func (s *Store) update(fn func(*bolt.Tx) error) error {
|
|
return s.db.Update(fn)
|
|
}
|
|
func (s *Store) view(fn func(*bolt.Tx) error) error {
|
|
return s.db.View(fn)
|
|
}
|
|
|
|
// ClearDB removes any previously stored data at the configured data directory.
|
|
func (s *Store) ClearDB() error {
|
|
if err := s.Close(); err != nil {
|
|
return fmt.Errorf("failed to close db: %w", err)
|
|
}
|
|
if _, err := os.Stat(s.databasePath); os.IsNotExist(err) {
|
|
return nil
|
|
}
|
|
return os.Remove(filepath.Join(s.databasePath, ProtectionDbFileName))
|
|
}
|
|
|
|
// DatabasePath at which this database writes files.
|
|
func (s *Store) DatabasePath() string {
|
|
return s.databasePath
|
|
}
|
|
|
|
func createBuckets(tx *bolt.Tx, buckets ...[]byte) error {
|
|
for _, bucket := range buckets {
|
|
if _, err := tx.CreateBucketIfNotExists(bucket); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Ensure the kv store implements the interface.
|
|
var _ = iface.ValidatorDB(&Store{})
|
|
|
|
// NewKVStore initializes a new boltDB key-value store at the directory
|
|
// path specified, creates the kv-buckets based on the schema, and stores
|
|
// an open connection db object as a property of the Store struct.
|
|
func NewKVStore(ctx context.Context, dirPath string, config *Config) (*Store, error) {
|
|
hasDir, err := file.HasDir(dirPath)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !hasDir {
|
|
if err := file.MkdirAll(dirPath); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
datafile := filepath.Join(dirPath, ProtectionDbFileName)
|
|
boltDB, err := bolt.Open(datafile, params.BeaconIoConfig().ReadWritePermissions, &bolt.Options{
|
|
Timeout: params.BeaconIoConfig().BoltTimeout,
|
|
InitialMmapSize: mmapSize,
|
|
})
|
|
if err != nil {
|
|
if errors.Is(err, bolt.ErrTimeout) {
|
|
return nil, errors.New("cannot obtain database lock, database may be in use by another process")
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
kv := &Store{
|
|
db: boltDB,
|
|
databasePath: dirPath,
|
|
batchedAttestations: NewQueuedAttestationRecords(),
|
|
batchedAttestationsChan: make(chan *AttestationRecordSaveRequest, attestationBatchCapacity),
|
|
batchAttestationsFlushedFeed: new(event.Feed),
|
|
}
|
|
|
|
if err := kv.db.Update(func(tx *bolt.Tx) error {
|
|
return createBuckets(
|
|
tx,
|
|
genesisInfoBucket,
|
|
historicProposalsBucket,
|
|
deprecatedAttestationHistoryBucket,
|
|
lowestSignedSourceBucket,
|
|
lowestSignedTargetBucket,
|
|
lowestSignedProposalsBucket,
|
|
highestSignedProposalsBucket,
|
|
slashablePublicKeysBucket,
|
|
pubKeysBucket,
|
|
migrationsBucket,
|
|
graffitiBucket,
|
|
proposerSettingsBucket,
|
|
)
|
|
}); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Initialize the required public keys into the DB to ensure they're not empty.
|
|
if config != nil {
|
|
if err := kv.UpdatePublicKeysBuckets(config.PubKeys); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
if features.Get().EnableSlashingProtectionPruning {
|
|
// Prune attesting records older than the current weak subjectivity period.
|
|
if err := kv.PruneAttestations(ctx); err != nil {
|
|
return nil, errors.Wrap(err, "could not prune old attestations from DB")
|
|
}
|
|
}
|
|
|
|
// Batch save attestation records for slashing protection at timed
|
|
// intervals to our database.
|
|
go kv.batchAttestationWrites(ctx)
|
|
|
|
return kv, prometheus.Register(createBoltCollector(kv.db))
|
|
}
|
|
|
|
// UpdatePublicKeysBuckets for a specified list of keys.
|
|
func (s *Store) UpdatePublicKeysBuckets(pubKeys [][fieldparams.BLSPubkeyLength]byte) error {
|
|
return s.update(func(tx *bolt.Tx) error {
|
|
bucket := tx.Bucket(historicProposalsBucket)
|
|
for _, pubKey := range pubKeys {
|
|
if _, err := bucket.CreateBucketIfNotExists(pubKey[:]); err != nil {
|
|
return errors.Wrap(err, "failed to create proposal history bucket")
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
}
|
|
|
|
// Size returns the db size in bytes.
|
|
func (s *Store) Size() (int64, error) {
|
|
var size int64
|
|
err := s.db.View(func(tx *bolt.Tx) error {
|
|
size = tx.Size()
|
|
return nil
|
|
})
|
|
return size, err
|
|
}
|
|
|
|
// createBoltCollector returns a prometheus collector specifically configured for boltdb.
|
|
func createBoltCollector(db *bolt.DB) prometheus.Collector {
|
|
return prombolt.New("boltDB", db, blockedBuckets...)
|
|
}
|