mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-07 22:54:17 -05:00
A TOCTOU issue was reported by EF security in which two attestations being validated at the same time may result in both of them being forwarded. The spec says that we need to forward only the first one.
828 lines
29 KiB
Go
828 lines
29 KiB
Go
package sync
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/OffchainLabs/go-bitfield"
|
|
mock "github.com/OffchainLabs/prysm/v7/beacon-chain/blockchain/testing"
|
|
"github.com/OffchainLabs/prysm/v7/beacon-chain/core/helpers"
|
|
"github.com/OffchainLabs/prysm/v7/beacon-chain/core/signing"
|
|
dbtest "github.com/OffchainLabs/prysm/v7/beacon-chain/db/testing"
|
|
"github.com/OffchainLabs/prysm/v7/beacon-chain/operations/attestations"
|
|
"github.com/OffchainLabs/prysm/v7/beacon-chain/p2p"
|
|
p2ptest "github.com/OffchainLabs/prysm/v7/beacon-chain/p2p/testing"
|
|
"github.com/OffchainLabs/prysm/v7/beacon-chain/startup"
|
|
mockSync "github.com/OffchainLabs/prysm/v7/beacon-chain/sync/initial-sync/testing"
|
|
lruwrpr "github.com/OffchainLabs/prysm/v7/cache/lru"
|
|
fieldparams "github.com/OffchainLabs/prysm/v7/config/fieldparams"
|
|
"github.com/OffchainLabs/prysm/v7/config/params"
|
|
"github.com/OffchainLabs/prysm/v7/consensus-types/primitives"
|
|
"github.com/OffchainLabs/prysm/v7/crypto/bls"
|
|
"github.com/OffchainLabs/prysm/v7/encoding/bytesutil"
|
|
ethpb "github.com/OffchainLabs/prysm/v7/proto/prysm/v1alpha1"
|
|
"github.com/OffchainLabs/prysm/v7/proto/prysm/v1alpha1/attestation"
|
|
"github.com/OffchainLabs/prysm/v7/testing/assert"
|
|
"github.com/OffchainLabs/prysm/v7/testing/require"
|
|
"github.com/OffchainLabs/prysm/v7/testing/util"
|
|
pubsub "github.com/libp2p/go-libp2p-pubsub"
|
|
pubsubpb "github.com/libp2p/go-libp2p-pubsub/pb"
|
|
)
|
|
|
|
func TestVerifyIndexInCommittee_CanVerify(t *testing.T) {
|
|
ctx := t.Context()
|
|
params.SetupTestConfigCleanup(t)
|
|
params.OverrideBeaconConfig(params.MinimalSpecConfig())
|
|
|
|
service := &Service{}
|
|
validators := uint64(32)
|
|
s, _ := util.DeterministicGenesisState(t, validators)
|
|
require.NoError(t, s.SetSlot(params.BeaconConfig().SlotsPerEpoch))
|
|
|
|
bf := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
bf.SetBitAt(0, true)
|
|
att := ðpb.Attestation{Data: ðpb.AttestationData{}, AggregationBits: bf}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), s, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
indices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
|
|
result, err := service.validateIndexInCommittee(ctx, att, primitives.ValidatorIndex(indices[0]), committee)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, result)
|
|
|
|
wanted := "validator index 1000 is not within the committee"
|
|
result, err = service.validateIndexInCommittee(ctx, att, 1000, committee)
|
|
assert.ErrorContains(t, wanted, err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
}
|
|
|
|
func TestVerifyIndexInCommittee_ExistsInBeaconCommittee(t *testing.T) {
|
|
ctx := t.Context()
|
|
params.SetupTestConfigCleanup(t)
|
|
params.OverrideBeaconConfig(params.MinimalSpecConfig())
|
|
|
|
validators := uint64(64)
|
|
s, _ := util.DeterministicGenesisState(t, validators)
|
|
require.NoError(t, s.SetSlot(params.BeaconConfig().SlotsPerEpoch))
|
|
|
|
att := ðpb.Attestation{Data: ðpb.AttestationData{}}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), s, att.Data.Slot, att.Data.CommitteeIndex)
|
|
require.NoError(t, err)
|
|
|
|
bl := bitfield.NewBitlist(uint64(len(committee)))
|
|
att.AggregationBits = bl
|
|
|
|
service := &Service{}
|
|
result, err := service.validateIndexInCommittee(ctx, att, committee[0], committee)
|
|
require.ErrorContains(t, "no attesting indices", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
att.AggregationBits.SetBitAt(0, true)
|
|
|
|
result, err = service.validateIndexInCommittee(ctx, att, committee[0], committee)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, result)
|
|
|
|
wanted := "validator index 1000 is not within the committee"
|
|
result, err = service.validateIndexInCommittee(ctx, att, 1000, committee)
|
|
assert.ErrorContains(t, wanted, err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
// Test the edge case where committee index equals count (should be rejected)
|
|
// With 64 validators and minimal config, count = 2, so valid indices are 0 and 1
|
|
att.Data.CommitteeIndex = 2
|
|
_, _, result, err = service.validateCommitteeIndexAndCount(ctx, att, s)
|
|
require.ErrorContains(t, "committee index 2 >= 2", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
}
|
|
|
|
func TestVerifyIndexInCommittee_ExistsInBeaconCommittee_Electra(t *testing.T) {
|
|
ctx := t.Context()
|
|
params.SetupTestConfigCleanup(t)
|
|
params.OverrideBeaconConfig(params.MinimalSpecConfig())
|
|
|
|
validators := uint64(64)
|
|
s, _ := util.DeterministicGenesisState(t, validators)
|
|
require.NoError(t, s.SetSlot(params.BeaconConfig().SlotsPerEpoch))
|
|
|
|
att := ðpb.AttestationElectra{Data: ðpb.AttestationData{}}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), s, att.Data.Slot, att.Data.CommitteeIndex)
|
|
require.NoError(t, err)
|
|
|
|
bl := bitfield.NewBitlist(uint64(len(committee)))
|
|
att.AggregationBits = bl
|
|
att.CommitteeBits = primitives.NewAttestationCommitteeBits()
|
|
|
|
service := &Service{}
|
|
|
|
att.Data.CommitteeIndex = 1
|
|
_, _, result, err := service.validateCommitteeIndexAndCount(ctx, att, s)
|
|
require.ErrorContains(t, "attestation data's committee index must be 0", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
att.Data.CommitteeIndex = 0
|
|
_, _, result, err = service.validateCommitteeIndexAndCount(ctx, att, s)
|
|
require.ErrorContains(t, "committee bits have no bit set", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
att.CommitteeBits.SetBitAt(0, true)
|
|
att.CommitteeBits.SetBitAt(1, true)
|
|
|
|
_, _, result, err = service.validateCommitteeIndexAndCount(ctx, att, s)
|
|
require.ErrorContains(t, "expected 1 committee bit indice got 2", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
// Unset committee index 0
|
|
att.CommitteeBits.SetBitAt(0, false)
|
|
ci, _, result, err := service.validateCommitteeIndexAndCount(ctx, att, s)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, result)
|
|
assert.Equal(t, ci, primitives.CommitteeIndex(1))
|
|
|
|
newAtt := ðpb.SingleAttestation{Data: ðpb.AttestationData{}, CommitteeId: 1}
|
|
|
|
newAtt.Data.CommitteeIndex = 1
|
|
_, _, result, err = service.validateCommitteeIndexAndCount(ctx, newAtt, s)
|
|
require.ErrorContains(t, "attestation data's committee index must be 0", err)
|
|
assert.Equal(t, pubsub.ValidationReject, result)
|
|
|
|
newAtt.Data.CommitteeIndex = 0
|
|
ci, _, result, err = service.validateCommitteeIndexAndCount(ctx, newAtt, s)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, result)
|
|
assert.Equal(t, ci, primitives.CommitteeIndex(1))
|
|
}
|
|
|
|
func TestVerifyIndexInCommittee_Electra(t *testing.T) {
|
|
ctx := t.Context()
|
|
s, _ := util.DeterministicGenesisStateElectra(t, 64)
|
|
service := &Service{}
|
|
cb := primitives.NewAttestationCommitteeBits()
|
|
cb.SetBitAt(0, true)
|
|
att := ðpb.AttestationElectra{Data: ðpb.AttestationData{}, CommitteeBits: cb}
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), s, att.Data.Slot, att.Data.CommitteeIndex)
|
|
require.NoError(t, err)
|
|
bl := bitfield.NewBitlist(uint64(len(committee)))
|
|
bl.SetBitAt(0, true)
|
|
att.AggregationBits = bl
|
|
|
|
result, err := service.validateIndexInCommittee(ctx, att, committee[0], committee)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, result)
|
|
}
|
|
|
|
func TestVerifySelection_NotAnAggregator(t *testing.T) {
|
|
ctx := t.Context()
|
|
params.SetupTestConfigCleanup(t)
|
|
params.OverrideBeaconConfig(params.MinimalSpecConfig())
|
|
validators := uint64(2048)
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
sig := privKeys[0].Sign([]byte{'A'})
|
|
data := util.HydrateAttestationData(ðpb.AttestationData{})
|
|
committee, err := helpers.BeaconCommitteeFromState(ctx, beaconState, data.Slot, data.CommitteeIndex)
|
|
require.NoError(t, err)
|
|
_, err = validateSelectionIndex(ctx, beaconState, data.Slot, committee, 0, sig.Marshal())
|
|
wanted := "validator is not an aggregator for slot"
|
|
assert.ErrorContains(t, wanted, err)
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_NoBlock(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
att := util.HydrateAttestation(ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
Source: ðpb.Checkpoint{Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
},
|
|
})
|
|
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: bytesutil.PadTo([]byte{'A'}, fieldparams.BLSSignatureLength),
|
|
Aggregate: att,
|
|
AggregatorIndex: 0,
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof, Signature: make([]byte, fieldparams.BLSSignatureLength)}
|
|
|
|
c := lruwrpr.New(10)
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
attPool: attestations.NewPool(),
|
|
chain: &mock.ChainService{},
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]any),
|
|
seenAggregatedAttestationCache: c,
|
|
}
|
|
r.initCaches()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err := p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
|
|
if res, err := r.validateAggregateAndProof(t.Context(), "", msg); res == pubsub.ValidationAccept {
|
|
_ = err
|
|
t.Error("Expected validate to fail")
|
|
}
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_NotWithinSlotRange(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, _ := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, b)
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.SaveState(t.Context(), s, root))
|
|
|
|
aggBits := bitfield.NewBitlist(3)
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
Slot: 1,
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
},
|
|
AggregationBits: aggBits,
|
|
Signature: make([]byte, fieldparams.BLSSignatureLength),
|
|
}
|
|
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
Aggregate: att,
|
|
SelectionProof: make([]byte, fieldparams.BLSSignatureLength),
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof, Signature: make([]byte, fieldparams.BLSSignatureLength)}
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: &mock.ChainService{
|
|
Genesis: time.Now(),
|
|
State: beaconState,
|
|
},
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
}
|
|
r.initCaches()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
|
|
if res, err := r.validateAggregateAndProof(t.Context(), "", msg); res == pubsub.ValidationAccept {
|
|
_ = err
|
|
t.Error("Expected validate to fail")
|
|
}
|
|
|
|
att.Data.Slot = 1<<32 - 1
|
|
|
|
buf = new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
msg = &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
if res, err := r.validateAggregateAndProof(t.Context(), "", msg); res == pubsub.ValidationAccept {
|
|
_ = err
|
|
t.Error("Expected validate to fail")
|
|
}
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_ExistedInPool(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, _ := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, b)
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
|
|
aggBits := bitfield.NewBitlist(3)
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
Slot: 1,
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
},
|
|
AggregationBits: aggBits,
|
|
Signature: make([]byte, fieldparams.BLSSignatureLength),
|
|
}
|
|
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
Aggregate: att,
|
|
SelectionProof: make([]byte, fieldparams.BLSSignatureLength),
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof, Signature: make([]byte, fieldparams.BLSSignatureLength)}
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
r := &Service{
|
|
cfg: &config{
|
|
attPool: attestations.NewPool(),
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: &mock.ChainService{Genesis: time.Now(),
|
|
State: beaconState},
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
blkRootToPendingAtts: make(map[[32]byte][]any),
|
|
}
|
|
r.initCaches()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
|
|
require.NoError(t, r.cfg.attPool.SaveBlockAttestation(att))
|
|
if res, err := r.validateAggregateAndProof(t.Context(), "", msg); res == pubsub.ValidationAccept {
|
|
_ = err
|
|
t.Error("Expected validate to fail")
|
|
}
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_CanValidate(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, b)
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.SaveState(t.Context(), s, root))
|
|
|
|
aggBits := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
Slot: 1,
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
assert.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
sigs := make([]bls.Signature, len(attestingIndices))
|
|
for i, indice := range attestingIndices {
|
|
sig := privKeys[indice].Sign(hashTreeRoot[:])
|
|
sigs[i] = sig
|
|
}
|
|
att.Signature = bls.AggregateSignatures(sigs).Marshal()
|
|
ai := committee[0]
|
|
sszUint := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(beaconState, 0, &sszUint, params.BeaconConfig().DomainSelectionProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: ai,
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof}
|
|
signedAggregateAndProof.Signature, err = signing.ComputeDomainAndSign(beaconState, 0, signedAggregateAndProof.Message, params.BeaconConfig().DomainAggregateAndProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
defer cancel()
|
|
chain := &mock.ChainService{Genesis: time.Now().Add(-oneEpoch()),
|
|
Optimistic: true,
|
|
DB: db,
|
|
State: beaconState,
|
|
ValidAttestation: true,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Epoch: 0,
|
|
Root: att.Data.BeaconBlockRoot,
|
|
}}
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
r.initCaches()
|
|
go r.verifierRoutine()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
d, err := r.currentForkDigest()
|
|
assert.NoError(t, err)
|
|
topic = r.addDigestToTopic(topic, d)
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
res, err := r.validateAggregateAndProof(t.Context(), "", msg)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, pubsub.ValidationAccept, res, "Validated status is false")
|
|
assert.NotNil(t, msg.ValidatorData, "Did not set validator data")
|
|
}
|
|
|
|
func TestVerifyIndexInCommittee_SeenAggregatorEpoch(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, b)
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.SaveState(t.Context(), s, root))
|
|
|
|
aggBits := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
Slot: 1,
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
require.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
sigs := make([]bls.Signature, len(attestingIndices))
|
|
for i, indice := range attestingIndices {
|
|
sig := privKeys[indice].Sign(hashTreeRoot[:])
|
|
sigs[i] = sig
|
|
}
|
|
att.Signature = bls.AggregateSignatures(sigs).Marshal()
|
|
ai := committee[0]
|
|
sszUint := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(beaconState, 0, &sszUint, params.BeaconConfig().DomainSelectionProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: ai,
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof}
|
|
signedAggregateAndProof.Signature, err = signing.ComputeDomainAndSign(beaconState, 0, signedAggregateAndProof.Message, params.BeaconConfig().DomainAggregateAndProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
defer cancel()
|
|
chain := &mock.ChainService{Genesis: time.Now().Add(-oneEpoch()),
|
|
DB: db,
|
|
ValidatorsRoot: [32]byte{'A'},
|
|
State: beaconState,
|
|
ValidAttestation: true,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Epoch: 0,
|
|
Root: signedAggregateAndProof.Message.Aggregate.Data.BeaconBlockRoot,
|
|
}}
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
r.initCaches()
|
|
go r.verifierRoutine()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
d, err := r.currentForkDigest()
|
|
assert.NoError(t, err)
|
|
topic = r.addDigestToTopic(topic, d)
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
res, err := r.validateAggregateAndProof(t.Context(), "", msg)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, pubsub.ValidationAccept, res, "Validated status is false")
|
|
|
|
// Should fail with another attestation in the same epoch.
|
|
signedAggregateAndProof.Message.Aggregate.Data.Slot++
|
|
buf = new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
msg = &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
|
|
time.Sleep(10 * time.Millisecond) // Wait for cached value to pass through buffers.
|
|
if res, err := r.validateAggregateAndProof(t.Context(), "", msg); res == pubsub.ValidationAccept {
|
|
_ = err
|
|
t.Fatal("Validated status is true")
|
|
}
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_BadBlock(t *testing.T) {
|
|
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.SaveState(t.Context(), s, root))
|
|
|
|
aggBits := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
assert.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
sigs := make([]bls.Signature, len(attestingIndices))
|
|
for i, indice := range attestingIndices {
|
|
sig := privKeys[indice].Sign(hashTreeRoot[:])
|
|
sigs[i] = sig
|
|
}
|
|
att.Signature = bls.AggregateSignatures(sigs).Marshal()
|
|
ai := committee[0]
|
|
sszUint := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(beaconState, 0, &sszUint, params.BeaconConfig().DomainSelectionProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: ai,
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof}
|
|
signedAggregateAndProof.Signature, err = signing.ComputeDomainAndSign(beaconState, 0, signedAggregateAndProof.Message, params.BeaconConfig().DomainAggregateAndProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: &mock.ChainService{Genesis: time.Now(),
|
|
State: beaconState,
|
|
ValidAttestation: true,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Epoch: 0,
|
|
}},
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
}
|
|
r.initCaches()
|
|
// Set beacon block as bad.
|
|
r.setBadBlock(t.Context(), root)
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
res, err := r.validateAggregateAndProof(t.Context(), "", msg)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, pubsub.ValidationReject, res, "Validated status is true")
|
|
}
|
|
|
|
func TestValidateAggregateAndProof_RejectWhenAttEpochDoesntEqualTargetEpoch(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
validators := uint64(256)
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
b := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, b)
|
|
root, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.SaveState(t.Context(), s, root))
|
|
|
|
aggBits := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
aggBits.SetBitAt(0, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 1, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
assert.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
sigs := make([]bls.Signature, len(attestingIndices))
|
|
for i, indice := range attestingIndices {
|
|
sig := privKeys[indice].Sign(hashTreeRoot[:])
|
|
sigs[i] = sig
|
|
}
|
|
att.Signature = bls.AggregateSignatures(sigs).Marshal()
|
|
ai := committee[0]
|
|
sszUint := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(beaconState, 0, &sszUint, params.BeaconConfig().DomainSelectionProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: ai,
|
|
}
|
|
signedAggregateAndProof := ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof}
|
|
signedAggregateAndProof.Signature, err = signing.ComputeDomainAndSign(beaconState, 0, signedAggregateAndProof.Message, params.BeaconConfig().DomainAggregateAndProof, privKeys[ai])
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
chain: &mock.ChainService{Genesis: time.Now(),
|
|
State: beaconState,
|
|
ValidAttestation: true,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Epoch: 0,
|
|
Root: att.Data.BeaconBlockRoot,
|
|
}},
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: (&mock.ChainService{}).OperationNotifier(),
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
}
|
|
r.initCaches()
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = p.Encoding().EncodeGossip(buf, signedAggregateAndProof)
|
|
require.NoError(t, err)
|
|
|
|
topic := p2p.GossipTypeMapping[reflect.TypeFor[*ethpb.SignedAggregateAttestationAndProof]()]
|
|
msg := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
res, err := r.validateAggregateAndProof(t.Context(), "", msg)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, pubsub.ValidationReject, res)
|
|
}
|
|
|
|
func Test_SetAggregatorIndexEpochSeen(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p := p2ptest.NewTestP2P(t)
|
|
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p,
|
|
beaconDB: db,
|
|
},
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
}
|
|
|
|
aggIndex := primitives.ValidatorIndex(42)
|
|
epoch := primitives.Epoch(7)
|
|
|
|
require.Equal(t, false, r.hasSeenAggregatorIndexEpoch(epoch, aggIndex))
|
|
first := r.setAggregatorIndexEpochSeen(epoch, aggIndex)
|
|
require.Equal(t, true, first)
|
|
require.Equal(t, true, r.hasSeenAggregatorIndexEpoch(epoch, aggIndex))
|
|
|
|
second := r.setAggregatorIndexEpochSeen(epoch, aggIndex)
|
|
require.Equal(t, false, second)
|
|
}
|