From b7bce739b1d57848c693c94b377fb56fccc74399 Mon Sep 17 00:00:00 2001 From: Arun Agrawal Date: Wed, 22 Jun 2011 08:04:18 +0530 Subject: [PATCH 1/3] Test added for jdbc-adapter --- railties/test/generators/app_generator_test.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index c31c65a27d..310d2782a9 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -153,6 +153,12 @@ class AppGeneratorTest < Rails::Generators::TestCase assert_file "Gemfile", /^gem\s+["']activerecord-jdbcpostgresql-adapter["']$/ end + def test_config_jdbc_database + run_generator([destination_root, "-d", "jdbc"]) + assert_file "config/database.yml", /jdbc/ + assert_file "Gemfile", /^gem\s+["']activerecord-jdbc-adapter["']$/ + end + def test_generator_if_skip_active_record_is_given run_generator [destination_root, "--skip-active-record"] assert_no_file "config/database.yml" From b2a19ad90b9f542b7800e163c56943f48b97f822 Mon Sep 17 00:00:00 2001 From: Arun Agrawal Date: Wed, 22 Jun 2011 08:15:12 +0530 Subject: [PATCH 2/3] Making tests according to the changes #jruby --- railties/test/generators/app_generator_test.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index 310d2782a9..92d5cd77dc 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -134,7 +134,7 @@ class AppGeneratorTest < Rails::Generators::TestCase def test_config_jdbcmysql_database run_generator([destination_root, "-d", "jdbcmysql"]) - assert_file "config/database.yml", /jdbcmysql/ + assert_file "config/database.yml", /mysql/ assert_file "Gemfile", /^gem\s+["']activerecord-jdbcmysql-adapter["']$/ # TODO: When the JRuby guys merge jruby-openssl in # jruby this will be removed @@ -143,19 +143,20 @@ class AppGeneratorTest < Rails::Generators::TestCase def test_config_jdbcsqlite3_database run_generator([destination_root, "-d", "jdbcsqlite3"]) - assert_file "config/database.yml", /jdbcsqlite3/ + assert_file "config/database.yml", /sqlite3/ assert_file "Gemfile", /^gem\s+["']activerecord-jdbcsqlite3-adapter["']$/ end def test_config_jdbcpostgresql_database run_generator([destination_root, "-d", "jdbcpostgresql"]) - assert_file "config/database.yml", /jdbcpostgresql/ + assert_file "config/database.yml", /postgresql/ assert_file "Gemfile", /^gem\s+["']activerecord-jdbcpostgresql-adapter["']$/ end def test_config_jdbc_database run_generator([destination_root, "-d", "jdbc"]) assert_file "config/database.yml", /jdbc/ + assert_file "config/database.yml", /mssql/ assert_file "Gemfile", /^gem\s+["']activerecord-jdbc-adapter["']$/ end From 3534ea8d50638c32b8e7fb46d1d3767912f7b480 Mon Sep 17 00:00:00 2001 From: Arun Agrawal Date: Wed, 22 Jun 2011 08:43:34 +0530 Subject: [PATCH 3/3] Tests added when no option is given with #jruby. It should generate sqlite3 based app --- railties/test/generators/app_generator_test.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index 92d5cd77dc..03d185165f 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -160,6 +160,14 @@ class AppGeneratorTest < Rails::Generators::TestCase assert_file "Gemfile", /^gem\s+["']activerecord-jdbc-adapter["']$/ end + def test_config_jdbc_database_when_no_option_given + if defined?(JRUBY_VERSION) + run_generator([destination_root]) + assert_file "config/database.yml", /sqlite3/ + assert_file "Gemfile", /^gem\s+["']activerecord-jdbcsqlite3-adapter["']$/ + end + end + def test_generator_if_skip_active_record_is_given run_generator [destination_root, "--skip-active-record"] assert_no_file "config/database.yml"