mirror of
https://github.com/github/rails.git
synced 2026-01-10 07:07:54 -05:00
Merge branch '3-2-13' into 3-2-stable
* 3-2-13: bumping to 3.2.13 fix protocol checking in sanitization [CVE-2013-1857] JDOM XXE Protection [CVE-2013-1856] fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855] stop calling to_sym when building arel nodes [CVE-2013-1854] Merge pull request #9616 from exviva/multiple_select_name_double_square_brackets bumping to rc2 Revert "Merge pull request #8209 from senny/backport_8176" Freeze columns only once per Result Preparing for 3.2.13.rc1 release Update CHANGELOGs for 3.2.13 release. Conflicts: actionmailer/CHANGELOG.md actionpack/CHANGELOG.md activemodel/CHANGELOG.md activeresource/CHANGELOG.md activesupport/CHANGELOG.md railties/CHANGELOG.md
This commit is contained in:
@@ -493,12 +493,6 @@ class CalculationsTest < ActiveRecord::TestCase
|
||||
assert_equal [1,2,3,4], Topic.order(:id).pluck("topics.id")
|
||||
end
|
||||
|
||||
def test_pluck_replaces_select_clause
|
||||
taks_relation = Topic.select([:approved, :id]).order(:id)
|
||||
assert_equal [1,2,3,4], taks_relation.pluck(:id)
|
||||
assert_equal [false, true, true, true], taks_relation.pluck(:approved)
|
||||
end
|
||||
|
||||
def test_pluck_auto_table_name_prefix
|
||||
c = Company.create!(:name => "test", :contracts => [Contract.new])
|
||||
assert_equal [c.id], Company.joins(:contracts).pluck(:id)
|
||||
|
||||
@@ -212,14 +212,14 @@ class MethodScopingTest < ActiveRecord::TestCase
|
||||
table = VerySpecialComment.arel_table
|
||||
relation = VerySpecialComment.scoped
|
||||
relation.where_values << table[:id].not_eq(1)
|
||||
assert_equal({:type => "VerySpecialComment"}, relation.send(:scope_for_create))
|
||||
assert_equal({'type' => "VerySpecialComment"}, relation.send(:scope_for_create))
|
||||
end
|
||||
|
||||
def test_scoped_create
|
||||
new_comment = nil
|
||||
|
||||
VerySpecialComment.send(:with_scope, :create => { :post_id => 1 }) do
|
||||
assert_equal({:post_id => 1, :type => 'VerySpecialComment' }, VerySpecialComment.scoped.send(:scope_for_create))
|
||||
assert_equal({'post_id' => 1, 'type' => 'VerySpecialComment' }, VerySpecialComment.scoped.send(:scope_for_create))
|
||||
new_comment = VerySpecialComment.create :body => "Wonderful world"
|
||||
end
|
||||
|
||||
@@ -228,7 +228,7 @@ class MethodScopingTest < ActiveRecord::TestCase
|
||||
|
||||
def test_scoped_create_with_join_and_merge
|
||||
Comment.where(:body => "but Who's Buying?").joins(:post).merge(Post.where(:body => 'Peace Sells...')).with_scope do
|
||||
assert_equal({:body => "but Who's Buying?"}, Comment.scoped.scope_for_create)
|
||||
assert_equal({'body' => "but Who's Buying?"}, Comment.scoped.scope_for_create)
|
||||
end
|
||||
end
|
||||
|
||||
@@ -441,7 +441,7 @@ class NestedScopingTest < ActiveRecord::TestCase
|
||||
comment = nil
|
||||
Comment.send(:with_scope, :create => { :post_id => 1}) do
|
||||
Comment.send(:with_scope, :create => { :post_id => 2}) do
|
||||
assert_equal({:post_id => 2}, Comment.scoped.send(:scope_for_create))
|
||||
assert_equal({'post_id' => 2}, Comment.scoped.send(:scope_for_create))
|
||||
comment = Comment.create :body => "Hey guys, nested scopes are broken. Please fix!"
|
||||
end
|
||||
end
|
||||
@@ -453,7 +453,7 @@ class NestedScopingTest < ActiveRecord::TestCase
|
||||
|
||||
Comment.send(:with_scope, :create => { :body => "Hey guys, nested scopes are broken. Please fix!" }) do
|
||||
Comment.send(:with_exclusive_scope, :create => { :post_id => 1 }) do
|
||||
assert_equal({:post_id => 1}, Comment.scoped.send(:scope_for_create))
|
||||
assert_equal({'post_id' => 1}, Comment.scoped.send(:scope_for_create))
|
||||
assert_blank Comment.new.body
|
||||
comment = Comment.create :body => "Hey guys"
|
||||
end
|
||||
|
||||
@@ -71,7 +71,7 @@ module ActiveRecord
|
||||
def test_has_values
|
||||
relation = Relation.new Post, Post.arel_table
|
||||
relation.where_values << relation.table[:id].eq(10)
|
||||
assert_equal({:id => 10}, relation.where_values_hash)
|
||||
assert_equal({'id' => 10}, relation.where_values_hash)
|
||||
end
|
||||
|
||||
def test_values_wrong_table
|
||||
@@ -101,7 +101,7 @@ module ActiveRecord
|
||||
|
||||
def test_create_with_value
|
||||
relation = Relation.new Post, Post.arel_table
|
||||
hash = { :hello => 'world' }
|
||||
hash = { 'hello' => 'world' }
|
||||
relation.create_with_value = hash
|
||||
assert_equal hash, relation.scope_for_create
|
||||
end
|
||||
@@ -110,7 +110,7 @@ module ActiveRecord
|
||||
relation = Relation.new Post, Post.arel_table
|
||||
relation.where_values << relation.table[:id].eq(10)
|
||||
relation.create_with_value = {:hello => 'world'}
|
||||
assert_equal({:hello => 'world', :id => 10}, relation.scope_for_create)
|
||||
assert_equal({'hello' => 'world', 'id' => 10}, relation.scope_for_create)
|
||||
end
|
||||
|
||||
# FIXME: is this really wanted or expected behavior?
|
||||
|
||||
Reference in New Issue
Block a user