github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-14 09:07:58 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,373 Commits 34 Branches 105 Tags
2-3-github
Commit Graph

105 Commits

Author SHA1 Message Date
Charlie Somerville
8f99d00868 require properly 2013-12-30 14:23:00 +11:00
Charlie Somerville
987b61bd1d kill QueryExtension, it's more dead junk 2013-12-30 14:15:55 +11:00
Charlie Somerville
f05e54a9f3 remove stdinput monkey patch 2013-12-30 14:15:51 +11:00
Joshua Peek
ed70830713 Switch to Rack based session stores. 2008-12-15 16:33:31 -06:00
Jeremy Kemper
565fad350e Ruby 1.9 compat: explicitly require delegate for cookie's DelegateClass 2008-11-24 12:05:17 -08:00
Michael Koziarski
025736de8e Use ActiveSupport::SecureRandom instead of the strange fallback code. 2008-09-24 16:24:02 +02:00
Jeremy Kemper
7391f7728d Ruby 1.8.7 compat: work around broken DelegateClass#respond_to? 2008-05-31 15:36:32 -07:00
Pratik Naik
98dc582742 Merge docrails. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-25 12:29:00 +01:00
Jeremy Kemper
b43309328a Ruby 1.9 compat: ensure binary encoding for post body parsing 2008-05-19 16:24:26 -07:00
Rich Cavanaugh
d8bcec6ce6 make CGI::Cookie handle deleting a cookie properly 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-05-13 10:51:55 -07:00
Rich Cavanaugh
a425cd1473 Don't double-escape cookie store data. Don't split cookie values with newlines into an array. [#130 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-05-12 15:26:19 -07:00
Jamis Buck
11787b802a remove support for ampersand-delimited cookie values 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-12 21:45:39 +00:00
Jeremy Kemper
b84a33ddd1 Don't split cookies on comma also. References r8505. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 02:55:44 +00:00
Jeremy Kemper
11dde5ca2f Ruby 1.9 compat: cookies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:28:53 +00:00
Jeremy Kemper
a9f790a748 Use SecureRandom to generate unique ids, if available. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 18:25:31 +00:00
David Heinemeier Hansson
d1808916ae Fix buffer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 05:14:56 +00:00
David Heinemeier Hansson
eede82ccb9 Added support for HTTP Only cookies (works in IE6+ and FF 2.0.5+) as an improvement for XSS attacks (closes #8895) [lifo/Spakman] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-21 15:05:49 +00:00
Jeremy Kemper
d2ed32d592 Parse url-encoded and multipart requests ourselves instead of delegating to CGI. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 06:24:50 +00:00
Jeremy Kemper
9d1f1a8655 Simplify CgiRequest#query_parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6743 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 23:56:09 +00:00
Jeremy Kemper
f73e1c2ec0 Move request parameter parsing from CGI to AbstractRequest. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 22:10:03 +00:00
Jeremy Kemper
32d03af341 Introduce the request.body stream. Lazy-read to parse parameters rather than always setting RAW_POST_DATA. Reduces the memory footprint of large binary PUT requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 21:36:21 +00:00
Jeremy Kemper
f8273e4309 Shine some sunlight on the CGI extensions. Remove unused CGI#session. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 00:08:05 +00:00
Jeremy Kemper
7fb5d44df7 Non-executable source files. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6732 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-14 23:18:22 +00:00
David Heinemeier Hansson
a0e78f7442 Fixed that parameters from XML should also be presented in a hash with indifferent access [DHH] Hash#with_indifferent_access now also converts hashes kept in arrays to indifferent access (makes it easier to treat HTML and XML parameters the same) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-16 22:17:59 +00:00
Tobias Lütke
01c35c8175 Removed ill faded xml_node class from codebase. Use XmlSimple instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-09 15:33:38 +00:00
Jeremy Kemper
b0685e9684 Fix PStore typo. Closes #7900. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-23 16:53:57 +00:00
Jeremy Kemper
65704aeacd Never return nil from CGI#read_query for compatibility with plain CGI query params parser. Closes #7581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 13:39:58 +00:00
Jeremy Kemper
814dd007e5 Performance: patch cgi/session/pstore to require digest/md5 once rather than per #initialize. Closes #7583. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:52:12 +00:00
Rick Olson
2b7dbad8e0 Add a #dbman attr_reader for CGI::Session and make CGI::Session::CookieStore#generate_digest public so it's easy to generate digests 
using the cookie store's secret. [Rick]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 04:09:14 +00:00
Jeremy Kemper
772e02dd62 Factor out unique id generator. Expose cgi to session store. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 23:51:25 +00:00
Jeremy Kemper
916f9e5143 Performance: patch cgi/session to require digest/md5 once rather than per #create_new_id. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-10 02:44:32 +00:00
Nicholas Seckar
17a9405b58 Change the query parser to map empty GET params to "" rather than nil. Closes #5694. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 17:00:17 +00:00
Jeremy Kemper
0eacdcf9a3 Use a consistent load path to avoid double requires. Fix some scattered Ruby warnings. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:16:55 +00:00
David Heinemeier Hansson
0aa0c84c17 Nodoc the irrelevant (from 1.2) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-26 21:37:38 +00:00
Jeremy Kemper
41198ad3ad Fix parsing of array[] CGI parameters so extra empty values aren't included. Closes #6252. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 09:10:58 +00:00
David Heinemeier Hansson
093c725732 Fix that redirects should set "Location" header, not "location", and remove dead CGI.redirect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 05:04:57 +00:00
Jeremy Kemper
0342393b30 Multipart form values may have a content type without being treated as uploaded files if they do not provide a filename. Closes #6401. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-09 18:52:19 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
David Heinemeier Hansson
54c393f5fa Hash.create_from_xml has been renamed to Hash.from_xml, alias will exist until Rails 2.0 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 09:34:29 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 07:25:14 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 20:10:14 +00:00
Jeremy Kemper
12ff554cd4 Tighten rescue clauses. Closes #5985. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-31 03:16:28 +00:00
Nicholas Seckar
d34a346d9d Switch to using FormEncodedPairParser for parsing request parameters. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-30 05:50:02 +00:00
David Heinemeier Hansson
d164d09649 FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-28 14:05:05 +00:00
David Heinemeier Hansson
7b34d0f8c5 Actually, indifferent access mattered in the bowels (hashes hidden in arrays) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c Result is made indifferent on the way out 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306 Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:49:09 +00:00
David Heinemeier Hansson
6b5ef885d9 The white space inquisition is coming for you! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 16:47:48 +00:00
Nicholas Seckar
f39180eded Fix broken query parameter tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 16:03:21 +00:00