github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,493 Commits 34 Branches 105 Tags
3-1-github
Commit Graph

134 Commits

Author SHA1 Message Date
Dmitry Vorotilin
cf429711b0 Fix #3993 assets:precompile task does not detect index files 2012-05-04 16:30:36 +04:00
Santiago Pastorino
b7c7f08c87 Pass extensions to javascript_path and stylesheet_path helpers. Closes #3417 2012-01-03 17:52:00 -02:00
Guillermo Iguaran
d7fbd63984 Use ProcessedAsset#pathname in Sprockets helpers when debugging is on. Closes #3333 #3348 #3361. 
Is wrong use ProcessedAsset#to_s since it returns the content of the file.
 2011-12-20 10:15:11 -05:00
Santiago Pastorino
a2f4ef1d80 Merge pull request #3428 from adrianpike/asset_path_conflicts 
Issue #3427 - asset_path_conflicts
 2011-12-06 11:19:06 -02:00
Jonathan del Strother
0ce562c1f3 Leave default_asset_host_protocol unset 
When default_asset_host_protocol is left as nil, it will use absolute protocols when a request is present, and relative protocols otherwise (eg in asset generation)

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-01 13:19:38 +01:00
Santiago Pastorino
4f2c238f3a stylesheet_link_tag('/stylesheets/application') and similar helpers doesn't throw Sprockets::FileOutsidePaths exception anymore 2011-10-05 15:42:25 -02:00
José Valim
c6d13b6320 Fix regression when calling helpers inside sprockets. 2011-10-05 09:35:31 +02:00
José Valim
d9d1bb2fb9 Fix the lame config.action_controller.present? check scattered throughout assets_path. 2011-10-05 02:28:40 +02:00
José Valim
db8db4a466 Ensure default_asset_host_protocol is respected, closes #2980. 2011-10-05 02:07:25 +02:00
José Valim
188d21c1ee Encapsulate common rake invocation logic in a method. 2011-10-05 01:17:04 +02:00
Mark J. Titorenko
871cbae6e4 added comment about why nondigest assets requires a reinvocation 2011-10-04 23:27:53 +01:00
Mark J. Titorenko
45cdb3ea9d only reinvoke if necessary 2011-10-04 23:27:29 +01:00
Mark J. Titorenko
20173e2682 only execute the nondigest task if needed 2011-10-04 23:22:51 +01:00
Mark J. Titorenko
bbdb7f3258 don't munge the environment, let rake do that for us 2011-10-04 23:10:11 +01:00
Mark J. Titorenko
63bab287ec assets compilation task refactoring 2011-10-04 23:05:01 +01:00
José Valim
4bc6e2f8a7 Fix failing test added in previous commit. 2011-10-04 22:03:59 +02:00
José Valim
360b8c4c52 Fix failing tests and refactor assets.rake 2011-10-04 11:24:22 +02:00
José Valim
2db49c55e9 Fix #3198. 2011-10-03 17:31:11 +02:00
Sam Pohlenz
a6614c5de6 Ensure that enhancements to assets:precompile task are only run once 2011-10-03 16:06:04 +10:30
José Valim
ee8a37c734 :group => :assets should only run in the assets environment. 2011-10-02 22:09:13 +02:00
José Valim
258fe7d051 Provide initialize_on_precompile which, when set to false, does not initialize the app for precompilation. Defaults to true. 2011-10-02 12:14:31 +02:00
Arun Agrawal
32df5b6813 Warning Use of :: in void context Warning removed 2011-10-01 14:31:59 +05:30
Santiago Pastorino
7e2de385fe javascript_path and stylesheet_path should honor the asset pipelining 2011-09-28 20:13:56 -03:00
Santiago Pastorino
493077cdc0 Merge pull request #3138 from christos/correct_image_path_with_pipeline 
Correctly override image_path in sprockets rails_helper
 2011-09-26 14:02:34 -03:00
Santiago Pastorino
b703cdbb64 Merge pull request #3136 from guilleiguaran/clear-digests-on-precompile 
Avoid use of existing precompiled assets during rake assets:precompile run
 2011-09-26 09:56:38 -07:00
Santiago Pastorino
6ba472c8b8 Copy assets to nondigested filenames too 2011-09-26 13:55:40 -03:00
Guillermo Iguaran
b605bd5f1b Avoid use of existing precompiled assets during rake assets:precompile run. Closes #3119 2011-09-26 10:55:47 -05:00
Santiago Pastorino
7e43dee857 Merge pull request #3135 from christos/respect_assets_digest_value 
Give precedence to `config.digest = false` over the existence of manifest.yml asset digests
 2011-09-26 12:17:02 -03:00
José Valim
ef7de0cf24 Encapsulate assets initialization in its own rake task. 2011-09-26 16:30:36 +02:00
Santiago Pastorino
0cb84f18d6 image_tag should use /assets if asset pipelining is turned on. Closes #3126 2011-09-26 11:21:30 -03:00
cablegram
21f1e45ed1 Re-launch assets:precompile task using (Rake.)ruby instead of Kernel.exec so it works on Windows 
The Kernel.exec method launches the current program ($0) after setting some environment variables.  This current ruby script has a shebang line and no .rb in its name. Launching a script this way does not work on Windows. By using the +ruby+ method that is included in Rake, we can launch the current script with the current ruby version and bypass the identified Windows issue.
 2011-09-24 13:17:50 -05:00
José Valim
253c0bcb54 Avoid using pathnames and automatically create the manifest directory if one does not exist yet. 2011-09-24 03:05:36 +02:00
José Valim
2a688677b0 Remove the ENV flag, yagni. 2011-09-24 02:15:18 +02:00
José Valim
b4798894d3 rake assets:precompile loads the application but does not initialize it. 
To the app developer, this means configuration add in
config/initializers/* will not be executed.

Plugins developers need to special case their initializers that are
meant to be run in the assets group by adding :group => :assets.
 2011-09-24 02:00:41 +02:00
Santiago Pastorino
f64a352265 Merge pull request #3115 from guilleiguaran/refactor-rails-helpers 
Remove Sprockets compute_public_path, AV compute_plubic_path can be used
 2011-09-23 16:08:59 -03:00
Santiago Pastorino
d4f999fba7 Merge pull request #3092 from asee/master 
Sprockets to use config.assets.prefix, with tests
 2011-09-23 14:16:01 -03:00
Terence Lee
d123489a31 set env to let rails know we're precompiling 2011-09-22 13:24:41 -05:00
Santiago Pastorino
40a574ff16 Merge pull request #3081 from guilleiguaran/move-precompile-to-class 
Move precompiling from task to Sprockets::StaticCompiler
 2011-09-21 21:22:27 -03:00
José Valim
6dae0ab2fe Merge pull request #3040 from guilleiguaran/asset-host-should-not-be-nil-precompile 
config.action_controller.asset_host shouldn't set to nil during precompile
 2011-09-16 07:29:21 -07:00
Santiago Pastorino
64de4dd84a Allow asset tag helper methods to accept :digest => false option in order to completely avoid the digest generation. 2011-09-14 15:02:41 -07:00
José Valim
499ea5162a Merge pull request #3015 from guilleiguaran/clear-tmp-cache-on-precompile 
Clear cache before of each precompile to avoid inconsistencies. Fixes #3014
 2011-09-14 09:24:01 -07:00
Santiago Pastorino
f85cd49f9c Revert "Provide a way to access to assets without using the digest, useful for static files and emails" 
This reverts commit 82afaa0686.
 2011-09-14 00:29:42 -07:00
Santiago Pastorino
058593dd35 Merge pull request #3011 from guilleiguaran/disable-sprockets-server 
Don't mount Sprockets if config.assets.compile is disabled
 2011-09-13 16:42:23 -07:00
Santiago Pastorino
65cf784674 Provide a way to access to assets without using the digest, useful for static files and emails 2011-09-13 15:19:22 -07:00
Santiago Pastorino
a244ad4ceb Fix asset_path relative_url_root method 2011-09-13 02:45:35 -07:00
Santiago Pastorino
bb9368724d Merge pull request #3000 from guilleiguaran/fix-relative-url-root 
Fix for relative url root in assets
 2011-09-13 02:30:01 -07:00
Santiago Pastorino
f79fac5029 always rewrite_relative_url_root 2011-09-13 00:29:28 -07:00
Santiago Pastorino
c289dea8a2 Merge pull request #2977 from guilleiguaran/fix-relative-root-in-assets 2011-09-13 00:14:21 -07:00
Santiago Pastorino
8c3f6f6b75 Merge pull request #2987 from kennyj/master 2011-09-12 23:06:21 -07:00
Santiago Pastorino
7e26ab188f Merge pull request #2985 from kennyj/master 
fix https://github.com/rails/rails/issues/2582 (with testcase)
 2011-09-12 10:22:16 -07:00