github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,924 Commits 34 Branches 105 Tags
0420fb56475409c209193fbd45f9afffe8cd35eb
Commit Graph

3477 Commits

Author SHA1 Message Date
Aaron Patterson
0420fb5647 adding FOUND_ROWS to the connect flags for mysql2 2010-08-20 10:16:22 -07:00
Xavier Noria
0c75ec51a9 Merge remote branch 'rails/master' 2010-08-20 17:18:57 +02:00
Neeraj Singh
87398e531d Patch for Lighthouse ticket #5419 has been been applied. So reverting this one. 
Revert "documentation regarding after_validation"

This reverts commit c24aa2f2dc.
 2010-08-20 11:08:25 -04:00
Neeraj Singh
c24aa2f2dc documentation regarding after_validation 2010-08-20 09:48:07 -04:00
Aaron Patterson
949c7e2d0e fisting after_rollback and after commit callbacks 2010-08-20 00:06:49 -07:00
Aaron Patterson
bfd8be7fab updates return number of rows matched rather than number of rows affected 2010-08-19 19:13:50 -07:00
Andrew White
0b73f2af0e Optimize find_sti_class when store_full_sti_class is true 
[#5403]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-08-19 16:03:15 -05:00
Trevor Turk
99c092d4e8 Note about validates_presence_of and nested attributes 2010-08-19 14:49:10 -05:00
Trevor Turk
e6b6d3adad Note about using attr_accessible with nested attributes 2010-08-19 14:25:15 -05:00
Neeraj Singh
2e45542942 While creating a new record using has_many create method default scope of child should be respected. 
author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 14:52:15 -03:00
Aaron Patterson
a4458f5d21 removing useless ternary 2010-08-19 10:46:10 -07:00
Aaron Patterson
a70248c3d8 we should wrap strings as sql literals 2010-08-19 10:35:09 -07:00
Jeremy Kemper
d3e30a18b2 Memoize STI class lookups for the duration of a request 2010-08-19 11:07:09 -05:00
Aaron Patterson
072cd60379 refactor if / else to ||= 2010-08-18 23:37:37 -07:00
Aaron Patterson
e4f424d577 refactoring to remove duplicate logic 2010-08-18 12:10:48 -07:00
Aaron Patterson
93f335b6fb call to present? is not necessary 2010-08-18 11:51:59 -07:00
Carlos Antonio da Silva
0dfb8ff347 Use COALESCE in update_counters docs to reflect the implementation 2010-08-18 10:15:26 -03:00
Jeff Lawson
c017041e68 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:16:03 -07:00
Jeff Lawson
7ce1539934 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:15:58 -07:00
Raimonds Simanovskis
c7dd49eb2a Replaced hardcoded SessionStore table creation SQL with calls to ActiveRecord adapter migration methods 
Otherwise hardcoded table creation SQL was failing on Oracle database
 2010-08-16 15:21:58 -07:00
Santiago Pastorino
3c8b50020a Revert "Makes AR use AMo to_key implementation" 
This reverts commit 36a84a4f15.
 2010-08-15 11:33:21 -03:00
Santiago Pastorino
a81c956bf1 remove already defined method to avoid warnings 2010-08-15 07:59:40 -03:00
Santiago Pastorino
69de30d01f Revert "connection reader is defined later" 
This reverts commit f4cce71d96.
 2010-08-15 07:47:52 -03:00
Santiago Pastorino
f4cce71d96 connection reader is defined later 2010-08-15 07:19:53 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Santiago Pastorino
1590377886 Makes AR use AMo to_key implementation 
[#5249]
 2010-08-13 22:26:44 -03:00
Santiago Pastorino
27fb88aa22 This method is actually not used, it's implemented on the concrete adapters 
[#5331 state:committed]
 2010-08-13 21:19:47 -03:00
Aaron Patterson
be5d1608cb converting to a symbol is not necessary 2010-08-13 16:50:31 -07:00
Prem Sichanugrist
a7eb8d97a4 Removing most of the symbol to proc usage in Active Record 
This will hopefully make Active Record run a bit more faster.
 2010-08-13 16:24:49 -07:00
Aaron Patterson
b9eec677c4 avoid direct use of arel constants 2010-08-13 13:33:08 -07:00
Aaron Patterson
af3e39358c removing references to arel constants 2010-08-13 12:37:18 -07:00
Aaron Patterson
e18bd86314 avoiding symbol to proc again 2010-08-13 12:37:07 -07:00
Aaron Patterson
4439e57ee0 do not use arel constants directly 2010-08-13 12:37:03 -07:00
Aaron Patterson
5651e4c835 symbol to proc is slow, we should avoid it 2010-08-13 12:36:59 -07:00
Xavier Noria
fddcd21bd1 be more precise re :validate and :autosave 2010-08-12 19:31:47 +02:00
Neeraj Singh
6ed1ba472e Ensure we can nest include calls [#5285 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-12 13:10:58 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26 revises some autosave docs, style and content 2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. 2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837 commit review: applies guidelines to "# =>" 2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef updating documentation for named_scope and default_scope 2010-08-12 10:23:20 -04:00
Paul Hieromnimon
007c4da9ae Raising exception if fixture file can't be found 2010-08-11 15:47:34 -07:00
Aaron Patterson
7de03ec765 subtracting blank strings is slightly faster than blank? 2010-08-11 15:45:06 -07:00
Aaron Patterson
06dc884454 avoid multiple hash lookups 2010-08-11 15:00:08 -07:00
Aaron Patterson
ce529b4759 dry up the hash dup and avoid sending nil values 2010-08-11 15:00:02 -07:00
Aaron Patterson
0f502ab88f avoiding tap saves us time 2010-08-11 11:44:08 -07:00
Aaron Patterson
2b8f24998e unless Array#empty? is faster than if Array#present? 2010-08-11 11:44:04 -07:00
Aaron Patterson
3c11e92616 stop using private methods 2010-08-11 11:43:57 -07:00
Brian Lopez
188855501b move mysql2 adapter into core 2010-08-09 14:52:00 -07:00