Commit Graph

818 Commits

Author SHA1 Message Date
David Heinemeier Hansson
0555fc905c Added connection#current_database that'll return of the current database (only works in MySQL, SQL Server, and Oracle so far -- please help implement for the rest of the adapters) (closes #3663) [Tom ward]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:54:04 +00:00
David Heinemeier Hansson
df97ed5e4c Nicer error message on has_many :through when :through reflection can not be found (closes #4042) [court3nay@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3910 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:39:18 +00:00
David Heinemeier Hansson
9bd7db4a98 Fixed that Migration#execute would have the table name prefix appended to its query (closes #4110) [mark.imbriaco@pobox.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:32:38 +00:00
David Heinemeier Hansson
a2fba43ebc The style police makes an expection on acts_as_tree (closes #4168) [coffee2code]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:22:45 +00:00
David Heinemeier Hansson
ea617708c2 Added migrations support to the Sybase adapter (closes #4293) [John R. Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:02:32 +00:00
Jamis Buck
d712310518 Make all tinyint(1) variants act like boolean in mysql (tinyint(1) unsigned, etc.)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 22:03:26 +00:00
Rick Olson
ee1ae44e0e remove some commented-out cruft
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 06:22:30 +00:00
Rick Olson
a3502c419e Use association's :conditions when eager loading. [jeremyevans0@gmail.com] closes #4144
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 06:17:54 +00:00
Rick Olson
fd87a78710 fix AR tests for sqlite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 05:21:40 +00:00
Rick Olson
02d34440cf Alias the has_and_belongs_to_many join table on eager includes. closes #4106 [jeremyevans0@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:18:12 +00:00
David Heinemeier Hansson
3a7be80f47 Change LEFT OUTER JOIN authors AS authors to LEFT OUTER JOIN authors authors so associations will work for Oracle again (closes #4231) [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:27:21 +00:00
David Heinemeier Hansson
9b9a0908e5 Oracle adapter gets some love #4230 [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:20:46 +00:00
David Heinemeier Hansson
cee92312cf Stop the MySQL adapter crashing when views are present. (closes #3782) [Jonathan Viney]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:00:27 +00:00
Rick Olson
def746030c Added Base.abstract_class? that marks which classes are not part of the Active Record hierarchy. closes #3704
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 02:46:01 +00:00
Rick Olson
0859779d6f Allow :dependent options to be used with polymorphic joins. #3820 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 02:10:11 +00:00
Jamis Buck
6e283e9dc7 Upgrade to Transaction::Simple 1.3
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 18:22:12 +00:00
Michael Koziarski
c42cd3c383 make save! return true on success[johan@johansorensen.com]. Closes #4173
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 02:32:14 +00:00
Rick Olson
4965a754d5 Catch FixtureClassNotFound when using instantiated fixtures on a fixture that has no ActiveRecord model [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-14 15:15:06 +00:00
Rick Olson
796a43dead Allow ordering of calculated results and/or grouped fields in calculations [solo@gatelys.com] closes #4228
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-14 14:59:14 +00:00
Jeremy Kemper
25fb2db409 Dynamically set allow_concurrency. Closes #4044.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 17:28:55 +00:00
David Heinemeier Hansson
51d6bc2807 Passing comment
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-10 17:28:21 +00:00
David Heinemeier Hansson
3442e0c671 Added options to control the :only/:except for included associations on Base#to_xml [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-10 03:50:00 +00:00
David Heinemeier Hansson
db37c0c95f Added association inclusion in to_xml [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-10 00:25:29 +00:00
David Heinemeier Hansson
d872281975 Fixed to_xml across the board to use nice indention, better skip_attributes workings, no type on strings, and cleaned tests [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-09 21:12:28 +00:00
Jamis Buck
966c276d60 Fix counter cache setting in belongs-to proxy
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3828 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-09 20:55:14 +00:00
Jamis Buck
532f9d484c Add suppress_messages to migrations, to temporarily turn off verbose messages
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-09 18:38:39 +00:00
Jamis Buck
87898badba Allow counter_cache to accept a column name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-09 17:23:57 +00:00
Michael Koziarski
57565b3506 format fix for locking [Michael Koziarski]
Add documentation for :dependent on associations. [robby@planetargon.com] Closes #4151


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-09 08:40:34 +00:00
Rick Olson
2383a60443 Allow set_fixture_class to take Classes instead of strings for a class in a module. Raise FixtureClassNotFound if a fixture can't load. [Rick Olson] closes #4095
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 23:03:35 +00:00
Rick Olson
7c4b7affdb Fix quoting of inheritance column for STI eager loading #4098 [Jonathan Viney <jonathan@bluewire.net.nz>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 16:00:46 +00:00
Rick Olson
c58dff1c9c slight change to eager associations table aliasing: use class_reflection, like 'post_comments' or 'tree_children'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3788 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 04:47:58 +00:00
David Heinemeier Hansson
c450a36f16 Doc fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 21:37:12 +00:00
David Heinemeier Hansson
ccfcd9fe22 Doc fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 20:00:04 +00:00
David Heinemeier Hansson
4f00c70580 Fixed eager loading problems with single-table inheritance [Rick Olson] Added smarter table aliasing for eager associations for multiple self joins [Rick Olson] (closes #3580)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:43:56 +00:00
David Heinemeier Hansson
55854c4195 Added cascading eager loading that allows for queries like Author.find(:all, :include=> { :posts=> :comments }), which will fetch all authors, their posts, and the comments belonging to those posts in a single query (using LEFT OUTER JOIN) #3913 [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 23:33:10 +00:00
Jamis Buck
ff881c7f8b Make counter cache work when replacing an association (closes #3245). Thanks for the patch!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 19:42:41 +00:00
Jamis Buck
c0fb67c0f8 Make migrations verbose
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 18:46:51 +00:00
Jamis Buck
964b67dd0e Make counter_cache work with polymorphic belongs_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 15:11:17 +00:00
David Heinemeier Hansson
116658e69b Fixed that calling HasOneProxy#build_model repeatedly would cause saving to happen (closes #4058) [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-03 06:25:39 +00:00
Jeremy Kemper
68ff2ebbea fix unreplaced class var
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 22:04:38 +00:00
Jeremy Kemper
215852745b Revert allow_concurrency change for better testing. Retrieve_connection in two steps to avoid side-effect bug (yuk).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3745 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 14:36:06 +00:00
David Heinemeier Hansson
a4c6442612 More docs for observers (closes #3996) [Robby Russel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 03:02:51 +00:00
David Heinemeier Hansson
456ddc6f61 Doc fix (closes #4014) [thijs@fngtps.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 02:53:57 +00:00
David Heinemeier Hansson
f62b8af688 Catch requirement of Sybase adapter, if we cant, dont have it
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:37:41 +00:00
David Heinemeier Hansson
5ba5dd68da Dont require sybase unless you try to connect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:31:29 +00:00
David Heinemeier Hansson
ec4dd572e7 Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3735 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:25:50 +00:00
David Heinemeier Hansson
6a3f4c932a Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) (closes #3765) [John Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-02 01:15:41 +00:00
Jeremy Kemper
a434cec2e6 (duh :)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3732 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:14:00 +00:00
Jeremy Kemper
d28c0f7405 Typo in stale thread removal.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:09:46 +00:00
Jeremy Kemper
7568f18a2a Clear stale, cached connections left behind by defunct threads. Eliminate duplicate connection cache.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-01 22:05:41 +00:00