github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-04 03:05:27 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,491 Commits 34 Branches 105 Tags
077ae340e8c3013dd43ebcc8023d183dfdd52d4a
Commit Graph

536 Commits

Author SHA1 Message Date
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 12:59:22 +00:00
Jeremy Kemper
3661eacfbd Include all of session creation in stale_session_check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 20:34:44 +00:00
Jamis Buck
b7ce9c5a87 assert_tag uses exact matches for string conditions, instead of partial matches. Use regex to do partial matches. #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 13:42:05 +00:00
Jeremy Kemper
bb4c32e2b5 Delete existing sessions with the same session id before creating a new session. Prevents duplication and hijacking. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 06:00:46 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 01:03:24 +00:00
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
8dda7c5449 Fix conflict with assert_tag and Glue gem (closes #2255) [david.felstead@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:31:49 +00:00
Jamis Buck
0073a759f1 Add documentation to assert_tag indicating that it only works with well-formed XHTML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 13:59:07 +00:00
Jeremy Kemper
ad4e611488 Update paginator docs. Closes #2744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-05 02:10:29 +00:00
David Heinemeier Hansson
9d17e7cce4 Fix assert_no_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 21:37:34 +00:00
David Heinemeier Hansson
a6106e4ec6 Added skip_before_filter/skip_after_filter for easier control of the filter chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 19:42:22 +00:00
David Heinemeier Hansson
4f754985d0 Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"]) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 14:47:03 +00:00
Jeremy Kemper
ddf6910941 ensure close_session in AC::Base#process 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 01:23:34 +00:00
Scott Barron
025949102e Fix problem where redirecting components can cause an 
infinite loop [Rick Olson]

Closes #2654


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-30 13:13:02 +00:00
Jeremy Kemper
54a4e50662 Removed erroneous arg-size check in AC::Base.fragment_cache_store=. Closes #2650. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 23:12:13 +00:00
David Heinemeier Hansson
cb0e27cee9 Fix that render :text didn't interpolate instance variables (Closes #2629, #2626) [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:33:54 +00:00
Nicholas Seckar
f2c920ec24 Fix line number detection and escape RAILS_ROOT in backtrace Regexp 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 21:58:39 +00:00
Nicholas Seckar
a7aa26906c Recognize ./#{RAILS_ROOT} as RAILS_ROOT in error traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 17:09:00 +00:00
Nicholas Seckar
d6461bf9f5 Remove fingerprinting from AR session store; fix bug in store. Closes #2612 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 20:15:43 +00:00
David Heinemeier Hansson
17816a11ee Proper CSS color definition (closes #2334) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:26:51 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:46 +00:00
David Heinemeier Hansson
07c494ae24 Added a reader for flash.now, so it's possible to do stuff like flash.now[:alert] ||= 'New if not set' (closes #2422) [Caio Chassot] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:14:10 +00:00
Nicholas Seckar
86a571090c Reset template variables after using render_to_string. Closes #2559 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 02:15:08 +00:00
Scott Barron
3a2943c54d Take a different approach to keeping flash around when using components. 
One that, you know, doesn't involve consuming every byte of free memory
on the system.

Closes #2589.

References #2291.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 00:38:51 +00:00
Jeremy Kemper
22d9bad8a0 Expose the session model backing CGI::Session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 21:59:48 +00:00
Jamis Buck
4da2d6c1ed Abbreviate RAILS_ROOT in traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 15:56:21 +00:00
Nicholas Seckar
7d8ecad127 Update error trace templates 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 14:08:05 +00:00
Jamis Buck
e515ba9ecd Fix the html-scanner to count children correctly, playing nicely with :only, fixes #2181 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 00:50:52 +00:00
Marcel Molina
ff8fe662ef Use the more appropriate columns_hash to get the session data column size limit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-17 03:13:04 +00:00
Jamis Buck
1c057b7237 Update/clean up AP documentation (rdoc) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 15:42:03 +00:00
Nicholas Seckar
876e6607c9 Add missing file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 13:10:32 +00:00
Tobias Lütke
0279949b05 added assert_valid to AP 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 02:20:53 +00:00
Nicholas Seckar
df9efebd94 Add line and file information to test process' get, post, etc methods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 00:14:51 +00:00
Jamis Buck
bfbf6bba1f Allow ARStore::Session to indicate that it should not be reloaded in dev mode 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 20:49:04 +00:00
Nicholas Seckar
3625dfaad5 Clean up error pages by providing better backtraces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 19:05:15 +00:00
Michael Koziarski
3b8fce7b52 reasoning behind the seemingly duplicated method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:39:19 +00:00
Michael Koziarski
518540a067 Add code and message to test response as per #2460 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:36:41 +00:00
Marcel Molina
48fd667bda Raise an exception if an attempt is made to insert more session data into the ActiveRecordStore data column than the column can hold. Closes #2234. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 14:39:29 +00:00
Tobias Lütke
6a8b9484a7 action pack asserts don't spam you with unnecissary backtraces anymore 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 13:58:22 +00:00
Scott Barron
f8f4eccd9a If a component redirects when called with render_component_as_string, render the 
redirected to action.

Fixes #2327


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:53:21 +00:00
David Heinemeier Hansson
04f4ae255f Take retry with breakpoint out until we fix it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:09:34 +00:00
Nicholas Seckar
e0e8f0a302 Fix Request#host_with_port to use the standard port when Rails is behind a proxy. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:00:25 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 20:26:39 +00:00
Sam Stephenson
4b72a4b12f Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 18:09:27 +00:00
Marcel Molina
d4576673c0 Unescape paths before writing cache to file system. Closes #1877. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:57:04 +00:00
Jamis Buck
0efeeba780 Speed improvement for session_options. #2287. [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:53:31 +00:00
Marcel Molina
9025e5d47f Make cacheing binary files friendly with Windows. Closes #1975. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:06:05 +00:00
Marcel Molina
a9de9c48c2 Make assert_tag :children count appropriately. Closes #2181. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 01:45:21 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-03 21:20:52 +00:00