github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-18 10:01:39 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,079 Commits 34 Branches 105 Tags
09cec7824800bdd29c97356c71b51acf47ef6bcc
Commit Graph

651 Commits

Author SHA1 Message Date
David Heinemeier Hansson
09cec78248 Default mime type for XML should be application/xml [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 18:50:14 +00:00
David Heinemeier Hansson
de37f7df4f Mime types are separated by a comma, not semicolon, in the Accept header. Also switch all internal configuration of mime types away from strings and over to Mime::Type [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 16:03:44 +00:00
David Heinemeier Hansson
7af12d04ce Added synonym and custom type handling to respond_to [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3844 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 06:02:44 +00:00
David Heinemeier Hansson
9e2932f816 Assume that we accept what we give [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 05:13:55 +00:00
David Heinemeier Hansson
de660957a5 Added defaults to respond_to [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 03:39:58 +00:00
David Heinemeier Hansson
6e3e5cadfb Added option to render action/template/file of a specific extension (and here by template type). This means you can have multiple templates with the same name but a different extension [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3841 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 01:56:55 +00:00
Jamis Buck
8e8b6b9e40 More integration testing tweaks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3840 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 00:08:26 +00:00
Nicholas Seckar
77e2f00c28 Don'tt abort rake when rendering the _trace.rhtml template 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-11 02:53:39 +00:00
David Heinemeier Hansson
1c16649b48 Added better support for using the same actions to output for different sources depending on the Accept header [DHH] Added Base#render(:xml => xml) that works just like Base#render(:text => text), but sets the content-type to text/xml and the charset to UTF-8 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-11 01:23:29 +00:00
Jamis Buck
8152695b80 Make assertions in integration sessions proxy to the test instance (only for sessions created via open_session) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3836 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-10 18:00:53 +00:00
Jamis Buck
bfbbd4c346 make sure nil @session doesn't mess up wsod stacktraces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-10 14:41:37 +00:00
Jamis Buck
5568d20b2e Move methods from TestResponse into a module, so they can be shared with response objects in integration tests. (This allows standard functional test assertions to be used in integration tests, like assert_response and assert_template.) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-09 04:57:08 +00:00
Tobias Lütke
aafc191ab7 Integration test's url_for now runs in the context of the last request (if any) so after post /products/show/1 url_for :action => 'new' will yield /product/new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3819 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-08 20:12:30 +00:00
Jamis Buck
519e7e5e12 Fix problem with unloaded ARStore sessions being loaded when they are garbage collected, causing problems if there were AR objects in the session. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-08 16:53:34 +00:00
Jamis Buck
24fca9d92e make integration testing not interfere with command-line regex test filters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 22:04:23 +00:00
Jamis Buck
4d4f0e6490 Make IntegrationTest refer to superclass properties using copy-on-write 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 17:58:34 +00:00
David Heinemeier Hansson
6fd737b76b Proper options for XmlSimple 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 04:52:49 +00:00
Jamis Buck
0fbe6837b1 more integration tweaks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 04:42:24 +00:00
David Heinemeier Hansson
dc4b5cff39 XmlSimple _should_ be the default since XmlNode is not compatible with regular parameters -- also known as Why Did My Etech Demo Not Work? [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 04:42:13 +00:00
Jamis Buck
1c0163e50c A few minor tweaks to the integration testing stuff 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 01:07:54 +00:00
David Heinemeier Hansson
c450a36f16 Doc fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 21:37:12 +00:00
Tobias Lütke
0635f633cc ActionController::Base.param_parsers now accept symbols. currently supported are :xml_node, :xml_simple and :yaml 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 19:16:55 +00:00
Tobias Lütke
03d37a2d68 Added new infrastructure support for REST webservices. 
By default application/xml posts are handled by creating a XmlNode object with the same name as the root element of the submitted xml. M$

 ActionController::Base.param_parsers['application/atom+xml'] = Proc.new do |data|
    node = REXML::Document.new(post)
   { node.root.name => node.root }
 end

 XmlSimple and Yaml web services were retired, ActionController::Base.param_parsers carries an example which shows how to get this functio$
 request.[formatted_post?, xml_post?, yaml_post? and post_format] were all deprecated in favor of request.content_type [Tobias Luetke]

Closes #4081


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 18:59:58 +00:00
David Heinemeier Hansson
30caefdfc7 Backed out of that. PStore doesnt support suffix :( 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 22:49:52 +00:00
David Heinemeier Hansson
a1d70a5329 Backed out of that. PStore doesnt support suffix :( 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 22:41:59 +00:00
David Heinemeier Hansson
56b75a7e04 CHANGED DEFAILT: File-based sessions now have a suffix of ".rails_session" instead of a prefix called "ruby_sess." [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-04 22:31:50 +00:00
David Heinemeier Hansson
3574ab3059 Added that page caching will only happen if the response code is less than 400 (closes #4033) [g.bucher@teti.ch] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:48:56 +00:00
Jamis Buck
8368b5960b restore elided TestProcess#assigns method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 19:40:37 +00:00
Jamis Buck
abeb77b286 Make TestProcess methods public for access via Integration::Session. Make return values from some of the Integration::Session methods sane. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-01 16:37:11 +00:00
Jamis Buck
9507f5dcc9 Add ActionController::IntegrationTest to allow high-level testing of the way the controllers and routes all work together 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-28 18:15:46 +00:00
Nicholas Seckar
26eaf073c4 Remove ::Controllers related cruft; fix AP tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 17:49:09 +00:00
Nicholas Seckar
de54db3c1e Check NameErrors and re-raise if they do not match the expected constant 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-22 17:29:22 +00:00
David Heinemeier Hansson
e875b0db47 Fixed that the request method would be sticky in tests (closes #3849) [lars@pinds.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 23:49:43 +00:00
David Heinemeier Hansson
377bdd02b9 Added :count option to pagination that'll make it possible for the ActiveRecord::Base.count call to using something else than * for the count. Especially important for count queries using DISTINCT #3839 [skaes]. Added :select option to Base.count that'll allow you to select something else than * to be counted on. Especially important for count queries using DISTINCT (closes #3839) [skaes]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 03:15:22 +00:00
David Heinemeier Hansson
8896efd41a Ensure backwards compatibility with symbolized action names for render_action (closes #3869) [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-19 00:46:34 +00:00
David Heinemeier Hansson
1812dbbfde Make RJS treat symbolic action names nicely #3861 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-17 18:32:21 +00:00
David Heinemeier Hansson
db2023d4d2 The session should be saved even if the filter chain is stopped 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:35:15 +00:00
David Heinemeier Hansson
431edf7793 Fixed that flash wasnt being cleared after components refactoring yesterday 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:18:06 +00:00
David Heinemeier Hansson
ff986f19af Flash shouldnt depend on components either [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 06:11:17 +00:00
David Heinemeier Hansson
050c3964d8 Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 05:51:02 +00:00
David Heinemeier Hansson
e90bbbdd83 Add caution and restyle components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:06:45 +00:00
David Heinemeier Hansson
137794310b The components module should also contain the options that pertain to it, so collect it all with ClassMethods and InstanceMethods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:46:01 +00:00
Jeremy Kemper
7654082260 Major components cleanup and speedup. Closes #3527. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 20:05:11 +00:00
Michael Koziarski
d49a5fcb4c * Fix pagination problems when using include 
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.

[Kevin Clark & Jeremy Hopple]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 09:17:40 +00:00
Marcel Molina
73ed47ddec Replace dubious controller parent class in filter docs. Closes #3655, #3722. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:24:53 +00:00
Nicholas Seckar
5450538563 Don't let arbitrary classes match as controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:59:37 +00:00
Nicholas Seckar
b381d8511d Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:09:26 +00:00
Tobias Lütke
28cee08fa4 fixed small bug in routing which caused the traverse_to_controller mechanism to drop out on 
Multi::Nested::Controllers


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 22:04:19 +00:00
David Heinemeier Hansson
5cbc062c8a Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 16:26:55 +00:00
David Heinemeier Hansson
ed080863d5 Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 06:11:42 +00:00