github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 17:54:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,479 Commits 34 Branches 105 Tags
0bfabaa048bdc70eae0cce399809ebd2bb129ffe
Commit Graph

49 Commits

Author SHA1 Message Date
Jeremy Kemper
f0753992ab test controller rescues 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-13 02:03:50 +00:00
David Heinemeier Hansson
b9ffbd3166 Fix scaffolding from using deprecated :post => true (closes #6499) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-26 15:56:48 +00:00
Jamis Buck
2d33676691 Fix deprecation warnings when rendering the template error template. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:59:46 +00:00
David Heinemeier Hansson
2e766b159f Fixed that some 500 rescues would cause 500's themselves because the response had not yet been generated #6329 [cmselmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:21:47 +00:00
David Heinemeier Hansson
717e26dd0e Deprecation cleanup for rescues (closes #6339) [adam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:17:11 +00:00
Jeremy Kemper
297ac55b29 use instance vars in rescue templates since controller may not be instantiated yet 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 16:32:51 +00:00
Jeremy Kemper
d15d15b2c2 Deprecate @response 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:26:45 +00:00
Jeremy Kemper
d7674637f9 Deprecation: @request will be removed after 1.2. Use the request method instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:34:02 +00:00
Jeremy Kemper
c40b1a4a67 Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-07 12:40:14 +00:00
Jamis Buck
38efc32529 Remove problematic control chars in rescue template. (closes #5316) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-08 16:18:10 +00:00
Marcel Molina
7bb20659c2 Update layout and content_for documentation to use yield rather than magic @content_for instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-25 04:03:51 +00:00
Nicholas Seckar
e714b25723 Update the diagnostics template skip the useless '<controller not set>' text. 
Fix symbol extensions test case.
Clean paths inside of exception messages and traces.
Add Pathname.clean_within for cleaning all the paths inside of a string.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-04 19:37:29 +00:00
David Heinemeier Hansson
faecde0ec8 My beautiful eyes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 05:39:13 +00:00
Michael Koziarski
c6abe81b1e Add verification to scaffolds (generated and reflection based). Require POST for unsafe actions [Michael Koziarski]. Closes #2601 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-14 01:57:12 +00:00
Nicholas Seckar
77e2f00c28 Don'tt abort rake when rendering the _trace.rhtml template 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-11 02:53:39 +00:00
Michael Koziarski
f9e0ba2913 Correct the case of the CSS declarations. [Blair Zajac] Closes #3171 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 21:28:51 +00:00
Jeremy Kemper
9de738aadc Remove the unused, slow response_dump and session_dump variables from error pages. References #1222. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 21:34:24 +00:00
Nicholas Seckar
f2c920ec24 Fix line number detection and escape RAILS_ROOT in backtrace Regexp 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 21:58:39 +00:00
Nicholas Seckar
a7aa26906c Recognize ./#{RAILS_ROOT} as RAILS_ROOT in error traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 17:09:00 +00:00
David Heinemeier Hansson
17816a11ee Proper CSS color definition (closes #2334) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:26:51 +00:00
Jamis Buck
4da2d6c1ed Abbreviate RAILS_ROOT in traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 15:56:21 +00:00
Nicholas Seckar
7d8ecad127 Update error trace templates 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 14:08:05 +00:00
Nicholas Seckar
876e6607c9 Add missing file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 13:10:32 +00:00
Nicholas Seckar
3625dfaad5 Clean up error pages by providing better backtraces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 19:05:15 +00:00
David Heinemeier Hansson
04f4ae255f Take retry with breakpoint out until we fix it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:09:34 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
c2060719d3 Added a DOCTYPE of HTML transitional to the HTML files generated by Rails #1124 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:21:25 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700 
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 05:33:23 +00:00
David Heinemeier Hansson
5add31eda4 CSS needs "red" not #red 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-06 09:48:48 +00:00
David Heinemeier Hansson
32c0e895bf Fixed scaffolding to use the latest style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-02 20:13:02 +00:00
David Heinemeier Hansson
fe00c275cd Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:19:14 +00:00
David Heinemeier Hansson
db16349bc1 Fixed error handling of broken layouts #1115 [Michael Schubert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:11:58 +00:00
David Heinemeier Hansson
3532455404 Added pagination for scaffolding (10 items per page) #964 [mortonda@dgrmm.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 09:11:17 +00:00
David Heinemeier Hansson
998ab50974 Improved the message display on the exception handler pages #963 [Johan Sorensen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1048 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-31 14:46:11 +00:00
David Heinemeier Hansson
3306813be1 Tweaked the rescue with breakpoint, still not perfect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@986 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-23 12:03:30 +00:00
David Heinemeier Hansson
3697df1dd2 Improved error reporting especially around never shallowing exceptions. Debugging helpers should be much easier now #980 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-23 11:48:10 +00:00
David Heinemeier Hansson
12a7573630 Added new keyword to specify load paths as being component based. Added better logging for component calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 13:50:13 +00:00
David Heinemeier Hansson
98349f37a3 Gives Rescues some Love #680 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 10:51:10 +00:00
David Heinemeier Hansson
b1999be5a7 A hopefully more successful attempt at the Routing branch merge 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5 Backed out of routing merge.. investigating missing patches 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a Merged back the Routing branch 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
ebf424061d Fixed three issues with retrying breakpoints #417 [Florian Gross] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-10 22:46:45 +00:00
David Heinemeier Hansson
3e6fe858b6 Added POST support for the breakpoint retries, so form processing that raises an exception can be retried with the original request [Florian Gross] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-18 15:01:58 +00:00
David Heinemeier Hansson
2f3db152ec Made the last tweaks before 0.9 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-16 19:43:27 +00:00
David Heinemeier Hansson
b141bdbb32 Display error messages on scaffolded form pages 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-12 14:14:37 +00:00
David Heinemeier Hansson
1b7ea2a50e Added breakpoint retries on rescue screens 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-09 19:48:32 +00:00
David Heinemeier Hansson
3ee4357b86 Added that ActiveRecordHelper#form now calls url_for on the :action option. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@62 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-07 11:43:21 +00:00
David Heinemeier Hansson
0ffb6c1625 Syntax errors and other exceptions thrown outside of an action are now gracefully handled by the dispatcher 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@51 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-06 18:25:01 +00:00
David Heinemeier Hansson
db045dbbf6 Initial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-11-24 01:04:44 +00:00