David Heinemeier Hansson
afbfde9357
Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
46110aa689
Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028
Fixed that onclick would be overridden even when special features werent used
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d
Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
e6428abd23
Fixed a broken test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:30:13 +00:00
David Heinemeier Hansson
7b235f0213
Use this.href, not unexisting url
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df
Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 12:56:33 +00:00
David Heinemeier Hansson
258bacbf82
Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-04 00:33:45 +00:00
Nicholas Seckar
68c90ab019
Render refactoring; render error reporting fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 22:37:36 +00:00
Jamis Buck
82f44f3144
Added :use_short_month option to select_month helper to show month names as abbreviations
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-22 14:47:16 +00:00
Jamis Buck
8910de6a54
Make link_to escape the javascript in the confirm option #1964 [nicolas.pouillard@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-14 08:43:07 +00:00
David Heinemeier Hansson
7073abe159
Fixed bug with :success/:failure callbacks for the JavaScriptHelper methods #1730 [court3nay/Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 11:38:55 +00:00
David Heinemeier Hansson
1666977490
Script.aculo.us: latest rev, new autocompleter features, memory leaks fixed #1695 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 05:17:22 +00:00
David Heinemeier Hansson
383b6afd1c
Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:11:23 +00:00
David Heinemeier Hansson
2abe3d2cd9
Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:28:35 +00:00
David Heinemeier Hansson
05230c13f6
Include Javascript tests in rake #1655 [courtney]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 05:34:13 +00:00
David Heinemeier Hansson
2186ed83dd
Make new AJAX helpers aware of more of their options #1622 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:32:04 +00:00
Jeremy Kemper
c9901176be
benchmark helper takes an optional log level, defaults to :info. Chose symbols log levels rather than Logger::FOO constants for simplicity. Added benchmark helper test suite.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 19:33:25 +00:00
Jeremy Kemper
ac412ef1c7
r2822@asus: jeremy | 2005-07-04 21:14:30 -0700
...
silence warnings re. class redefinitions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:58 +00:00
David Heinemeier Hansson
bf3a0c5391
Improved update_element_function #1597 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 04:57:15 +00:00
David Heinemeier Hansson
c52edf2319
Added :prompt option to FormOptions#select (and the users of it, like FormOptions#select_country etc) to create "Please select" style descriptors #1181 [Michael Schuerig]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:23:16 +00:00
David Heinemeier Hansson
481cac9658
AJAX error handling fix, Prototype event handling #1589 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 08:00:38 +00:00
David Heinemeier Hansson
c6ab8f5706
Added :field_name option to DateHelper#select_(year|month|day) to deviate from the year/month/day defaults #1266 [Marcel Molina]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:38:22 +00:00
David Heinemeier Hansson
b94e8af9a4
Update for JavaScript helper tests #1584 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:20:13 +00:00
David Heinemeier Hansson
a53372c273
Added that UrlHelper#mail_to will now also encode the default link title #749 [f.svehla@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:46:41 +00:00
David Heinemeier Hansson
5651a69130
Load models and frequency typo on upoad progress #1555 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
524d1b5e04
Uncommented request.recycle! as it breaks more than it fixes, left test case in, xal?
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-30 14:49:36 +00:00
David Heinemeier Hansson
2d8679993c
Fix JavaScriptHelper capitalization and make it compatible with Prototype #1545 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 08:09:00 +00:00
David Heinemeier Hansson
beffb77e05
Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
7da736f929
Added script.aculo.us Javascripts (controls.js, dragdrop.js, effects.js) (NEEDS MORE DESCRIPTION) #1509 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 12:03:43 +00:00
David Heinemeier Hansson
c608ebeade
Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
bc6570dfcb
Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06
Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
a49a784dc7
More tests for JavascriptHelper #1460
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-18 05:17:39 +00:00
Jeremy Kemper
959707bfb6
r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700
...
Ticket 1458 - distance_of_time_in_words
r1336@iwill: jeremy | 2005-06-17 11:44:50 -0700
Update changelog
r1337@iwill: jeremy | 2005-06-17 11:45:44 -0700
Applied patch.
r1361@iwill: jeremy | 2005-06-17 11:48:02 -0700
Merge changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a7a1c4e2cd
Added cuba to country list #1351 [todd]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
665ab93761
Added :extension option to NumberHelper#number_to_phone #1361 [delynnb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4
Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6
Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a
Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f
Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd
Its Iraq, not Irak #1443 [ivan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8
Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:04:17 +00:00
Jamis Buck
ed7bfc9662
Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 15:19:03 +00:00
Jeremy Kemper
3cb26e9cb3
r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700
...
Branch to have scaffold use new render methods
r2496@sedna: jeremy | 2005-05-28 10:50:51 -0700
axe unused process_request method
r2497@sedna: jeremy | 2005-05-28 10:51:58 -0700
sanity assertions in process method check that @controller, @request, @response are set
r2498@sedna: jeremy | 2005-05-28 10:53:42 -0700
clean up escaping. use instance_variable_get instead of instance_eval. put id in form action instead of hidden input (like the generated scaffolding)
r2499@sedna: jeremy | 2005-05-28 10:54:46 -0700
clean up interpolation, remove tabs from stylesheet
r2500@sedna: jeremy | 2005-05-28 10:56:40 -0700
modernize dynamic scaffolding. use params[:id] instead of @params[id]. use consolidated render method instead of render_action, render_file, etc. use builtin inflections rather than module methods.
r2501@sedna: jeremy | 2005-05-28 11:00:26 -0700
modernize generated scaffolding. use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
r2542@sedna: jeremy | 2005-06-12 02:24:06 -0700
use :id => model instead of :id => model.id. clean up the form helper method. use flash[:notice] instead of flash['notice'].
r2543@sedna: jeremy | 2005-06-12 02:33:22 -0700
whitespace
r2544@sedna: jeremy | 2005-06-12 02:56:57 -0700
update changelogs
r2545@sedna: jeremy | 2005-06-12 03:26:23 -0700
test dynamic form help when @post is not a new record
r2546@sedna: jeremy | 2005-06-12 03:44:14 -0700
touch up TestCase#process sanity assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-12 05:33:23 +00:00
David Heinemeier Hansson
0367317dd6
Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
473e5bde74
Fixed that compute_public_path should recognize external URLs, so image_tag(" http://www.example.com/images/icon.gif ") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751
Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
496ee0cd1b
Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
45780be2a7
Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:24:18 +00:00