github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,914 Commits 34 Branches 105 Tags
0d0fbf1e648606c9499e332bad412da005a4e37f
Commit Graph

4265 Commits

Author SHA1 Message Date
Xavier Noria
43291469cb deletes the rdoc task of each component, they are no longer published separately 2010-08-20 13:30:31 +02:00
Aaron Patterson
949c7e2d0e fisting after_rollback and after commit callbacks 2010-08-20 00:06:49 -07:00
Santiago Pastorino
b91dcb63d0 Bump up tzinfo to 0.3.23 2010-08-20 02:39:09 -03:00
Aaron Patterson
bfd8be7fab updates return number of rows matched rather than number of rows affected 2010-08-19 19:13:50 -07:00
Andrew White
0b73f2af0e Optimize find_sti_class when store_full_sti_class is true 
[#5403]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-08-19 16:03:15 -05:00
Neeraj Singh
2e45542942 While creating a new record using has_many create method default scope of child should be respected. 
author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 14:52:15 -03:00
Aaron Patterson
a4458f5d21 removing useless ternary 2010-08-19 10:46:10 -07:00
Aaron Patterson
a70248c3d8 we should wrap strings as sql literals 2010-08-19 10:35:09 -07:00
Jeremy Kemper
d3e30a18b2 Memoize STI class lookups for the duration of a request 2010-08-19 11:07:09 -05:00
Aaron Patterson
072cd60379 refactor if / else to ||= 2010-08-18 23:37:37 -07:00
Xavier Noria
5a1d957dce avoids warnings about mismatched indentations in Ruby 1.9.2 2010-08-19 03:44:55 +02:00
Xavier Noria
c510f05967 get rid of the warning "+ after local variable is interpreted as binary operator even though it seems like unary operator" in Ruby 1.9.2 2010-08-19 02:08:28 +02:00
Aaron Patterson
e4f424d577 refactoring to remove duplicate logic 2010-08-18 12:10:48 -07:00
Aaron Patterson
93f335b6fb call to present? is not necessary 2010-08-18 11:51:59 -07:00
Santiago Pastorino
cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Jeff Lawson
c017041e68 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:16:03 -07:00
Jeff Lawson
7ce1539934 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:15:58 -07:00
Santiago Pastorino
f1b33f7f22 Restore pet -> owner relationship to the previous state 
[#5365]
 2010-08-16 22:46:55 -03:00
Mark Turner
6177a0be96 added testcase for belongs_to with a counter_cache and touch 
[#5365 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-16 22:41:12 -03:00
Xavier Noria
fb6b805620 code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them 2010-08-17 03:32:11 +02:00
Raimonds Simanovskis
c7dd49eb2a Replaced hardcoded SessionStore table creation SQL with calls to ActiveRecord adapter migration methods 
Otherwise hardcoded table creation SQL was failing on Oracle database
 2010-08-16 15:21:58 -07:00
Raimonds Simanovskis
4e3d220da3 added dependencies in Gemfile for running ActiveRecord tests with Oracle database 2010-08-16 15:21:54 -07:00
Santiago Pastorino
8010e4f476 assert_equal here 2010-08-16 19:09:23 -03:00
Santiago Pastorino
3c8b50020a Revert "Makes AR use AMo to_key implementation" 
This reverts commit 36a84a4f15.
 2010-08-15 11:33:21 -03:00
Santiago Pastorino
a81c956bf1 remove already defined method to avoid warnings 2010-08-15 07:59:40 -03:00
Santiago Pastorino
69de30d01f Revert "connection reader is defined later" 
This reverts commit f4cce71d96.
 2010-08-15 07:47:52 -03:00
Santiago Pastorino
f4cce71d96 connection reader is defined later 2010-08-15 07:19:53 -03:00
Santiago Pastorino
bcd62cdafd Makes topics.written_on null => true back again some tests rely on that 2010-08-15 07:19:06 -03:00
Santiago Pastorino
9a7e7e5fdb Add missing model 2010-08-14 18:49:04 -03:00
Santiago Pastorino
59a0700b56 Both tests are using the same model, move the model to another file and add the missing require 2010-08-14 18:48:06 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Santiago Pastorino
1590377886 Makes AR use AMo to_key implementation 
[#5249]
 2010-08-13 22:26:44 -03:00
Santiago Pastorino
27fb88aa22 This method is actually not used, it's implemented on the concrete adapters 
[#5331 state:committed]
 2010-08-13 21:19:47 -03:00
Aaron Patterson
be5d1608cb converting to a symbol is not necessary 2010-08-13 16:50:31 -07:00
Prem Sichanugrist
a7eb8d97a4 Removing most of the symbol to proc usage in Active Record 
This will hopefully make Active Record run a bit more faster.
 2010-08-13 16:24:49 -07:00
Aaron Patterson
b9eec677c4 avoid direct use of arel constants 2010-08-13 13:33:08 -07:00
Aaron Patterson
af3e39358c removing references to arel constants 2010-08-13 12:37:18 -07:00
Aaron Patterson
e18bd86314 avoiding symbol to proc again 2010-08-13 12:37:07 -07:00
Aaron Patterson
4439e57ee0 do not use arel constants directly 2010-08-13 12:37:03 -07:00
Aaron Patterson
5651e4c835 symbol to proc is slow, we should avoid it 2010-08-13 12:36:59 -07:00
Xavier Noria
fddcd21bd1 be more precise re :validate and :autosave 2010-08-12 19:31:47 +02:00
Neeraj Singh
6ed1ba472e Ensure we can nest include calls [#5285 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-12 13:10:58 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26 revises some autosave docs, style and content 2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. 2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837 commit review: applies guidelines to "# =>" 2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef updating documentation for named_scope and default_scope 2010-08-12 10:23:20 -04:00
Mark Turner
1049bae132 fixed indentation in test cases 
Signed-off-by: wycats <wycats@gmail.com>
 2010-08-11 23:55:53 -07:00
Paul Hieromnimon
007c4da9ae Raising exception if fixture file can't be found 2010-08-11 15:47:34 -07:00