Commit Graph

4659 Commits

Author SHA1 Message Date
Aaron Patterson
296467fcc4 only returning where values for the corresponding relation, also filtering where value hash based on table name [#5234 state:resolved] [#5184 state:resolved] 2010-10-30 13:25:49 -07:00
Aaron Patterson
cbca12f908 adding tests for #5234 and #5184. Tests were from Akira Matsuda. Thanks Akira! 2010-10-30 13:20:54 -07:00
Aaron Patterson
7d5762d2c2 no need to merge where values if no new where values have been added 2010-10-30 12:28:49 -07:00
Denis Odorcic
cc9742920c Convert :primary_key in association to a string before comparing to column names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved] 2010-10-30 11:24:36 -07:00
Aaron Patterson
67a3a70295 refactoring find_join_association 2010-10-30 08:45:40 -07:00
Ernie Miller
0bb85ed9ff Fix issues when including the same association multiple times and mixing joins/includes together. 2010-10-30 06:48:44 -07:00
Jon Leighton
b82fab25f9 Refactoring: replace the mix of variables like @finder_sql, @counter_sql, etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. 2010-10-30 06:30:00 -07:00
Aaron Patterson
2a47e7ef10 only do string substitution on column names once, remove intermediate data structures 2010-10-30 06:16:54 -07:00
Aaron Patterson
2e07260f36 columns are always strings 2010-10-30 06:12:50 -07:00
Aaron Patterson
6cf44a1bd6 no need to to_i, sqlite does that for us 2010-10-30 06:11:06 -07:00
Aaron Patterson
6a3d6b7f13 select_all() should always return an array, so no need to test 2010-10-27 14:39:24 -07:00
Aaron Patterson
f6ddb3553a fisting test name 2010-10-27 14:33:02 -07:00
Aaron Patterson
9ce0211806 speeding up query cache 2010-10-27 14:23:01 -07:00
Aaron Patterson
7104122cc3 making query cache work with prepared statements 2010-10-27 14:05:40 -07:00
Aaron Patterson
e73b0b84d9 renaming bind_values to binds where it makes sense 2010-10-26 13:44:11 -07:00
Aaron Patterson
104d0b263e adding backwards compatibility for non-prepare statement handling drivers 2010-10-26 13:44:11 -07:00
Aaron Patterson
fca229e205 caching column values 2010-10-26 13:44:11 -07:00
Aaron Patterson
02128d628c setting the authorized session clears the statement cache 2010-10-26 13:44:11 -07:00
Aaron Patterson
9d9aed433b add a session authorization setter to the pg connection 2010-10-26 13:44:11 -07:00
Aaron Patterson
1741bbe2d5 avoiding statement cache if there are no bind values 2010-10-26 13:44:10 -07:00
Aaron Patterson
28a18b5988 folding async_exec to exec 2010-10-26 13:44:10 -07:00
Aaron Patterson
03e4ea5290 clear cache before resetting the connection 2010-10-26 13:44:10 -07:00
Aaron Patterson
1b4e0b6542 prepare the statement before we cache the key 2010-10-26 13:44:10 -07:00
Aaron Patterson
43bbb25ddd bind substitution is working properly 2010-10-26 13:44:10 -07:00
Aaron Patterson
9d46e0d012 bind parameters are now typecast 2010-10-26 13:44:10 -07:00
Aaron Patterson
e2813479f9 basic bind parameters are working 2010-10-26 13:44:09 -07:00
Aaron Patterson
ffb999125a initial exec() method is working in pg adapter 2010-10-26 13:44:09 -07:00
Aaron Patterson
eb83eb6c98 monkey patching with enumerable so we can call each 2010-10-26 13:44:09 -07:00
Aaron Patterson
fe2ee4fafd monkey patching Mysql::Stmt, calling free on the metadata 2010-10-26 13:44:09 -07:00
Aaron Patterson
ee959a9ca1 free the result after slurping 2010-10-26 13:44:09 -07:00
Aaron Patterson
efc10a8a64 eliminating some calls to execute() 2010-10-26 13:44:09 -07:00
Aaron Patterson
050d7d3e49 statements are cached, cache is cleared on reconnect 2010-10-26 13:44:09 -07:00
Aaron Patterson
d4b0bcb88e all mysql tests are passing 2010-10-26 13:44:09 -07:00
Aaron Patterson
d6b16bbaf7 one more mysql test left! 2010-10-26 13:44:09 -07:00
Aaron Patterson
77b1193ac1 mysql tests are mostly passing 2010-10-26 13:44:08 -07:00
Aaron Patterson
9c7e2e4117 find_one uses prepared statement cache 2010-10-26 13:44:08 -07:00
Aaron Patterson
5abebfb569 clearing statements on disconnect and reset 2010-10-26 13:44:08 -07:00
Aaron Patterson
54ff59f3ba refactoring tests 2010-10-26 13:44:08 -07:00
Aaron Patterson
d7207cf504 type casting bound value based on column associated with value 2010-10-26 13:44:08 -07:00
Aaron Patterson
76d0805786 stop calling execute directly on the database connection 2010-10-26 13:44:08 -07:00
Aaron Patterson
77d548a6d3 removing another execute 2010-10-26 13:44:08 -07:00
Aaron Patterson
7023d73f26 removing more execute calls 2010-10-26 13:44:08 -07:00
Aaron Patterson
e60fecd829 removing more calls to execute 2010-10-26 13:44:08 -07:00
Aaron Patterson
853d39e854 removing some uses of execute 2010-10-26 13:44:07 -07:00
Aaron Patterson
cc468d3ec8 exec returns an AR::Result 2010-10-26 13:44:07 -07:00
Aaron Patterson
6ceffb8178 adding bind_values to relations 2010-10-26 13:44:07 -07:00
Aaron Patterson
497218d5db adding bind value substitution 2010-10-26 13:44:07 -07:00
Aaron Patterson
ef0cf143a9 adding the abstract method 2010-10-26 13:44:07 -07:00
Aaron Patterson
c376fd488c Revert "removing unused variable"
This reverts commit 3e4ede81d6.
2010-10-26 13:43:06 -07:00
Aaron Patterson
f61f758761 reducing the number of parameters to select() 2010-10-26 13:43:06 -07:00