Marcel Molina
064842f516
Convert boolean form options form the tag_helper. Recloses #809 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 21:34:51 +00:00
Sam Stephenson
0886bb391d
Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 20:35:13 +00:00
Marcel Molina
a9de9c48c2
Make assert_tag :children count appropriately. Closes #2181 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-09 01:45:21 +00:00
Thomas Fuchs
e7afaf62bd
Added new scriptaculous options for auto_complete_field #2343 [m.stienstra@fngtps.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 05:43:53 +00:00
Jamis Buck
1e08d11579
Don't prepend the asset host if the string is already a fully-qualified URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 19:10:20 +00:00
David Heinemeier Hansson
438db964ad
Testing should also use a default REQUEST_METHOD
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-29 08:43:17 +00:00
Jeremy Kemper
5d19fd7841
Unit tests and fixtures for multipart posts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:19:26 +00:00
Thomas Fuchs
516dc2c0f1
Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:20:47 +00:00
Marcel Molina
1e87d6e887
Added test coverage for stylesheet_path to show that it works as requested in #1471 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 02:08:58 +00:00
Jeremy Kemper
17d2732b1c
Ticket #2295 - Tolerate consecutive delimiters in query parameters
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 22:23:37 +00:00
Nicholas Seckar
564077373d
Streamline render process, code cleaning. Closes #2294 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 16:45:39 +00:00
Scott Barron
a111e1a271
Keep flash after component is rendered. Closes #2291 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 11:02:11 +00:00
Marcel Molina
b54560600b
Have text helpers use built in Regexp.escape rather than home grown alternative
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 20:49:52 +00:00
Jeremy Kemper
9852197f83
r3573@asus: jeremy | 2005-09-26 11:38:44 -0700
...
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
r3574@asus: jeremy | 2005-09-26 14:32:11 -0700
Get rid of constant redefine warning.
r3575@asus: jeremy | 2005-09-26 14:33:07 -0700
Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
r3576@asus: jeremy | 2005-09-26 14:33:49 -0700
Unit test overridden original_filename against normal filenames and full Windows paths.
r3577@asus: jeremy | 2005-09-26 14:33:57 -0700
Update change log.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 17:59:46 +00:00
Scott Barron
fa7d4a691f
This seems unnecessary to call in teardown and is causing the tests
...
to error because the table has been dropped.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-25 10:41:22 +00:00
Thomas Fuchs
2346f5716f
Fix open/save dialog in IE not opening files send with send_file/send_data, #2279
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-25 06:53:42 +00:00
David Heinemeier Hansson
2a31691ee2
Fixed that auto_discovery_link_tag couldn't take a string as the URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-22 11:37:16 +00:00
Jamis Buck
4fa9a2bfe2
Require 'pp' early to prevent the pretty-print methods being mixed in too late and messing up a test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 13:55:27 +00:00
David Heinemeier Hansson
3754822f43
Fixed problem with send_file and WEBrick using stdout #1812
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
7f26415d3c
Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7
Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 06:44:53 +00:00
Jamis Buck
390280b842
Make the truncate() helper multi-byte safe (assuming $KCODE has been set to something other than "NONE") #2103
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 21:36:36 +00:00
Nicholas Seckar
b9c79f195f
Add routing tests from #1945
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:37:43 +00:00
Nicholas Seckar
57e0cf8e95
Add a routing test case covering #2101
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:11:24 +00:00
David Heinemeier Hansson
9acb1f95c9
Make upload progress not throw JavaScript errors when there is no progress bar #2208 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-16 08:44:38 +00:00
David Heinemeier Hansson
e9504bb6f7
Cache relative_url_root for all webservers, not just Apache #2193 [skae]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:32:16 +00:00
David Heinemeier Hansson
c1505e3e2b
Included UrlRewriter tests in rake run and made them not depend on Hash order
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:24:29 +00:00
David Heinemeier Hansson
d985260ed7
Made base_tests.rb run as part of rake
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:20:32 +00:00
Jamis Buck
5e3364ef45
More auto-link fixes (to include query strings in autolinked text)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-14 12:07:05 +00:00
Jamis Buck
b97f4e4597
Fix autolinking to not include trailing tags as part of the URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 18:48:34 +00:00
David Heinemeier Hansson
ebb7bd7835
Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 08:31:32 +00:00
David Heinemeier Hansson
53ee2c9633
Added ActionController::Base.session_store=, session_store, and session_options to make it easier to tweak the session options (instead of going straight to ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 07:46:57 +00:00
David Heinemeier Hansson
2fe8610673
Added TextHelper#cycle to cycle over an array of values on each hit (useful for alternating row colors etc) #2154 [dave-ml@dribin.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 05:26:25 +00:00
Nicholas Seckar
27962ead03
Add ability to specify Route Regexps for controllers. Closes #1917 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb
Provide Named Route's hash methods as helper methods. Closes #1744 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:45:55 +00:00
David Heinemeier Hansson
2be3c00863
Split macros test into their own suite
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 08:40:46 +00:00
David Heinemeier Hansson
a15068726f
Added :multipart option to ActiveRecordHelper#form to make it possible to add file input fields #2034 [jstirk@oobleyboo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 08:39:23 +00:00
David Heinemeier Hansson
b62243a5cc
Added :disabled option to all data selects that'll make the elements inaccessible for change #2167 , #253 [eigentone]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 05:58:00 +00:00
David Heinemeier Hansson
da7ba91d86
Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166 , #1671 [eigentone]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
3cf7a0a460
Added Kernel#silence_warnings and puts it into use throughout the framework
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 04:58:27 +00:00
David Heinemeier Hansson
afbfde9357
Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
e3c02d8c66
Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689
Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028
Fixed that onclick would be overridden even when special features werent used
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d
Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
e6428abd23
Fixed a broken test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:30:13 +00:00
David Heinemeier Hansson
7b235f0213
Use this.href, not unexisting url
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df
Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 12:56:33 +00:00
Nicholas Seckar
3108764367
Fix overwrite params. Closes #1909
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
258bacbf82
Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-04 00:33:45 +00:00