github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-04 03:05:27 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,835 Commits 34 Branches 105 Tags
142b074e9123f477ea8f93898690fc462fdcbf90
Commit Graph

1062 Commits

Author SHA1 Message Date
Rick Olson
da6f5a1cb4 Change ActionView template defaults. Look for templates using the request format first, such as show.html.erb or show.xml.builder, before looking for the old defaults like show.erb or show.builder [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-02 00:02:11 +00:00
David Heinemeier Hansson
0cac2806a6 Dropped the use of ; as a separator of non-crud actions on resources and went back to the vanilla slash. It was a neat idea, but lots of the non-crud actions turned out not to be RPC (as the ; was primarily intended to discourage), but legitimate sub-resources, like /parties/recent, which didn't deserve the uglification of /parties;recent. Further more, the semicolon caused issues with caching and HTTP authentication in Safari. Just Not Worth It [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 21:55:40 +00:00
Tobias Lütke
df3ee41126 Improved the handling of broken accept headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 16:42:21 +00:00
Rick Olson
2a305949d7 documentation project patches, closes #7342, #7319, #7316, #7190 [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 14:04:06 +00:00
Jamis Buck
777deb9d15 Make sure the expiry hash is built by comparing the to_param-ized values of each hash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-26 19:02:19 +00:00
Jeremy Kemper
b0685e9684 Fix PStore typo. Closes #7900. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-23 16:53:57 +00:00
Rick Olson
c6d7260841 Allow configuration of the default action cache path for #caches_action calls. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-22 10:12:34 +00:00
Tobias Lütke
f39fe3091f Fix nil error for requests with empty PATH_INFO header such as those which are send by the ScanAlert spider 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-19 18:02:24 +00:00
Jeremy Kemper
65704aeacd Never return nil from CGI#read_query for compatibility with plain CGI query params parser. Closes #7581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 13:39:58 +00:00
Jeremy Kemper
c593721e7c Revert [6430] since the test is faulty. References #7837, closes #7842. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 13:55:36 +00:00
Jeremy Kemper
814dd007e5 Performance: patch cgi/session/pstore to require digest/md5 once rather than per #initialize. Closes #7583. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:52:12 +00:00
Jeremy Kemper
f596dda0bb Undeprecate redirect_to with Hash argument and additional url_for parameters. Closes #7837. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:21:19 +00:00
Jeremy Kemper
bbcfb9b625 Cookie session store: ensure that new sessions doesn't reuse data from a deleted session in the same request. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 11:33:10 +00:00
Jeremy Kemper
1f02271048 Deprecation: verification with :redirect_to => :named_route shouldn't be deprecated. Closes #7525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:38:41 +00:00
Jeremy Kemper
5219aa9008 Cookie session store: raise ArgumentError when :session_key is blank. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 20:44:16 +00:00
Jeremy Kemper
f770165cc2 Deprecation: remove deprecated url_for(:symbol, *args) and redirect_to(:symbol, *args) controller methods. Use named routes instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:44:18 +00:00
Jeremy Kemper
d20b943551 Deprecation: privatize deprecated render_partial and render_partial_collection methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:06:41 +00:00
Jeremy Kemper
da87839c89 Deprecation: remove toplevel components directory and uses_component_template_root. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:46:12 +00:00
Jeremy Kemper
ee71950f60 Deprecation: remove deprecated dependency methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:37:39 +00:00
Jeremy Kemper
0631400b4a Deprecation: remove deprecated request methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:32:45 +00:00
Jeremy Kemper
cb6d94cc57 Deprecation: remove deprecated redirect methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:58:22 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:49:52 +00:00
Jeremy Kemper
07d8f46b85 Consistent public/protected/private visibility for chained methods. Closes #7813. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 02:14:31 +00:00
Jeremy Kemper
dbf42e379b Prefer MIME constants to strings. Closes #7707. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 09:46:04 +00:00
Jeremy Kemper
e17df19b86 Allow array and hash query parameters. Array route parameters are converted/to/a/path as before. References #6765, #7462. Closes #7047. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 07:47:23 +00:00
Rick Olson
2b7dbad8e0 Add a #dbman attr_reader for CGI::Session and make CGI::Session::CookieStore#generate_digest public so it's easy to generate digests 
using the cookie store's secret. [Rick]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 04:09:14 +00:00
Tobias Lütke
e52c28a425 Ignore odd charset declaration in CONTENT_TYPE header which would throw off mime type lookup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-05 18:24:17 +00:00
David Heinemeier Hansson
8a1956bd99 Sans request please 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-04 20:44:01 +00:00
David Heinemeier Hansson
e0179c1254 Added Request#url that returns the complete URL used for the request [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-04 20:32:38 +00:00
David Heinemeier Hansson
4568c1d744 Added URL escaping of user and password when used through the UrlWriter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-04 20:10:51 +00:00
Jeremy Kemper
8f94cc5cb4 Extract dynamic scaffolding into a plugin. Closes #7700. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6306 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-04 08:35:52 +00:00
David Heinemeier Hansson
bf6d4cede7 Added user/password options for url_for to add http authentication in a URL [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-03 22:19:54 +00:00
Jeremy Kemper
f254831e83 Cookie store: use OpenSSL::HMAC instead of basic hash. Introduce :secret block and :digest option. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-03 13:54:54 +00:00
Jeremy Kemper
a0563bf7b0 Cookie store: test that >4K raises CookieOverflow and that unverifiable cookies are automatically deleted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6294 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-03 08:18:30 +00:00
David Heinemeier Hansson
e69390dffe Options are more often than not meaningless babble, just go nondescript instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-01 23:27:04 +00:00
Jeremy Kemper
df7ca38d7d session_enabled? works with session :off. Closes #6680. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-27 06:36:25 +00:00
David Heinemeier Hansson
b8cd80550f Added :port and :host handling to UrlRewriter (which unified url_for usage, regardless of whether it's called in view or controller) #7616 [alancfrancis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-25 20:22:09 +00:00
David Heinemeier Hansson
9b46f69381 Allow send_file/send_data to use a registered mime type as the :type parameter #7620 [jonathan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-25 20:16:58 +00:00
David Heinemeier Hansson
784298008b Allow routing requirements on map.resource(s) (closes #7633) [quixoten] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-25 20:13:19 +00:00
Jeremy Kemper
781985f7f2 Cookie session store: empty and unchanged sessions don't write a cookie. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-25 16:35:24 +00:00
David Heinemeier Hansson
f95dfff966 Added helper(:all) as a way to include all helpers from app/helpers/**/*.rb in ApplicationController [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-24 20:31:34 +00:00
Jeremy Kemper
236fe10fe9 Integration tests: introduce methods for other HTTP methods. Closes #6353. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-22 09:28:10 +00:00
Jeremy Kemper
c8f7860d50 CGI escape the session cookie. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-22 01:17:28 +00:00
Jeremy Kemper
5a1251dc2d Session configuration in config/environment.rb instead of app/controllers/application.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-22 00:57:02 +00:00
Tobias Lütke
2ffbc6115e Enable active record cache automatically for all actions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 18:08:39 +00:00
Jeremy Kemper
de0a0d700e Routing: better support for escaped values in route segments. Closes #7544. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 10:05:07 +00:00
Jeremy Kemper
f29857690f Introduce a cookie-based session store as the Rails default. Sessions typically contain at most a user_id and flash message; both fit within the 4K cookie size limit. A secure hash is included with the cookie to ensure data integrity (a user cannot alter his user_id without knowing the secret key included in the hash). If you have more than 4K of session data or don't want your data to be visible to the user, pick another session store. Cookie-based sessions are dramatically faster than the alternatives. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 09:17:38 +00:00
David Heinemeier Hansson
2afc01b7ce Make assert_select access content_type through accessor instead of header 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 00:40:58 +00:00
David Heinemeier Hansson
21187c0fb4 Apply the rest of Chads patch 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 00:29:44 +00:00
David Heinemeier Hansson
e105653066 Added .erb and .builder as preferred aliases to the now deprecated .rhtml and .rxml extensions [Chad Fowler]. This is done to separate the renderer from the mime type. .erb templates are often used to render emails, atom, csv, whatever. So labeling them .rhtml doesn't make too much sense. The same goes for .rxml, which can be used to build everything from HTML to Atom to whatever. .rhtml and .rxml will continue to work until Rails 3.0, though. So this is a slow phasing out. All generators and examples will start using the new aliases, though. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 22:09:12 +00:00