github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 17:27:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,396 Commits 34 Branches 105 Tags
16529a92dd6178b5a8a80c91efda796fc2f4d43f
Commit Graph

1373 Commits

Author SHA1 Message Date
David Heinemeier Hansson
0d5a7d1d8c Stress that you should really install the C-based MySQL library when running on the pure Ruby one (closes #9507) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-20 23:40:48 +00:00
David Heinemeier Hansson
e86d1cd621 Added ActiveRecord::Base#to_json/from_json (currently does not support :include like to_xml) [DHH]. Added ActiveRecord::Base#from_xml [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-20 23:22:30 +00:00
Michael Koziarski
7010ee361e Stop users from calling .create on a has_many / habtm association when the owner is a new_record? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 10:26:56 +00:00
Tobias Lütke
4a1388adea Define dynamic finders as real methods after first usage. Close #9317 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 10:04:11 +00:00
Jeremy Kemper
7495b5ca75 Deprecation: remove deprecated threaded_connections methods. Use allow_concurrency instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 06:43:05 +00:00
Jeremy Kemper
81d619ea0d Associations macros accept extension blocks alongside modules. Closes #9346. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 21:19:44 +00:00
Jeremy Kemper
6b1901da8f Don't worry about retrieving the last inserted id. [tarmo_t] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 20:43:02 +00:00
Michael Koziarski
acbec3e565 Ensure that custom mutators aren't redefined by define_attribute_methods. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 09:29:02 +00:00
Jeremy Kemper
bfb906a905 Speed up and simplify query caching. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 06:15:58 +00:00
Jeremy Kemper
30fb7b8c8b connection.select_rows 'sql' returns an array (rows) of arrays (field values). Closes #2329. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-16 03:32:47 +00:00
Jeremy Kemper
b8657089f2 Eager loading respects explicit :joins. Closes #9496. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 23:50:12 +00:00
Jeremy Kemper
a6083b86d1 Extract Firebird, FronBase, and OpenBase adapters into gems. Closes #9508, #9509, #9510. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7492 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 23:22:58 +00:00
Jeremy Kemper
f92503c541 RubyGem database adapters: expects a gem named activerecord-<database>-adapter with active_record/connection_adapters/<database>_adapter.rb in its load path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7491 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 23:21:21 +00:00
David Heinemeier Hansson
79202b37dc Fixed that altering join tables in migrations would fail w/ sqlite3 #7453 [TimoMihaljov/brandon] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 21:23:05 +00:00
Jeremy Kemper
498d8ff72e Fix association writer with :dependent => :nullify. Closes #7314. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7477 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 07:29:22 +00:00
Jeremy Kemper
e6941149ab Deprecation: removed Reloadable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 00:25:59 +00:00
Jeremy Kemper
f7c371dff8 OpenBase: update for new lib and latest Rails. Support migrations. Closes #8748. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-13 23:21:14 +00:00
Jeremy Kemper
54a6ed1482 minor speedups + forward-compat syntax 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-13 23:13:34 +00:00
Jeremy Kemper
f9ba8566b5 minor speedup 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-13 08:20:08 +00:00
Jeremy Kemper
5f73c46741 Remove empty acts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 06:24:13 +00:00
David Heinemeier Hansson
ea0975a20b Moved acts_as_tree into a plugin of the same name on the official Rails svn (closes #9514) [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 03:25:59 +00:00
David Heinemeier Hansson
11f4d28344 Moved acts_as_nested_set into a plugin of the same name on the official Rails svn (closed #9516) [josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 03:09:37 +00:00
Michael Koziarski
bf8a4b0006 Remove broken require 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-10 04:53:46 +00:00
Michael Koziarski
aa36ca1c5f Remove acts_as_list. Users are advised to install the new plugin. References #9415. [josh, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-10 04:41:09 +00:00
David Heinemeier Hansson
ddf385a554 Remove the wrapping feature that was never actually turned into something real [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 23:39:10 +00:00
David Heinemeier Hansson
85800c110e Update copyright span 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 17:57:16 +00:00
Jeremy Kemper
7ace0a654c Match Fixnum and Float in particular. Rescue dup error and return result. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 04:53:29 +00:00
Jeremy Kemper
2894887925 Explicitly require active_record/query_cache before using it. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 04:31:26 +00:00
Michael Koziarski
aa32f66ebb Add :allow_blank to validations. Like allow_nil, but for values which are +blank?+. [jnoon] Closes #7383 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 05:37:52 +00:00
Rick Olson
51977bc261 Fix bug where unserializing an attribute attempts to modify a frozen @attributes hash for a deleted record. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-04 17:32:48 +00:00
Michael Koziarski
3bbef581af Work around mysql limitations for defaults on text columns with not null. Closes #9324 [caio] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-04 02:44:10 +00:00
Michael Koziarski
6246fad19a Remove deprecated functionality from edge rails. Closes #9387 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:17:09 +00:00
Michael Koziarski
b18d9568a6 Ensure QueryCache doesn't try to dup numeric results (does not affect the major OS database). Closes #7661 [tomafro, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:52:58 +00:00
Jeremy Kemper
55efae2387 Performance: absorb instantiate and initialize_with_callbacks into the Base methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 01:56:39 +00:00
Michael Koziarski
18a3333a30 Formatting, grammar and spelling fixes for the associations documentation. [seanhussey] Closes #8899 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:18:57 +00:00
Michael Koziarski
c11ca0e0bf Fix documentation error in xml serialization. [matt] Closes #9001 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:18:14 +00:00
Michael Koziarski
5972fd493b Formatting and grammatical fixes for the acts_as_* documentation [seanhussey, kampers] Closes #9107 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:17:49 +00:00
Michael Koziarski
5840108b6e Pass the right binding when string is passed to :if with validations. [caspercg] Closes #9300 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:17:17 +00:00
Michael Koziarski
93eaaef43c Use extract_options instead of ad-hoc partial implementations. [norbert] Closes #9313 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:16:49 +00:00
Michael Koziarski
5cbc782ece Remove unnecessary loop in validates_presence_of. [sur] Closes #9392 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7362 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:15:47 +00:00
Michael Koziarski
016947ceed Make sure create! raises errors on validation when creating multiple records. [hasmanyjosh] Closes #8952 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 20:44:51 +00:00
David Heinemeier Hansson
d24c73dedb Fix spacing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7356 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 22:11:14 +00:00
David Heinemeier Hansson
3566be4728 Fixed that eager loading queries and with_scope should respect the :group option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 21:58:38 +00:00
David Heinemeier Hansson
0e452bb02d Fixed that eager loading queries should respect the :group option as well [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 21:29:21 +00:00
Michael Koziarski
29b0707f07 Improve performance and functionality of the postgresql adapter. Closes #8049 [roderickvd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-16 06:26:30 +00:00
Michael Koziarski
f008566d65 Don't clobber :includes passed to count on has_many association. Closes #9175 [danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-16 04:37:31 +00:00
Michael Koziarski
82b244e3ff Make sure has_many associations honour :include when counting. Closes #9167 [danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-16 04:36:55 +00:00
Michael Koziarski
5b801b5960 Change the implementation of ActiveRecord's attribute reader and writer methods: 
* Generate Reader and Writer methods which cache attribute values in hashes.  This is to avoid repeatedly parsing the same date or integer columns.
 * Move the attribute related methods out to attribute_methods.rb to de-clutter base.rb
 * Change exception raised when users use find with :select then try to access a skipped column.  Plugins could override missing_attribute() to lazily load the columns.
 * Move method definition to the class, instead of the instance
 * Always generate the readers, writers and predicate methods.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-14 08:53:02 +00:00
Michael Koziarski
d4bf5e9b34 Make habtm respect the :select option. Closes #9207. [Aleksey Kondratenko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-07 09:53:33 +00:00
Michael Koziarski
bb94ce92fc Let inspect on AR classes work when the table doesn't exist. Closes #9194 [tarmo, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-06 00:18:50 +00:00