Commit Graph

114 Commits

Author SHA1 Message Date
Sam Stephenson
5f44411d94 Backing out of [3470] until visual_effect, et al can work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 07:27:24 +00:00
Sam Stephenson
8436147825 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 06:52:26 +00:00
David Heinemeier Hansson
ea30f7353b Raise a RedirectBackError if redirect_to :back is called when theres no HTTP_REFERER defined (closes #3049) [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 01:52:23 +00:00
Sam Stephenson
f9937dd041 Pass along blocks from render_to_string to render
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:08:41 +00:00
Sam Stephenson
06dd1f2ca3 Add render :update for inline RJS
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:04:07 +00:00
Marcel Molina
489ace60fb Remove Upload Progress. Closes #2871.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:27:53 +00:00
Tobias Lütke
373bc86d2d only log session_id if @session object responds to .session_id.
In functional test cases you often pass in a hash as session object which doesn't have this method. 


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-22 21:16:11 +00:00
David Heinemeier Hansson
778d6704d4 Add session ID to default logging, but remove the verbose description of every step [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-22 04:04:56 +00:00
Marcel Molina
233208b8bb Don't try to strip out the controller name if default_action_name is nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-20 05:32:39 +00:00
Marcel Molina
39766a9b4c Don't include a layout when rendering an rjs template using render's :template option.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-17 06:38:06 +00:00
Sam Stephenson
bea737eb5a Make ActionController's render honor the :locals option when rendering a :file. Closes #1665.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 08:37:04 +00:00
Marcel Molina
62fe5bbfb1 Make rjs templates always implicitly skip out on layouts.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 08:32:17 +00:00
Jeremy Kemper
5cd2f32697 Update documentation for render :file. References #2858.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 00:12:46 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 01:03:24 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
4f754985d0 Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"])
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-02 14:47:03 +00:00
Jeremy Kemper
ddf6910941 ensure close_session in AC::Base#process
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-02 01:23:34 +00:00
Scott Barron
025949102e Fix problem where redirecting components can cause an
infinite loop [Rick Olson]

Closes #2654


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-30 13:13:02 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:20:46 +00:00
Nicholas Seckar
86a571090c Reset template variables after using render_to_string. Closes #2559
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-25 02:15:08 +00:00
Jeremy Kemper
22d9bad8a0 Expose the session model backing CGI::Session
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-20 21:59:48 +00:00
Jamis Buck
1c057b7237 Update/clean up AP documentation (rdoc)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-16 15:42:03 +00:00
Marcel Molina
48fd667bda Raise an exception if an attempt is made to insert more session data into the ActiveRecordStore data column than the column can hold. Closes #2234.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-15 14:39:29 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:26:39 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-03 21:20:52 +00:00
David Heinemeier Hansson
c6d8a1f975 Use a nicer date format
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 19:00:28 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:43:17 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
48018bf4b5 Moved session options to SessionManagement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 07:48:12 +00:00
David Heinemeier Hansson
53ee2c9633 Added ActionController::Base.session_store=, session_store, and session_options to make it easier to tweak the session options (instead of going straight to ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 07:46:57 +00:00
David Heinemeier Hansson
33e2ccfb26 Dont log creation of view class
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 18:14:16 +00:00
David Heinemeier Hansson
dc2a3af133 Dont encourage custom url options to be called with symbol #2047
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 07:25:08 +00:00
David Heinemeier Hansson
c8e0e10e28 Added documentation for overwrite_params #2146 [Michael Shuerig]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:50:14 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:28:10 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 12:08:24 +00:00
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:54:29 +00:00
Nicholas Seckar
34e795ff0e Use string key to set action_name for controllers. Closes #1968
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-30 23:52:53 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
David Heinemeier Hansson
d2d38f6700 Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:20:20 +00:00
David Heinemeier Hansson
cb0f8fda96 Worked around a Safari bug where it wouldn't pass headers through if the response was zero length by having render :nothing return ' ' instead of ''
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 19:31:48 +00:00
David Heinemeier Hansson
fede0f573e Fixed documentation for :action/:template confusion #1643
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:10:32 +00:00