github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 09:44:56 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,730 Commits 34 Branches 105 Tags
1902ef6caa68329aad0cf6ebfebdaa9ce2ea8427
Commit Graph

720 Commits

Author SHA1 Message Date
David Heinemeier Hansson
87b7b5b3e7 Added fixtures :all to test_helper.rb to assume that most people just want all their fixtures loaded all the time [DHH] Added fixtures :all as a way of loading all fixtures in the fixture directory at once (closes #7214) [manfred] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-25 17:31:43 +00:00
David Heinemeier Hansson
25bb98e42d Added database connection as a yield parameter to ActiveRecord::Base.transaction so you can manually rollback [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 22:13:39 +00:00
Tobias Lütke
7842caed94 Fixed query cache when multiple database connections were involved 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-21 21:54:41 +00:00
Tobias Lütke
b5419cd66e You can now use cache in instance hierachies. This allows ActiveRecord::Base.cache { } usage to cache everything 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 23:42:04 +00:00
Jeremy Kemper
5b7630e174 MySQL disallows TEXT defaults so don't test for them. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-11 09:17:10 +00:00
Jamis Buck
83752373b9 Made increment_counter/decrement_counter play nicely with optimistic locking, and added a more general update_counters method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-07 16:10:40 +00:00
Tobias Lütke
f458b376c5 Introducing Model.cache { ... } for the occasional query caching needs. ( fantastic to reduce the 200 SELECT * from accounts WHERE id=1 queries in your views ) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 21:16:07 +00:00
Jamis Buck
3f4cbccb9c When dealing with SQLite3, use the table_info pragma helper, so that the bindings can do some translation for when sqlite3 breaks incompatibly between point releases. Also, make current_adapter? use is_a? instead of instance_of? to account correctly for adapter subclassing. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-30 03:14:55 +00:00
Jeremy Kemper
d5e122002a Oracle: fix lob and text default handling. Closes #7344. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6090 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-29 22:06:08 +00:00
Jeremy Kemper
16f6bd4070 SQLServer: don't choke on strings containing 'null'. Closes #7083. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 17:51:21 +00:00
Jeremy Kemper
269ad9711d MySQL: blob and text columns may not have defaults in 5.x. Update fixtures schema for strict mode. Closes #6695. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 15:45:06 +00:00
Jeremy Kemper
5acea7fc9c update_all can take a Hash argument. sanitize_sql splits into two methods for conditions and assignment since NULL values and delimiters are handled differently. References #6583, closes #7365. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 15:12:54 +00:00
Jeremy Kemper
7ce6753526 Post title and body not null. References #6778. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 09:11:15 +00:00
Jeremy Kemper
8f5c12e451 MySQL: SET SQL_AUTO_IS_NULL=0 so 'where id is null' doesn't select the last inserted id. Closes #6778. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 08:49:23 +00:00
Rick Olson
1a11bffde1 Don't create instance writer methods for class attributes. Closes #7401 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 01:31:31 +00:00
Rick Olson
d5bd679340 Add missing tests ensuring callbacks work with class inheritance. Closes #7339 [sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6026 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 03:04:48 +00:00
Jeremy Kemper
0eb8398cfa Fixtures use the table name and connection from set_fixture_class. Closes #7330. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 01:29:49 +00:00
Jeremy Kemper
06afb8c746 Subclasses of an abstract class work with single-table inheritance. References #5704, closes #7284. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-23 04:19:16 +00:00
Michael Koziarski
71a4f7161f Allow the Oracle adapter to insert a string "null". Closes #6997 [laurelfan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-16 01:39:05 +00:00
Jeremy Kemper
6019c26856 change_column accepts :default => nil. Closes #6956. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 02:22:53 +00:00
Jeremy Kemper
a491f92860 MySQL, PostgreSQL: change_column_default quotes the default value and doesn't lose column type information. References #3987, closes #6664. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 01:24:23 +00:00
Jeremy Kemper
e310344111 Oracle: create_table takes a :sequence_name option to override the 'tablename_seq' default. Closes #7000. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 00:34:43 +00:00
Jeremy Kemper
9ccb12a3dd Test that calculations don't modify their options hash. References #6929. [eventualbuddha] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 16:19:58 +00:00
Jeremy Kemper
b78458284b Aggregate reflection klass works with nested :class_name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 12:08:44 +00:00
Tobias Lütke
e24d2f7234 Apply scoping during initialize instead of create. Fixes setting of foreign key when using find_or_initialize_by with scoping. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 21:14:36 +00:00
Jeremy Kemper
c62e5e1a3a Demonstrate that a value's required. References #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:52:08 +00:00
Jeremy Kemper
a66ad97dac Oops. References #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:50:35 +00:00
Jeremy Kemper
dbd7b5e111 Test MySQL implicit NULL for integer columns. Closes #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:46:01 +00:00
Jeremy Kemper
9073cef866 SQLServer: handle [quoted] table names. Closes #6635. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:44:28 +00:00
Jeremy Kemper
8d3ff3abc7 acts_as_nested_set works with single-table inheritance. Closes #6030. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:33:09 +00:00
Jeremy Kemper
ef4ac31de3 PostgreSQL: use a subselect to correctly perform eager finds with :limit and :order. Closes #4668. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:14:55 +00:00
Jeremy Kemper
3b6555acd4 Fix new_record? and id rollback. Closes #6910. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:10:06 +00:00
Jeremy Kemper
353238b6a4 Inline primary keys. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 04:58:08 +00:00
Jamis Buck
c398e83893 fix regression in has_one#create, that caused instances thus created to be orphaned 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-11 18:04:47 +00:00
Jeremy Kemper
28767075f4 Pass a range in :conditions to use the SQL BETWEEN operator. Closes #6974. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-10 10:13:18 +00:00
Michael Koziarski
84481dd3b4 Sybase adapter fixes. Closes #6926 [jsheets] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 00:12:06 +00:00
Rick Olson
1af2022cc3 Rollback #new_record? and #id values for created records that rollback in an after_save callback. Closes #6910 [Ben Curren] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-02 05:36:30 +00:00
Jamis Buck
6a5388b654 try to appease the angry Oracle 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 19:05:53 +00:00
Jamis Buck
0bfabaa048 make sure query attributes on custom fields works as it used to 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 17:24:35 +00:00
Michael Koziarski
58edaaad0b Ensure dynamic finders are anchored to the beginning of the method name to prevent 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:35:19 +00:00
Jeremy Kemper
4cf8bf7312 Pushing a record on an association collection doesn't unnecessarily load all the associated records. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 23:28:12 +00:00
Jeremy Kemper
7277c51891 Partially revert [5660] - makes more trouble than it resolves. References #5704, closes #6766. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:47:21 +00:00
Jeremy Kemper
8732ce291b Subclass instantiation doesn't try to explicitly require the corresponding subclass. Closes #6840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:23:56 +00:00
Jeremy Kemper
55d248ba72 use RAILS_DEFAULT_LOGGER in debug mode so we can log Dependencies activity 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:44:04 +00:00
Jeremy Kemper
5f18fd93de utf8 mysql topics table 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:04:42 +00:00
Rick Olson
41466a4c83 fix faulty inheritance tests and that eager loading grabs the wrong inheritance column when the class of your association is an STI subclass. Closes #6859 [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 03:10:39 +00:00
Jeremy Kemper
50c98942a5 Don't do introspection queries during locking tests [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 20:28:26 +00:00
Tobias Lütke
cdad2d41e1 Consolidated different create and create! versions to call through to the base class with scope. This fixes inconsistencies, especially related to protected attribtues. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 00:13:31 +00:00
Jeremy Kemper
8dea60b0c3 find supports :lock with :include. Check whether your database allows SELECT ... FOR UPDATE with outer joins before using. Closes #6764. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5682 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 22:07:55 +00:00
Tobias Lütke
0ee0c1b2aa Add AssociationCollection#create! to be consistent with AssociationCollection#create when dealing with a foreign key that is a protected attribute 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 17:55:44 +00:00